Skip to content

Commit 36be7d3

Browse files
committed
fix: update tests to match new submitUserMessage implementation
The tests were expecting handleWebviewAskResponse to be called, but PR #7793 changed the implementation to use submitUserMessage instead to fix chat message edit/delete duplication issues. This commit updates the tests to match the new implementation.
1 parent b40a5e8 commit 36be7d3

File tree

1 file changed

+9
-15
lines changed

1 file changed

+9
-15
lines changed

src/core/webview/__tests__/ClineProvider.spec.ts

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3008,7 +3008,7 @@ describe("ClineProvider - Comprehensive Edit/Delete Edge Cases", () => {
30083008
mockCline.apiConversationHistory = [{ ts: 1000 }, { ts: 2000 }, { ts: 3000 }] as any[]
30093009
mockCline.overwriteClineMessages = vi.fn()
30103010
mockCline.overwriteApiConversationHistory = vi.fn()
3011-
mockCline.handleWebviewAskResponse = vi.fn()
3011+
mockCline.submitUserMessage = vi.fn()
30123012

30133013
await provider.addClineToStack(mockCline)
30143014
;(provider as any).getTaskWithId = vi.fn().mockResolvedValue({
@@ -3041,6 +3041,8 @@ describe("ClineProvider - Comprehensive Edit/Delete Edge Cases", () => {
30413041
// Verify messages were edited correctly - the ORIGINAL user message and all subsequent messages are removed
30423042
expect(mockCline.overwriteClineMessages).toHaveBeenCalledWith([mockMessages[0]])
30433043
expect(mockCline.overwriteApiConversationHistory).toHaveBeenCalledWith([{ ts: 1000 }])
3044+
// Verify submitUserMessage was called with the edited content
3045+
expect(mockCline.submitUserMessage).toHaveBeenCalledWith("Edited message with preserved images", undefined)
30443046
})
30453047

30463048
test("handles editing messages with file attachments", async () => {
@@ -3062,7 +3064,7 @@ describe("ClineProvider - Comprehensive Edit/Delete Edge Cases", () => {
30623064
mockCline.apiConversationHistory = [{ ts: 1000 }, { ts: 2000 }, { ts: 3000 }] as any[]
30633065
mockCline.overwriteClineMessages = vi.fn()
30643066
mockCline.overwriteApiConversationHistory = vi.fn()
3065-
mockCline.handleWebviewAskResponse = vi.fn()
3067+
mockCline.submitUserMessage = vi.fn()
30663068

30673069
await provider.addClineToStack(mockCline)
30683070
;(provider as any).getTaskWithId = vi.fn().mockResolvedValue({
@@ -3093,11 +3095,7 @@ describe("ClineProvider - Comprehensive Edit/Delete Edge Cases", () => {
30933095
})
30943096

30953097
expect(mockCline.overwriteClineMessages).toHaveBeenCalled()
3096-
expect(mockCline.handleWebviewAskResponse).toHaveBeenCalledWith(
3097-
"messageResponse",
3098-
"Edited message with file attachment",
3099-
undefined,
3100-
)
3098+
expect(mockCline.submitUserMessage).toHaveBeenCalledWith("Edited message with file attachment", undefined)
31013099
})
31023100
})
31033101

@@ -3601,7 +3599,7 @@ describe("ClineProvider - Comprehensive Edit/Delete Edge Cases", () => {
36013599
mockCline.apiConversationHistory = [{ ts: 1000 }, { ts: 2000 }] as any[]
36023600
mockCline.overwriteClineMessages = vi.fn()
36033601
mockCline.overwriteApiConversationHistory = vi.fn()
3604-
mockCline.handleWebviewAskResponse = vi.fn()
3602+
mockCline.submitUserMessage = vi.fn()
36053603

36063604
await provider.addClineToStack(mockCline)
36073605
;(provider as any).getTaskWithId = vi.fn().mockResolvedValue({
@@ -3630,11 +3628,7 @@ describe("ClineProvider - Comprehensive Edit/Delete Edge Cases", () => {
36303628
await messageHandler({ type: "editMessageConfirm", messageTs: 2000, text: largeEditedContent })
36313629

36323630
expect(mockCline.overwriteClineMessages).toHaveBeenCalled()
3633-
expect(mockCline.handleWebviewAskResponse).toHaveBeenCalledWith(
3634-
"messageResponse",
3635-
largeEditedContent,
3636-
undefined,
3637-
)
3631+
expect(mockCline.submitUserMessage).toHaveBeenCalledWith(largeEditedContent, undefined)
36383632
})
36393633

36403634
test("handles deleting messages with large payloads", async () => {
@@ -3814,7 +3808,7 @@ describe("ClineProvider - Comprehensive Edit/Delete Edge Cases", () => {
38143808
] as any[]
38153809
mockCline.overwriteClineMessages = vi.fn()
38163810
mockCline.overwriteApiConversationHistory = vi.fn()
3817-
mockCline.handleWebviewAskResponse = vi.fn()
3811+
mockCline.submitUserMessage = vi.fn()
38183812

38193813
await provider.addClineToStack(mockCline)
38203814
;(provider as any).getTaskWithId = vi.fn().mockResolvedValue({
@@ -3847,7 +3841,7 @@ describe("ClineProvider - Comprehensive Edit/Delete Edge Cases", () => {
38473841

38483842
// Should handle future timestamps correctly
38493843
expect(mockCline.overwriteClineMessages).toHaveBeenCalled()
3850-
expect(mockCline.handleWebviewAskResponse).toHaveBeenCalled()
3844+
expect(mockCline.submitUserMessage).toHaveBeenCalled()
38513845
})
38523846
})
38533847
})

0 commit comments

Comments
 (0)