fix: remove Max Tokens slider from ThinkingBudget component

- Removed the redundant Max Tokens slider from ThinkingBudget component
- Keep only the Max Thinking Tokens slider for reasoning models
- Users now use the Max Output Tokens field in Advanced Settings for all models
- Updated tests to reflect the removal of the second slider
- Removed unused 'maxTokens' translation from all language files
- This resolves the conflict between the two controls for reasoning models

Author: MuriloFP

webview-ui/src/components/settings/ThinkingBudget.tsx

@@ -59,38 +59,19 @@ export const ThinkingBudget = ({ apiConfiguration, setApiConfigurationField, mod
 				</div>
 			)}
 			{(isReasoningBudgetRequired || enableReasoningEffort) && (
-				<>
-					<div className="flex flex-col gap-1">
-						<div className="font-medium">{t("settings:thinkingBudget.maxTokens")}</div>
-						<div className="flex items-center gap-1">
-							<Slider
-								min={8192}
-								max={Math.max(
-									modelInfo.maxTokens || 8192,
-									customMaxOutputTokens,
-									DEFAULT_HYBRID_REASONING_MODEL_MAX_TOKENS,
-								)}
-								step={1024}
-								value={[customMaxOutputTokens]}
-								onValueChange={([value]) => setApiConfigurationField("modelMaxTokens", value)}
-							/>
-							<div className="w-12 text-sm text-center">{customMaxOutputTokens}</div>
-						</div>
-					</div>
-					<div className="flex flex-col gap-1">
-						<div className="font-medium">{t("settings:thinkingBudget.maxThinkingTokens")}</div>
-						<div className="flex items-center gap-1" data-testid="reasoning-budget">
-							<Slider
-								min={1024}
-								max={modelMaxThinkingTokens}
-								step={1024}
-								value={[customMaxThinkingTokens]}
-								onValueChange={([value]) => setApiConfigurationField("modelMaxThinkingTokens", value)}
-							/>
-							<div className="w-12 text-sm text-center">{customMaxThinkingTokens}</div>
-						</div>
+				<div className="flex flex-col gap-1">
+					<div className="font-medium">{t("settings:thinkingBudget.maxThinkingTokens")}</div>
+					<div className="flex items-center gap-1" data-testid="reasoning-budget">
+						<Slider
+							min={1024}
+							max={modelMaxThinkingTokens}
+							step={1024}
+							value={[customMaxThinkingTokens]}
+							onValueChange={([value]) => setApiConfigurationField("modelMaxThinkingTokens", value)}
+						/>
+						<div className="w-12 text-sm text-center">{customMaxThinkingTokens}</div>
 					</div>
-				</>
+				</div>
 			)}
 		</>
 	) : isReasoningEffortSupported ? (

webview-ui/src/components/settings/__tests__/ThinkingBudget.spec.tsx

@@ -57,10 +57,10 @@ describe("ThinkingBudget", () => {
 		expect(container.firstChild).toBeNull()
 	})
 
-	it("should render sliders when model supports thinking", () => {
+	it("should render slider when model supports thinking", () => {
 		render(<ThinkingBudget {...defaultProps} />)
 
-		expect(screen.getAllByTestId("slider")).toHaveLength(2)
+		expect(screen.getAllByTestId("slider")).toHaveLength(1)
 	})
 
 	it("should update modelMaxThinkingTokens", () => {
@@ -74,8 +74,8 @@ describe("ThinkingBudget", () => {
 			/>,
 		)
 
-		const sliders = screen.getAllByTestId("slider")
-		fireEvent.change(sliders[1], { target: { value: "5000" } })
+		const slider = screen.getByTestId("slider")
+		fireEvent.change(slider, { target: { value: "5000" } })
 
 		expect(setApiConfigurationField).toHaveBeenCalledWith("modelMaxThinkingTokens", 5000)
 	})
@@ -99,31 +99,14 @@ describe("ThinkingBudget", () => {
 		render(<ThinkingBudget {...defaultProps} apiConfiguration={{ modelMaxTokens: 10000 }} />)
 
 		// Default is 80% of max tokens, capped at 8192
-		const sliders = screen.getAllByTestId("slider")
-		expect(sliders[1]).toHaveValue("8000") // 80% of 10000
+		const slider = screen.getByTestId("slider")
+		expect(slider).toHaveValue("8000") // 80% of 10000
 	})
 
 	it("should use min thinking tokens of 1024", () => {
 		render(<ThinkingBudget {...defaultProps} apiConfiguration={{ modelMaxTokens: 1000 }} />)
 
-		const sliders = screen.getAllByTestId("slider")
-		expect(sliders[1].getAttribute("min")).toBe("1024")
-	})
-
-	it("should update max tokens when slider changes", () => {
-		const setApiConfigurationField = vi.fn()
-
-		render(
-			<ThinkingBudget
-				{...defaultProps}
-				apiConfiguration={{ modelMaxTokens: 10000 }}
-				setApiConfigurationField={setApiConfigurationField}
-			/>,
-		)
-
-		const sliders = screen.getAllByTestId("slider")
-		fireEvent.change(sliders[0], { target: { value: "12000" } })
-
-		expect(setApiConfigurationField).toHaveBeenCalledWith("modelMaxTokens", 12000)
+		const slider = screen.getByTestId("slider")
+		expect(slider.getAttribute("min")).toBe("1024")
 	})
 })

webview-ui/src/i18n/locales/ca/settings.json

@@ -663,7 +663,6 @@
 		}
 	},
 	"thinkingBudget": {
-		"maxTokens": "Tokens màxims",
 		"maxThinkingTokens": "Tokens de pensament màxims"
 	},
 	"validation": {

webview-ui/src/i18n/locales/de/settings.json

@@ -663,7 +663,6 @@
 		}
 	},
 	"thinkingBudget": {
-		"maxTokens": "Max Tokens",
 		"maxThinkingTokens": "Max Thinking Tokens"
 	},
 	"validation": {

webview-ui/src/i18n/locales/en/settings.json

@@ -663,7 +663,6 @@
 		}
 	},
 	"thinkingBudget": {
-		"maxTokens": "Max Tokens",
 		"maxThinkingTokens": "Max Thinking Tokens"
 	},
 	"validation": {

webview-ui/src/i18n/locales/es/settings.json

@@ -663,7 +663,6 @@
 		}
 	},
 	"thinkingBudget": {
-		"maxTokens": "Tokens máximos",
 		"maxThinkingTokens": "Tokens máximos de pensamiento"
 	},
 	"validation": {

webview-ui/src/i18n/locales/fr/settings.json

@@ -663,7 +663,6 @@
 		}
 	},
 	"thinkingBudget": {
-		"maxTokens": "Tokens maximum",
 		"maxThinkingTokens": "Tokens de réflexion maximum"
 	},
 	"validation": {

webview-ui/src/i18n/locales/hi/settings.json

@@ -663,7 +663,6 @@
 		}
 	},
 	"thinkingBudget": {
-		"maxTokens": "अधिकतम tokens",
 		"maxThinkingTokens": "अधिकतम thinking tokens"
 	},
 	"validation": {

webview-ui/src/i18n/locales/id/settings.json

@@ -692,7 +692,6 @@
 		}
 	},
 	"thinkingBudget": {
-		"maxTokens": "Token Maksimum",
 		"maxThinkingTokens": "Token Thinking Maksimum"
 	},
 	"validation": {

webview-ui/src/i18n/locales/it/settings.json

@@ -663,7 +663,6 @@
 		}
 	},
 	"thinkingBudget": {
-		"maxTokens": "Token massimi",
 		"maxThinkingTokens": "Token massimi di pensiero"
 	},
 	"validation": {