fix: address PR review comments for marketplace mode removal

- Fix inconsistent quotation marks in Chinese translations (zh-CN)
- Add user notifications when rules folder deletion fails
- Remove duplicate rules folder deletion logic from SimpleInstaller
- Add proper error handling for null marketplaceManager
- Internationalize all warning messages for rules cleanup failures

Author: daniel-lxs

src/core/config/CustomModesManager.ts

@@ -502,7 +502,7 @@ export class CustomModesManager {
 		await this.onUpdate()
 	}
 
-	public async deleteCustomMode(slug: string): Promise<void> {
+	public async deleteCustomMode(slug: string, fromMarketplace = false): Promise<void> {
 		try {
 			const settingsPath = await this.getCustomModesFilePath()
 			const roomodesPath = await this.getWorkspaceRoomodes()
@@ -534,7 +534,7 @@ export class CustomModesManager {
 
 				// Delete associated rules folder
 				if (modeToDelete) {
-					await this.deleteRulesFolder(slug, modeToDelete)
+					await this.deleteRulesFolder(slug, modeToDelete, fromMarketplace)
 				}
 
 				// Clear cache when modes are deleted
@@ -552,7 +552,7 @@ export class CustomModesManager {
 	 * @param slug - The mode slug
 	 * @param mode - The mode configuration to determine the scope
 	 */
-	private async deleteRulesFolder(slug: string, mode: ModeConfig): Promise<void> {
+	private async deleteRulesFolder(slug: string, mode: ModeConfig, fromMarketplace = false): Promise<void> {
 		try {
 			// Determine the scope based on source (project or global)
 			const scope = mode.source || "global"
@@ -580,6 +580,11 @@ export class CustomModesManager {
 					logger.info(`Deleted rules folder for mode ${slug}: ${rulesFolderPath}`)
 				} catch (error) {
 					logger.error(`Failed to delete rules folder for mode ${slug}: ${error}`)
+					// Notify the user about the failure
+					const messageKey = fromMarketplace
+						? "common:marketplace.mode.rulesCleanupFailed"
+						: "common:customModes.errors.rulesCleanupFailed"
+					vscode.window.showWarningMessage(t(messageKey, { rulesFolderPath }))
 					// Continue even if folder deletion fails
 				}
 			}

src/core/webview/webviewMessageHandler.ts

@@ -2252,6 +2252,23 @@ export const webviewMessageHandler = async (
 						slug: message.mpItem.id,
 					})
 				}
+			} else {
+				// MarketplaceManager not available or missing required parameters
+				const errorMessage = !marketplaceManager
+					? "Marketplace manager is not available"
+					: "Missing required parameters for marketplace item removal"
+				console.error(errorMessage)
+
+				vscode.window.showErrorMessage(errorMessage)
+
+				if (message.mpItem?.id) {
+					provider.postMessageToWebview({
+						type: "marketplaceRemoveResult",
+						success: false,
+						error: errorMessage,
+						slug: message.mpItem.id,
+					})
+				}
 			}
 			break
 		}

src/i18n/locales/ca/common.json

@@ -136,13 +136,19 @@
 			"deleteFailed": "Failed to delete custom mode: {{error}}",
 			"resetFailed": "Failed to reset custom modes: {{error}}",
 			"modeNotFound": "Write error: Mode not found",
-			"noWorkspaceForProject": "No workspace folder found for project-specific mode"
+			"noWorkspaceForProject": "No workspace folder found for project-specific mode",
+			"rulesCleanupFailed": "Mode deleted successfully, but failed to delete rules folder at {{rulesFolderPath}}. You may need to delete it manually."
 		},
 		"scope": {
 			"project": "project",
 			"global": "global"
 		}
 	},
+	"marketplace": {
+		"mode": {
+			"rulesCleanupFailed": "Mode removed successfully, but failed to delete rules folder at {{rulesFolderPath}}. You may need to delete it manually."
+		}
+	},
 	"mdm": {
 		"errors": {
 			"cloud_auth_required": "Your organization requires Roo Code Cloud authentication. Please sign in to continue.",