Emit event when a task ask requires interaction

Author: cte

packages/types/src/events.ts

@@ -1,6 +1,6 @@
 import { z } from "zod"
 
-import { clineMessageSchema, tokenUsageSchema } from "./message.js"
+import { clineMessageSchema, tokenUsageSchema, clineAskSchema } from "./message.js"
 import { toolNamesSchema, toolUsageSchema } from "./tool.js"
 
 /**
@@ -29,6 +29,7 @@ export enum RooCodeEventName {
 	Message = "message",
 	TaskModeSwitched = "taskModeSwitched",
 	TaskAskResponded = "taskAskResponded",
+	TaskAskRequiresInteraction = "taskAskRequiresInteraction",
 
 	// Task Analytics
 	TaskTokenUsageUpdated = "taskTokenUsageUpdated",
@@ -74,6 +75,7 @@ export const rooCodeEventsSchema = z.object({
 	]),
 	[RooCodeEventName.TaskModeSwitched]: z.tuple([z.string(), z.string()]),
 	[RooCodeEventName.TaskAskResponded]: z.tuple([z.string()]),
+	[RooCodeEventName.TaskAskRequiresInteraction]: z.tuple([z.string(), clineAskSchema, z.string()]),
 
 	[RooCodeEventName.TaskToolFailed]: z.tuple([z.string(), toolNamesSchema, z.string()]),
 	[RooCodeEventName.TaskTokenUsageUpdated]: z.tuple([z.string(), tokenUsageSchema]),
@@ -163,6 +165,11 @@ export const taskEventSchema = z.discriminatedUnion("eventName", [
 		payload: rooCodeEventsSchema.shape[RooCodeEventName.TaskAskResponded],
 		taskId: z.number().optional(),
 	}),
+	z.object({
+		eventName: z.literal(RooCodeEventName.TaskAskRequiresInteraction),
+		payload: rooCodeEventsSchema.shape[RooCodeEventName.TaskAskRequiresInteraction],
+		taskId: z.number().optional(),
+	}),
 
 	// Task Analytics
 	z.object({

packages/types/src/task.ts

@@ -1,7 +1,7 @@
 import { z } from "zod"
 
 import { RooCodeEventName } from "./events.js"
-import { type ClineMessage, type BlockingAsk, type TokenUsage } from "./message.js"
+import { type ClineMessage, type BlockingAsk, type TokenUsage, type ClineAsk } from "./message.js"
 import { type ToolUsage, type ToolName } from "./tool.js"
 import type { StaticAppProperties, GitProperties, TelemetryProperties } from "./telemetry.js"
 
@@ -100,6 +100,7 @@ export type TaskEvents = {
 	[RooCodeEventName.Message]: [{ action: "created" | "updated"; message: ClineMessage }]
 	[RooCodeEventName.TaskModeSwitched]: [taskId: string, mode: string]
 	[RooCodeEventName.TaskAskResponded]: []
+	[RooCodeEventName.TaskAskRequiresInteraction]: [taskId: string, askType: ClineAsk, reason: string]
 
 	// Task Analytics
 	[RooCodeEventName.TaskToolFailed]: [taskId: string, tool: ToolName, error: string]

src/core/webview/webviewMessageHandler.ts

@@ -8,10 +8,11 @@ import * as yaml from "yaml"
 
 import {
 	type Language,
-	type ProviderSettings,
 	type GlobalState,
 	type ClineMessage,
+	type ClineAsk,
 	TelemetryEventName,
+	RooCodeEventName,
 } from "@roo-code/types"
 import { CloudService } from "@roo-code/cloud"
 import { TelemetryService } from "@roo-code/telemetry"
@@ -347,6 +348,19 @@ export const webviewMessageHandler = async (
 			break
 		case "askResponse":
 			provider.getCurrentTask()?.handleWebviewAskResponse(message.askResponse!, message.text, message.images)
+			break
+		case "askRequiresInteraction":
+			if (message.askType && message.reason) {
+				const task = provider.getCurrentTask()
+
+				task?.emit(
+					RooCodeEventName.TaskAskRequiresInteraction,
+					task.taskId,
+					message.askType as ClineAsk,
+					message.reason,
+				)
+			}
+
 			break
 		case "autoCondenseContext":
 			await updateGlobalState("autoCondenseContext", message.bool)

src/shared/WebviewMessage.ts

@@ -49,6 +49,7 @@ export interface WebviewMessage {
 		| "webviewDidLaunch"
 		| "newTask"
 		| "askResponse"
+		| "askRequiresInteraction"
 		| "terminalOperation"
 		| "clearTask"
 		| "didShowAnnouncement"
@@ -218,6 +219,8 @@ export interface WebviewMessage {
 	context?: string
 	dataUri?: string
 	askResponse?: ClineAskResponse
+	askType?: string
+	reason?: string
 	apiConfiguration?: ProviderSettings
 	images?: string[]
 	bool?: boolean

webview-ui/src/components/chat/ChatView.tsx

@@ -77,13 +77,16 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 	ref,
 ) => {
 	const isMountedRef = useRef(true)
+
 	const [audioBaseUri] = useState(() => {
 		const w = window as any
 		return w.AUDIO_BASE_URI || ""
 	})
+
 	const { t } = useAppTranslation()
 	const { t: tSettings } = useTranslation("settings")
 	const modeShortcutText = `${isMac ? "⌘" : "Ctrl"} + . ${t("chat:forNextMode")}, ${isMac ? "⌘" : "Ctrl"} + Shift + . ${t("chat:forPreviousMode")}`
+
 	const {
 		clineMessages: messages,
 		currentTaskItem,
@@ -1612,12 +1615,13 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 				return
 			}
 
-			// Then check for auto-approve
+			// Then check for auto-approve.
 			if (lastMessage?.ask && isAutoApproved(lastMessage)) {
-				// Special handling for follow-up questions
+				// Special handling for follow-up questions.
 				if (lastMessage.ask === "followup") {
-					// Handle invalid JSON
+					// Handle invalid JSON.
 					let followUpData: FollowUpData = {}
+
 					try {
 						followUpData = JSON.parse(lastMessage.text || "{}") as FollowUpData
 					} catch (error) {
@@ -1626,27 +1630,30 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 					}
 
 					if (followUpData && followUpData.suggest && followUpData.suggest.length > 0) {
-						// Wait for the configured timeout before auto-selecting the first suggestion
+						// Wait for the configured timeout before auto-selecting the first suggestion.
 						await new Promise<void>((resolve) => {
 							autoApproveTimeoutRef.current = setTimeout(() => {
 								autoApproveTimeoutRef.current = null
 								resolve()
 							}, followupAutoApproveTimeoutMs)
 						})
 
-						// Check if user responded manually
+						// Check if user responded manually.
 						if (userRespondedRef.current) {
 							return
 						}
 
-						// Get the first suggestion
+						// Get the first suggestion.
 						const firstSuggestion = followUpData.suggest[0]
 
-						// Handle the suggestion click
+						// Handle the suggestion click.
 						handleSuggestionClickInRow(firstSuggestion)
 						return
 					}
 				} else if (lastMessage.ask === "tool" && isWriteToolAction(lastMessage)) {
+					// When auto-approval is enabled for write operations, there
+					// is a configurable delay (writeDelayMs) before automatically
+					// approving these changes.
 					await new Promise<void>((resolve) => {
 						autoApproveTimeoutRef.current = setTimeout(() => {
 							autoApproveTimeoutRef.current = null
@@ -1660,8 +1667,43 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 				setSendingDisabled(true)
 				setClineAsk(undefined)
 				setEnableButtons(false)
+			} else if (lastMessage?.ask) {
+				// Ask requires user interaction - not auto-approved or auto-rejected.
+				const reason = (() => {
+					if (autoApprovalEnabled !== true) {
+						return "auto_approval_disabled"
+					}
+
+					// Determine more specific reasons based on the ask type.
+					switch (lastMessage.ask) {
+						case "command":
+							return "command_requires_manual_approval"
+						case "tool":
+							return "tool_requires_manual_approval"
+						case "browser_action_launch":
+							return "browser_action_requires_manual_approval"
+						case "use_mcp_server":
+							return "mcp_requires_manual_approval"
+						case "followup":
+							return "followup_requires_manual_response"
+						case "completion_result":
+							return "completion_requires_manual_confirmation"
+						case "api_req_failed":
+							return "api_failure_requires_manual_decision"
+						case "mistake_limit_reached":
+							return "mistake_limit_requires_manual_guidance"
+						case "auto_approval_max_req_reached":
+							return "approval_limit_reached"
+						default:
+							return "manual_approval_required"
+					}
+				})()
+
+				// Notify the extension host that this ask requires user interaction.
+				vscode.postMessage({ type: "askRequiresInteraction", askType: lastMessage.ask, reason: reason })
 			}
 		}
+
 		autoApproveOrReject()
 
 		return () => {
@@ -1686,6 +1728,7 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 		allowedCommands,
 		deniedCommands,
 		mcpServers,
+		autoApprovalEnabled,
 		isAutoApproved,
 		lastMessage,
 		writeDelayMs,