Merge pull request #46 from sakamotopaya/eo/get-cli-working

get cli working

Author: ericroliver

docs/product-stories/cli-utility/cli-refinement.md

@@ -1,19 +1,140 @@
-we are ready to work on issue #18 (docs/product-stories/cli-utility/story-18-update-documentation.md) in repo https://github.com/sakamotopaya/code-agent.
+we are ready to work on issue #20 (docs/product-stories/cli-utility/story-20-performance-optimization.md) in repo https://github.com/sakamotopaya/code-agent.
 follow the normal git flow. create a new local branch for the story.
 code the tasks and unit tests that prove the task are complete.
 if you need information about prior stories, you can find them locally here docs/product-stories/cli-utility
-we often get rejected trying to push our changes. make sure and run a build and lint prior to trying to push
+we often get rejected trying to push our changes. make sure and run a build and lint prior to trying to push. you will not be able to push the local branch if there are any lint warnings
 when you are finished with the code and tests, update the issue with a new comment describing your work and then
 push your branch and create a pull request for this branch against main
 you should use regular git command but it might be best to create the PR using the mcp server
 
-We need to resume work on issue #17 (docs/product-stories/cli-utility/story-17-comprehensive-cli-testing.md) in repo https://github.com/sakamotopaya/code-agent.
+We need to resume work on issue #18 (docs/product-stories/cli-utility/story-18-update-documentation.md) in repo https://github.com/sakamotopaya/code-agent.
 
-you were creating a pr when you filled up context. here is where you were on the pr creation:
-{
-"owner": "sakamotopaya",
-"repo": "code-agent",
-"title": "feat: Comprehensive CLI Testing Framework (Story 17)",
-"body": "## Summary\n\nImplements Story 17: Comprehensive CLI Testing with a complete testing framework for the CLI utility.\n\n## Changes Made\n\n### Testing Infrastructure\n- **Jest Configuration**: CLI-specific Jest config with 90% coverage threshold\n- **Test Utilities**: `TestHelpers` class with workspace management, CLI command execution, and performance measurement\n- **Mock Services**: Comprehensive mocking for UI, browser, session, and MCP services\n- **Test Setup**: Global test configuration with automatic cleanup\n\n### Test Categories Implemented\n\n#### Unit Tests (29 tests)\n- Console output handling\n- Basic functionality validation\n- Error handling and recovery\n- Async operations\n- Data types and validation\n- Environment and platform detection\n- Performance and memory operations\n- JSON and data processing\n- Edge cases and error conditions\n- Concurrency and timing\n\n#### Integration Tests\n- File operations (create, read, write, delete)\n- Directory operations and traversal\n- Project structure management\n- Configuration management\n- Output formatting validation (JSON, YAML, table, plain text)\n- Session management\n- Performance characteristics\n- Cross-platform compatibility\n- Concurrent operations\n- Resource cleanup\n\n#### End-to-End Tests\n- New user onboarding workflows\n- Complete development workflows\n- Project creation (simple, React, Node.js)\n- File management operations\n- Data processing workflows\n- Session lifecycle management\n- Error recovery scenarios\n- Configuration workflows\n\n#### Performance Tests\n- Startup time benchmarking (< 2 seconds)\n- Memory usage profiling (< 100MB increase)\n- Large file processing (< 5 seconds for 10MB)\n- Concurrent operation testing\n- Resource cleanup validation\n- Memory pressure testing\n\n#### Cross-Platform Tests\n- Platform detection (Windows, macOS, Linux)\n- File path handling\n- Environment variable management\n- Process operations\n- File system permissions\n- Text encoding and line endings\n- Node.js version compatibility\n\n### Test Scripts Added\n`bash\nnpm run test:cli              # All CLI tests\nnpm run test:cli:unit         # Unit tests only\nnpm run test:cli:integration  # Integration tests only\nnpm run test:cli:e2e          # End-to-end tests only\nnpm run test:cli:performance  # Performance tests only\nnpm run test:cli:platform     # Cross-platform tests only\nnpm run test:cli:coverage     # With coverage report\nnpm run test:cli:watch        # Watch mode for development\n`\n\n### Coverage Requirements\n- **Branches**: 90%\n- **Functions**: 90%\n- **Lines**: 90%\n- **Statements**: 90%\n\n## Test Results\n- ✅ All unit tests passing (29/29)\n- ✅ Lint passing with zero warnings\n- ✅ TypeScript compilation successful\n- ✅ Test infrastructure functional\n\n## Quality Assurance\n- All code follows ESLint rules\n- TypeScript strict mode compliance\n- Comprehensive error handling\n- Resource cleanup in all tests\n- Platform-agnostic test design\n- Performance benchmarks established\n\n## Files Added\n- `src/cli/jest.config.mjs` - Jest configuration for CLI testing\n- `src/cli/__tests__/setup.ts` - Global test setup and teardown\n- `src/cli/__tests__/utils/TestHelpers.ts` - Core test utilities\n- `src/cli/__tests__/utils/MockServices.ts` - Mock service implementations\n- `src/cli/__tests__/unit/services/CLIUIService.test.ts` - Unit tests\n- `src/cli/**tests**/integration/CLIIntegration.test.
+you were creating unit tests when you ran out of context. specifically you were editing src/cli/**tests**/unit/commands/HelpCommand.test.ts when you ran out of context
 
-finish the PR and then add your comment to the issue. be sure and mark the issue as closes.
+getting this error trying to run the client. any code that uses vscode as a dependency needs to be put behind an interface so that we can provide an implementation for the CLI
+[copyLocales] Copied 34 locale files to /Users/eo/code/code-agent/src/dist/i18n/locales
+[esbuild-problem-matcher#onEnd]
+eo@m3x src % node dist/cli/index.js --help
+node:internal/modules/cjs/loader:1228
+throw err;
+^
+
+Error: Cannot find module 'vscode'
+Require stack:
+
+- /Users/eo/code/code-agent/src/dist/cli/index.js
+  at Module.\_resolveFilename (node:internal/modules/cjs/loader:1225:15)
+  at Module.\_load (node:internal/modules/cjs/loader:1051:27)
+  at Module.require (node:internal/modules/cjs/loader:1311:19)
+  at require (node:internal/modules/helpers:179:18)
+  at utils/storage.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:190467:22)
+  at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+  at api/providers/fetchers/modelCache.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:198348:5)
+  at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+  at api/providers/router-provider.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:198409:5)
+  at \_\_init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56) {
+  code: 'MODULE_NOT_FOUND',
+  requireStack: [ '/Users/eo/code/code-agent/src/dist/cli/index.js' ]
+  }
+
+Node.js v20.18.3
+eo@m3x src % npm run build:cli
+
+> [email protected] build:cli
+> node esbuild.mjs
+
+[extension] Cleaning dist directory: /Users/eo/code/code-agent/src/dist
+[esbuild-problem-matcher#onStart]
+[copyPaths] Copied ../README.md to README.md
+[copyPaths] Copied ../CHANGELOG.md to CHANGELOG.md
+[copyPaths] Copied ../LICENSE to LICENSE
+[copyPaths] Optional file not found: ../.env
+[copyPaths] Copied 911 files from node_modules/vscode-material-icons/generated to assets/vscode-material-icons
+[copyPaths] Copied 3 files from ../webview-ui/audio to webview-ui/audio
+[copyWasms] Copied tiktoken WASMs to /Users/eo/code/code-agent/src/dist
+[copyWasms] Copied tiktoken WASMs to /Users/eo/code/code-agent/src/dist/workers
+[copyWasms] Copied tree-sitter.wasm to /Users/eo/code/code-agent/src/dist
+[copyWasms] Copied 35 tree-sitter language wasms to /Users/eo/code/code-agent/src/dist
+[copyLocales] Copied 34 locale files to /Users/eo/code/code-agent/src/dist/i18n/locales
+[esbuild-problem-matcher#onEnd]
+eo@m3x src % node dist/cli/index.js --help
+Error processing directory /Users/eo/code/code-agent/src/dist/cli/i18n/locales: Error: ENOENT: no such file or directory, scandir '/Users/eo/code/code-agent/src/dist/cli/i18n/locales'
+at Object.readdirSync (node:fs:1507:26)
+at i18n/setup.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:190373:37)
+at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+at i18n/index.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:190420:5)
+at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+at utils/storage.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:190474:5)
+at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+at api/providers/fetchers/modelCache.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:198351:5)
+at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+at api/providers/router-provider.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:198412:5) {
+errno: -2,
+code: 'ENOENT',
+syscall: 'scandir',
+path: '/Users/eo/code/code-agent/src/dist/cli/i18n/locales'
+}
+node:internal/modules/cjs/loader:1228
+throw err;
+^
+
+Error: Cannot find module 'vscode'
+Require stack:
+
+- /Users/eo/code/code-agent/src/dist/cli/index.js
+  at Module.\_resolveFilename (node:internal/modules/cjs/loader:1225:15)
+  at Module.\_load (node:internal/modules/cjs/loader:1051:27)
+  at Module.require (node:internal/modules/cjs/loader:1311:19)
+  at require (node:internal/modules/helpers:179:18)
+  at api/providers/human-relay.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:198620:23)
+  at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+  at api/providers/index.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:224236:5)
+  at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+  at api/index.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:224309:5)
+  at \_\_init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56) {
+  code: 'MODULE_NOT_FOUND',
+  requireStack: [ '/Users/eo/code/code-agent/src/dist/cli/index.js' ]
+  }
+
+Node.js v20.18.3
+eo@m3x src % node dist/cli/index.js --help
+Error processing directory /Users/eo/code/code-agent/src/dist/cli/i18n/locales: Error: ENOENT: no such file or directory, scandir '/Users/eo/code/code-agent/src/dist/cli/i18n/locales'
+at Object.readdirSync (node:fs:1507:26)
+at i18n/setup.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:190373:37)
+at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+at i18n/index.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:190420:5)
+at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+at utils/storage.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:190474:5)
+at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+at api/providers/fetchers/modelCache.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:198351:5)
+at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+at api/providers/router-provider.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:198412:5) {
+errno: -2,
+code: 'ENOENT',
+syscall: 'scandir',
+path: '/Users/eo/code/code-agent/src/dist/cli/i18n/locales'
+}
+node:internal/modules/cjs/loader:1228
+throw err;
+^
+
+Error: Cannot find module 'vscode'
+Require stack:
+
+- /Users/eo/code/code-agent/src/dist/cli/index.js
+  at Module.\_resolveFilename (node:internal/modules/cjs/loader:1225:15)
+  at Module.\_load (node:internal/modules/cjs/loader:1051:27)
+  at Module.require (node:internal/modules/cjs/loader:1311:19)
+  at require (node:internal/modules/helpers:179:18)
+  at api/providers/human-relay.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:198620:23)
+  at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+  at api/providers/index.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:224236:5)
+  at **init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56)
+  at api/index.ts (/Users/eo/code/code-agent/src/dist/cli/index.js:224309:5)
+  at \_\_init (/Users/eo/code/code-agent/src/dist/cli/index.js:15:56) {
+  code: 'MODULE_NOT_FOUND',
+  requireStack: [ '/Users/eo/code/code-agent/src/dist/cli/index.js' ]
+  }
+
+Node.js v20.18.3
+eo@m3x src %

docs/product-stories/cli-utility/dev-prompt.md

@@ -0,0 +1,5 @@
+// CLI-specific telemetry exports that don't include VSCode dependencies
+export * from "./BaseTelemetryClient"
+export * from "./TelemetryService"
+
+// Note: PostHogTelemetryClient is NOT exported here since it depends on vscode

packages/telemetry/src/cli.ts

@@ -3,7 +3,6 @@ import fs from "fs/promises"
 
 import NodeCache from "node-cache"
 
-import { ContextProxy } from "../../../core/config/ContextProxy"
 import { getCacheDirectoryPath } from "../../../utils/storage"
 import { RouterName, ModelRecord } from "../../../shared/api"
 import { fileExistsAtPath } from "../../../utils/fs"
@@ -18,13 +17,37 @@ const memoryCache = new NodeCache({ stdTTL: 5 * 60, checkperiod: 5 * 60 })
 
 async function writeModels(router: RouterName, data: ModelRecord) {
 	const filename = `${router}_models.json`
-	const cacheDir = await getCacheDirectoryPath(ContextProxy.instance.globalStorageUri.fsPath)
+	let globalStoragePath: string
+
+	try {
+		// Try to use VSCode context if available
+		const { ContextProxy } = require("../../../core/config/ContextProxy")
+		globalStoragePath = ContextProxy.instance.globalStorageUri.fsPath
+	} catch (error) {
+		// Fallback for CLI usage
+		const os = require("os")
+		globalStoragePath = path.join(os.homedir(), ".roo-code")
+	}
+
+	const cacheDir = await getCacheDirectoryPath(globalStoragePath)
 	await fs.writeFile(path.join(cacheDir, filename), JSON.stringify(data))
 }
 
 async function readModels(router: RouterName): Promise<ModelRecord | undefined> {
 	const filename = `${router}_models.json`
-	const cacheDir = await getCacheDirectoryPath(ContextProxy.instance.globalStorageUri.fsPath)
+	let globalStoragePath: string
+
+	try {
+		// Try to use VSCode context if available
+		const { ContextProxy } = require("../../../core/config/ContextProxy")
+		globalStoragePath = ContextProxy.instance.globalStorageUri.fsPath
+	} catch (error) {
+		// Fallback for CLI usage
+		const os = require("os")
+		globalStoragePath = path.join(os.homedir(), ".roo-code")
+	}
+
+	const cacheDir = await getCacheDirectoryPath(globalStoragePath)
 	const filePath = path.join(cacheDir, filename)
 	const exists = await fileExistsAtPath(filePath)
 	return exists ? JSON.parse(await fs.readFile(filePath, "utf8")) : undefined

src/api/providers/fetchers/modelCache.ts

@@ -17,13 +17,35 @@ const getCacheKey = (router: RouterName, modelId: string) => sanitize(`${router}
 
 async function writeModelEndpoints(key: string, data: ModelRecord) {
 	const filename = `${key}_endpoints.json`
-	const cacheDir = await getCacheDirectoryPath(ContextProxy.instance.globalStorageUri.fsPath)
+	let globalStoragePath: string
+
+	try {
+		// Try to use VSCode context if available
+		globalStoragePath = ContextProxy.instance.globalStorageUri.fsPath
+	} catch (error) {
+		// Fallback for CLI usage
+		const os = require("os")
+		globalStoragePath = path.join(os.homedir(), ".roo-code")
+	}
+
+	const cacheDir = await getCacheDirectoryPath(globalStoragePath)
 	await fs.writeFile(path.join(cacheDir, filename), JSON.stringify(data, null, 2))
 }
 
 async function readModelEndpoints(key: string): Promise<ModelRecord | undefined> {
 	const filename = `${key}_endpoints.json`
-	const cacheDir = await getCacheDirectoryPath(ContextProxy.instance.globalStorageUri.fsPath)
+	let globalStoragePath: string
+
+	try {
+		// Try to use VSCode context if available
+		globalStoragePath = ContextProxy.instance.globalStorageUri.fsPath
+	} catch (error) {
+		// Fallback for CLI usage
+		const os = require("os")
+		globalStoragePath = path.join(os.homedir(), ".roo-code")
+	}
+
+	const cacheDir = await getCacheDirectoryPath(globalStoragePath)
 	const filePath = path.join(cacheDir, filename)
 	const exists = await fileExistsAtPath(filePath)
 	return exists ? JSON.parse(await fs.readFile(filePath, "utf8")) : undefined

src/api/providers/fetchers/modelEndpointCache.ts

@@ -1,10 +1,10 @@
 import { Anthropic } from "@anthropic-ai/sdk"
-import * as vscode from "vscode"
 
 import type { ModelInfo } from "@roo-code/types"
 
 import { getCommand } from "../../utils/commands"
 import { ApiStream } from "../transform/stream"
+import { getPlatformServices, isVsCodeContext } from "../../core/adapters/PlatformServiceFactory"
 
 import type { ApiHandler, SingleCompletionHandler, ApiHandlerCreateMessageMetadata } from "../index"
 
@@ -44,7 +44,8 @@ export class HumanRelayHandler implements ApiHandler, SingleCompletionHandler {
 		}
 
 		// Copy to clipboard
-		await vscode.env.clipboard.writeText(promptText)
+		const platformServices = await getPlatformServices()
+		await platformServices.clipboard.writeText(promptText)
 
 		// A dialog box pops up to request user action
 		const response = await showHumanRelayDialog(promptText)
@@ -84,7 +85,8 @@ export class HumanRelayHandler implements ApiHandler, SingleCompletionHandler {
 	 */
 	async completePrompt(prompt: string): Promise<string> {
 		// Copy to clipboard
-		await vscode.env.clipboard.writeText(prompt)
+		const platformServices = await getPlatformServices()
+		await platformServices.clipboard.writeText(prompt)
 
 		// A dialog box pops up to request user action
 		const response = await showHumanRelayDialog(prompt)
@@ -118,18 +120,52 @@ function getMessageContent(message: Anthropic.Messages.MessageParam): string {
  * @returns The user's input response or undefined (if canceled).
  */
 async function showHumanRelayDialog(promptText: string): Promise<string | undefined> {
+	if (!isVsCodeContext()) {
+		// In CLI mode, prompt user for input
+		console.log("\n📋 Prompt copied to clipboard. Please:")
+		console.log("1. Paste the prompt into your AI model interface")
+		console.log("2. Copy the AI's response")
+		console.log("3. Enter the response below")
+		console.log("\nPrompt:")
+		console.log("---")
+		console.log(promptText)
+		console.log("---\n")
+
+		const platformServices = await getPlatformServices()
+		return await platformServices.userInterface.showInputBox({
+			prompt: "Enter the AI's response",
+			placeHolder: "Paste the response here...",
+		})
+	}
+
+	// VSCode mode - use command-based dialog
 	return new Promise<string | undefined>((resolve) => {
 		// Create a unique request ID.
 		const requestId = Date.now().toString()
 
-		// Register a global callback function.
-		vscode.commands.executeCommand(
-			getCommand("registerHumanRelayCallback"),
-			requestId,
-			(response: string | undefined) => resolve(response),
-		)
+		const setupPromise = async () => {
+			try {
+				const platformServices = await getPlatformServices()
+
+				// Register a global callback function.
+				await platformServices.commandExecutor.executeCommand(
+					getCommand("registerHumanRelayCallback"),
+					requestId,
+					(response: string | undefined) => resolve(response),
+				)
+
+				// Open the dialog box directly using the current panel.
+				await platformServices.commandExecutor.executeCommand(getCommand("showHumanRelayDialog"), {
+					requestId,
+					promptText,
+				})
+			} catch (error) {
+				console.error("Failed to show human relay dialog:", error)
+				resolve(undefined)
+			}
+		}
 
-		// Open the dialog box directly using the current panel.
-		vscode.commands.executeCommand(getCommand("showHumanRelayDialog"), { requestId, promptText })
+		// Call the async setup function
+		setupPromise()
 	})
 }

src/api/providers/human-relay.ts

@@ -18,5 +18,21 @@ export { OpenRouterHandler } from "./openrouter"
 export { RequestyHandler } from "./requesty"
 export { UnboundHandler } from "./unbound"
 export { VertexHandler } from "./vertex"
-export { VsCodeLmHandler } from "./vscode-lm"
 export { XAIHandler } from "./xai"
+
+// Conditional exports for VSCode-specific providers
+let VsCodeLmHandler: any = null
+
+try {
+	// Only export VSCode LM handler if in VSCode context
+	if (typeof require !== "undefined") {
+		// Try to require vscode to check if we're in VSCode context
+		require("vscode")
+		VsCodeLmHandler = require("./vscode-lm").VsCodeLmHandler
+	}
+} catch (error) {
+	// VSCode not available (CLI mode)
+	VsCodeLmHandler = null
+}
+
+export { VsCodeLmHandler }