fix: address review comments from roomote

daniel-lxs · daniel-lxs · commit 487188555565 · 2025-10-27T16:27:14.000-05:00
- Remove unused contextTokens variable in getEnvironmentDetails.ts
- Remove duplicate includeCurrentTime/Cost properties in ExtensionMessage.ts
- Properties are already defined in the Pick&lt;GlobalSettings&gt; type union
diff --git a/src/core/environment/getEnvironmentDetails.ts b/src/core/environment/getEnvironmentDetails.ts
@@ -207,7 +207,7 @@ export async function getEnvironmentDetails(cline: Task, includeFileDetails: boo
 
 	// Add context tokens information (if enabled).
 	if (includeCurrentCost) {
-		const { contextTokens, totalCost } = getApiMetrics(cline.clineMessages)
+		const { totalCost } = getApiMetrics(cline.clineMessages)
 		details += `\n\n# Current Cost\n${totalCost !== null ? `$${totalCost.toFixed(2)}` : "(Not available)"}`
 	}
 
diff --git a/src/shared/ExtensionMessage.ts b/src/shared/ExtensionMessage.ts
@@ -347,8 +347,6 @@ export type ExtensionState = Pick<
 	openRouterImageApiKey?: string
 	openRouterUseMiddleOutTransform?: boolean
 	messageQueue?: QueuedMessage[]
-	includeCurrentTime?: boolean
-	includeCurrentCost?: boolean
 	lastShownAnnouncementId?: string
 	apiModelId?: string
 	mcpServers?: McpServer[]

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ export async function getEnvironmentDetails(cline: Task, includeFileDetails: boo`
`207`	`207`
`208`	`208`	`// Add context tokens information (if enabled).`
`209`	`209`	`if (includeCurrentCost) {`
`210`		`- const { contextTokens, totalCost } = getApiMetrics(cline.clineMessages)`
	`210`	`+ const { totalCost } = getApiMetrics(cline.clineMessages)`
`211`	`211`	details += `\n\n# Current Cost\n${totalCost !== null ? `$${totalCost.toFixed(2)}` : "(Not available)"}`
`212`	`212`	`}`
`213`	`213`