Skip to content

Commit 48d0b19

Browse files
authored
Feat: Improve Issue Fixer Rules for Targeted Fixes (#4652)
1 parent 8718606 commit 48d0b19

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

.roo/rules-issue-fixer/1_Workflow.xml

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,9 @@
9898
For Bug Fixes:
9999
1. Reproduce the bug locally (if possible)
100100
2. Identify root cause
101-
3. Plan the fix approach
102-
4. Identify files to modify
103-
5. Plan test cases to prevent regression
101+
3. Plan the fix approach. The plan should be focused on resolving the issue with a high-quality, targeted fix, while avoiding unrelated changes.
102+
4. Identify files to modify.
103+
5. Plan test cases to prevent regression.
104104

105105
For Feature Implementation:
106106
1. Break down the feature into components
@@ -114,10 +114,12 @@
114114
<ask_followup_question>
115115
<question>I've analyzed issue #[number]: "[title]"
116116

117-
Here's my implementation plan:
117+
Here's my implementation plan to resolve the issue:
118118

119119
[Detailed plan with steps and affected files]
120120

121+
This plan focuses on providing a quality fix for the reported problem without introducing unrelated changes.
122+
121123
Would you like me to proceed with this implementation?</question>
122124
<follow_up>
123125
<suggest>Yes, proceed with the implementation</suggest>
@@ -199,11 +201,11 @@
199201
5. Ensure backward compatibility (if applicable)
200202

201203
For Bug Fixes:
202-
1. Apply the minimal fix needed
203-
2. Don't refactor unrelated code
204-
3. Add regression tests
205-
4. Verify the fix resolves the issue
206-
5. Check for side effects
204+
1. Implement the planned fix, focusing on quality and precision.
205+
2. The scope of the fix should be as narrow as possible to address the issue. Avoid making changes to code that is not directly related to the fix. This is not an encouragement for one-line hacks, but a guideline to prevent unintended side-effects.
206+
3. Add regression tests.
207+
4. Verify the fix resolves the issue.
208+
5. Check for side effects.
207209

208210
For Features:
209211
1. Implement incrementally

.roo/rules-issue-fixer/2_best_practices.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
<best_practices>
22
- Always read the entire issue and all comments before starting
33
- Follow the project's coding standards and patterns
4-
- Make minimal changes for bug fixes (don't refactor unnecessarily)
4+
- Focus exclusively on addressing the issue's requirements.
5+
- Make minimal, high-quality changes for bug fixes. The goal is a narrow, targeted fix, not a one-line hack.
56
- Test thoroughly - both automated and manual testing
67
- Document complex logic with comments
78
- Keep commits focused and well-described

0 commit comments

Comments
 (0)