fix: correct deduplication logic to prefer loaded models

- When a loaded model ID is found in any downloaded model key (case-insensitive)
- Remove the downloaded model and replace with the loaded model
- This ensures loaded models with runtime info take precedence
- Updated tests to verify the correct deduplication behavior

Author: daniel-lxs

src/api/providers/fetchers/__tests__/lmstudio.test.ts

@@ -179,12 +179,15 @@ describe("LMStudio Fetcher", () => {
 
 			const result = await getLMStudioModels(baseUrl)
 
-			// Should only have one model, with the loaded model's runtime info taking precedence
+			// Should only have one model, with the loaded model replacing the downloaded one
 			expect(Object.keys(result)).toHaveLength(1)
 
-			// The downloaded model's path should be the key, but with loaded model's data
+			// The loaded model's key should be used, with loaded model's data
 			const expectedParsedModel = parseLMStudioModel(mockLoadedModel)
-			expect(result[mockDownloadedModel.path]).toEqual(expectedParsedModel)
+			expect(result[mockLoadedModel.modelKey]).toEqual(expectedParsedModel)
+
+			// The downloaded model should have been removed
+			expect(result[mockDownloadedModel.path]).toBeUndefined()
 		})
 
 		it("should use default baseUrl if an empty string is provided", async () => {

src/api/providers/fetchers/lmstudio.ts

@@ -87,31 +87,21 @@ export async function getLMStudioModels(baseUrl = "http://localhost:1234"): Prom
 			return Promise.all(models.map((m) => m.getModelInfo()))
 		})) as Array<LLMInstanceInfo>
 
-		// Deduplicate loaded models - only add if no existing key contains the model's identifier (case-insensitive)
+		// Deduplicate: For each loaded model, check if any existing model contains its ID (case-insensitive)
+		// If found, remove the downloaded version and add the loaded model (prefer loaded over downloaded)
 		for (const lmstudioModel of loadedModels) {
-			const modelIdentifier = lmstudioModel.modelKey.toLowerCase()
+			const loadedModelId = lmstudioModel.modelKey.toLowerCase()
 
-			// Check if any existing model key contains this loaded model's identifier
-			const isDuplicate = Object.keys(models).some(
-				(existingKey) =>
-					existingKey.toLowerCase().includes(modelIdentifier) ||
-					modelIdentifier.includes(existingKey.toLowerCase()),
-			)
+			// Find if any existing model key includes the loaded model's ID
+			const existingKey = Object.keys(models).find((key) => key.toLowerCase().includes(loadedModelId))
 
-			if (!isDuplicate) {
-				// Use modelKey for loaded models to maintain consistency
-				models[lmstudioModel.modelKey] = parseLMStudioModel(lmstudioModel)
-			} else {
-				// If it's a duplicate, update the existing entry with loaded model info for better context data
-				const existingKey = Object.keys(models).find(
-					(key) => key.toLowerCase().includes(modelIdentifier) || modelIdentifier.includes(key.toLowerCase()),
-				)
-				if (existingKey) {
-					// Update with loaded model data which has more accurate runtime info
-					models[existingKey] = parseLMStudioModel(lmstudioModel)
-				}
+			if (existingKey) {
+				// Remove the downloaded version
+				delete models[existingKey]
 			}
 
+			// Add the loaded model (either as replacement or new entry)
+			models[lmstudioModel.modelKey] = parseLMStudioModel(lmstudioModel)
 			modelsWithLoadedDetails.add(lmstudioModel.modelKey)
 		}
 	} catch (error) {