fix(zai): restore typed model IDs, add GLM-4.5V tiers test, clarify intl tiers comment

Author: hannesrudolph

packages/types/src/providers/zai.ts

@@ -42,6 +42,7 @@ export const internationalZAiModels = {
 		outputPrice: 1.8,
 		cacheWritesPrice: 0,
 		cacheReadsPrice: 0.11,
+		// International pricing tiers for GLM-4.5V are not publicly documented as of 2025-10-20; mainland tiers are defined below.
 		description: "GLM-4.5V is Zhipu's new generation of visual reasoning models based on the MOE architecture.",
 	},
 	"glm-4.5-air": {

src/api/providers/__tests__/zai.spec.ts

@@ -162,6 +162,11 @@ describe("ZAiHandler", () => {
 			expect(model.info.supportsImages).toBe(true)
 			expect(model.info.contextWindow).toBe(64_000)
 		})
+
+		it("should include tiers for GLM-4.5V China model", () => {
+			const info = mainlandZAiModels["glm-4.5v"]
+			expect(info.tiers?.length).toBe(3)
+		})
 	})
 
 	describe("Default behavior", () => {

src/api/providers/zai.ts

@@ -8,25 +8,30 @@ import {
 } from "@roo-code/types"
 
 import type { ApiHandlerOptions } from "../../shared/api"
+import type { InternationalZAiModelId, MainlandZAiModelId, ModelInfo } from "@roo-code/types"
 
 import { BaseOpenAiCompatibleProvider } from "./base-openai-compatible-provider"
 
-export class ZAiHandler extends BaseOpenAiCompatibleProvider<string> {
+type ZAiModelId = InternationalZAiModelId | MainlandZAiModelId
+
+export class ZAiHandler extends BaseOpenAiCompatibleProvider<ZAiModelId> {
 	constructor(options: ApiHandlerOptions) {
-		const isChina = zaiApiLineConfigs[options.zaiApiLine ?? "international_coding"].isChina
-		const models = (isChina ? mainlandZAiModels : internationalZAiModels) as Record<
-			string,
-			import("@roo-code/types").ModelInfo
+		const line = options.zaiApiLine ?? "international_coding"
+		const { isChina, baseUrl } = zaiApiLineConfigs[line]
+
+		const defaultModelId = isChina ? mainlandZAiDefaultModelId : internationalZAiDefaultModelId
+		const providerModels = (isChina ? mainlandZAiModels : internationalZAiModels) as unknown as Record<
+			ZAiModelId,
+			ModelInfo
 		>
-		const defaultModelId = (isChina ? mainlandZAiDefaultModelId : internationalZAiDefaultModelId) as string
 
 		super({
 			...options,
 			providerName: "Z AI",
-			baseURL: zaiApiLineConfigs[options.zaiApiLine ?? "international_coding"].baseUrl,
+			baseURL: baseUrl,
 			apiKey: options.zaiApiKey ?? "not-provided",
-			defaultProviderModelId: defaultModelId as any,
-			providerModels: models as any,
+			defaultProviderModelId: defaultModelId,
+			providerModels,
 			defaultTemperature: ZAI_DEFAULT_TEMPERATURE,
 		})
 	}