bug: space in folder and file name

Author: kunwarVivek

src/core/mentions/__tests__/index.test.ts

@@ -145,7 +145,7 @@ Detailed commit message with multiple lines
 			expect(result).toContain(`Error fetching commit info: ${errorMessage}`)
 		})
 
-		it("should parse file paths with spaces", async () => {
+		it("should parse file paths with escaped spaces", async () => {
 			// Mock the file content fetching
 			const fileContent = "This is the content of the file with spaces in its name"
 
@@ -155,8 +155,8 @@ Detailed commit message with multiple lines
 			jest.spyOn(fs, "readFile").mockResolvedValue(fileContent)
 			jest.spyOn(fs, "stat").mockResolvedValue({ isFile: () => true, isDirectory: () => false } as any)
 
-			// Test with a file path containing spaces
-			const filePath = "/path/with spaces/my file.txt"
+			// Test with a file path containing escaped spaces
+			const filePath = "/path/with\\ spaces/my\\ file.txt"
 
 			// First, verify that the regex pattern correctly matches the entire path
 			// Import the regex pattern directly to test it
@@ -168,14 +168,14 @@ Detailed commit message with multiple lines
 			// Now test the full parseMentions function
 			const result = await parseMentions(`Check out this file @${filePath}`, mockCwd, mockUrlContentFetcher)
 
-			// Verify the file path with spaces was correctly parsed
+			// Verify the file path with escaped spaces was correctly parsed
+			// The spaces should be unescaped when displayed
 			expect(result).toContain(`'path/with spaces/my file.txt' (see below for file content)`)
 			expect(result).toContain(`<file_content path="path/with spaces/my file.txt">`)
 		})
 
-		it("should parse folder paths with spaces", async () => {
+		it("should parse folder paths with escaped spaces", async () => {
 			// Mock the folder content fetching
-			const folderContent = "├── file1.txt\n├── file2.txt\n└── subfolder/"
 
 			// Mock the getFileOrFolderContent function (which is called internally by parseMentions)
 			// This is done by mocking the fs.readdir and fs.stat that would be called inside getFileOrFolderContent
@@ -187,13 +187,48 @@ Detailed commit message with multiple lines
 			])
 			jest.spyOn(fs, "stat").mockResolvedValue({ isFile: () => false, isDirectory: () => true } as any)
 
-			const folderPath = "/folder with spaces/"
+			// Test with a folder path containing escaped spaces
+			const folderPath = "/folder\\ with\\ spaces/"
+
+			// First, verify that the regex pattern correctly matches the entire path
+			const { mentionRegexGlobal } = require("../../../shared/context-mentions")
+			const mentionMatch = `@${folderPath}`.match(mentionRegexGlobal)
+			expect(mentionMatch).not.toBeNull()
+			expect(mentionMatch![0]).toBe(`@${folderPath}`)
+
 			const result = await parseMentions(`Check out this folder @${folderPath}`, mockCwd, mockUrlContentFetcher)
 
-			// Verify the folder path with spaces was correctly parsed
+			// Verify the folder path with escaped spaces was correctly parsed
+			// The spaces should be unescaped when displayed
 			expect(result).toContain(`'folder with spaces/' (see below for folder content)`)
 			expect(result).toContain(`<folder_content path="folder with spaces/">`)
 		})
+
+		it("should parse nested paths with multiple escaped spaces", async () => {
+			// Mock the file content fetching
+			const fileContent = "This is the content of the file with multiple spaces in its path"
+
+			// Mock the getFileOrFolderContent function
+			const fs = require("fs/promises")
+			jest.spyOn(fs, "readFile").mockResolvedValue(fileContent)
+			jest.spyOn(fs, "stat").mockResolvedValue({ isFile: () => true, isDirectory: () => false } as any)
+
+			// Test with a deeply nested path containing multiple escaped spaces
+			const filePath = "/root\\ dir/my\\ documents/project\\ files/important\\ notes/final\\ draft\\ v2.txt"
+
+			// Verify the regex pattern correctly matches the entire path
+			const { mentionRegexGlobal } = require("../../../shared/context-mentions")
+			const mentionMatch = `@${filePath}`.match(mentionRegexGlobal)
+			expect(mentionMatch).not.toBeNull()
+			expect(mentionMatch![0]).toBe(`@${filePath}`)
+
+			// Test the full parseMentions function
+			const result = await parseMentions(`Check out this file @${filePath}`, mockCwd, mockUrlContentFetcher)
+
+			// Verify the complex path was correctly parsed with all spaces unescaped
+			expect(result).toContain(`'root dir/my documents/project files/important notes/final draft v2.txt' (see below for file content)`)
+			expect(result).toContain(`<file_content path="root dir/my documents/project files/important notes/final draft v2.txt">`)
+		})
 	})
 
 	describe("openMention", () => {

src/core/mentions/index.ts

@@ -47,21 +47,24 @@ export async function parseMentions(
 ): Promise<string> {
 	const mentions: Set<string> = new Set()
 	let parsedText = text.replace(mentionRegexGlobal, (match, mention) => {
-		mentions.add(mention)
-		if (mention.startsWith("http")) {
-			return `'${mention}' (see below for site content)`
-		} else if (mention.startsWith("/")) {
-			const mentionPath = mention.slice(1)
+		// Unescape spaces in the mention (convert "\\s" to " ")
+		const unescapedMention = mention.replace(/\\\\\s/g, " ")
+		mentions.add(unescapedMention)
+
+		if (unescapedMention.startsWith("http")) {
+			return `'${unescapedMention}' (see below for site content)`
+		} else if (unescapedMention.startsWith("/")) {
+			const mentionPath = unescapedMention.slice(1)
 			return mentionPath.endsWith("/")
 				? `'${mentionPath}' (see below for folder content)`
 				: `'${mentionPath}' (see below for file content)`
-		} else if (mention === "problems") {
+		} else if (unescapedMention === "problems") {
 			return `Workspace Problems (see below for diagnostics)`
-		} else if (mention === "git-changes") {
+		} else if (unescapedMention === "git-changes") {
 			return `Working directory changes (see below for details)`
-		} else if (/^[a-f0-9]{7,40}$/.test(mention)) {
-			return `Git commit '${mention}' (see below for commit info)`
-		} else if (mention === "terminal") {
+		} else if (/^[a-f0-9]{7,40}$/.test(unescapedMention)) {
+			return `Git commit '${unescapedMention}' (see below for commit info)`
+		} else if (unescapedMention === "terminal") {
 			return `Terminal Output (see below for output)`
 		}
 		return match

src/shared/context-mentions.ts

@@ -18,10 +18,11 @@ Mention regex:
 	  - `|`: Logical OR.
 	  - `\w+:\/\/`:
 		- **Protocol (`\w+://`)**: Matches URLs that start with a word character sequence followed by '://', such as 'http://', 'https://', 'ftp://', etc.
-	- `[^\r\n]*?(?=\s*$|\s+@|[.,;:!?](?=[\s\r\n]|$))`:
-	  - **Character Pattern**: Matches any characters except line breaks.
+	- `[^\s\r\n]*?(?:\\\\\s[^\s\r\n]*?)*?(?=\s*$|\s+@|[.,;:!?](?=[\s\r\n]|$))`:
+	  - **Character Pattern**: Matches any characters except whitespace and line breaks.
+	  - **Escaped Spaces**: The `(?:\\\\\s[^\s\r\n]*?)*?` part allows for escaped spaces (like `\\s`) in the path.
 	  - **Followed by a lookahead**: Ensures the match ends at the end of the line, before another @ symbol, or before punctuation followed by whitespace or end of line.
-	  - **This allows spaces within file paths while properly handling path boundaries**.
+	  - **This handles paths with escaped spaces (e.g., `my\\ folder/my\\ file.txt`)**.
 	  - **Non-Greedy (`*?`)**: Ensures the smallest possible match.
 	- `|`: Logical OR.
 	- `problems\b`:
@@ -40,8 +41,8 @@ Mention regex:
 
 - **Summary**:
   - The regex effectively matches:
-	- Mentions that are file or folder paths starting with '/' and can contain spaces within the path (e.g., 'my folder/my file.txt').
-	  The regex now properly handles paths with multiple spaces and ensures the entire path is captured.
+	- Mentions that are file or folder paths starting with '/' and can contain escaped spaces within the path (e.g., 'my\\ folder/my\\ file.txt').
+	  The regex properly handles paths with escaped spaces and ensures the entire path is captured.
 	- URLs that start with a protocol (like 'http://') followed by any non-whitespace characters (including query parameters).
 	- The exact word 'problems'.
 	- The exact word 'git-changes'.
@@ -53,7 +54,7 @@ Mention regex:
 
 */
 export const mentionRegex =
-	/@((?:\/|\w+:\/\/)[^\r\n]*?(?=\s*$|\s+@|[.,;:!?](?=[\s\r\n]|$))|[a-f0-9]{7,40}\b|problems\b|git-changes\b|terminal\b)(?=[.,;:!?]?(?=[\s\r\n]|$))/
+	/@((?:\/|\w+:\/\/)[^\s\r\n]*?(?:\\\\\s[^\s\r\n]*?)*?(?=\s*$|\s+@|[.,;:!?](?=[\s\r\n]|$))|[a-f0-9]{7,40}\b|problems\b|git-changes\b|terminal\b)(?=[.,;:!?]?(?=[\s\r\n]|$))/
 export const mentionRegexGlobal = new RegExp(mentionRegex.source, "g")
 
 export interface MentionSuggestion {

webview-ui/src/utils/__tests__/context-mentions.test.ts

@@ -373,13 +373,18 @@ describe("shouldShowContextMenu", () => {
 		expect(shouldShowContextMenu("@problems", 9)).toBe(true)
 	})
 
-	it("should return true for file paths with spaces", () => {
-		// Test with a file path containing spaces
-		expect(shouldShowContextMenu("@/path/to/my file.txt", 20)).toBe(true)
+	it("should return true for file paths with escaped spaces", () => {
+		// Test with a file path containing escaped spaces
+		expect(shouldShowContextMenu("@/path/to/my\\ file.txt", 20)).toBe(true)
 	})
 
-	it("should return true for folder paths with spaces", () => {
-		// Test with a folder path containing spaces
-		expect(shouldShowContextMenu("@/path/to/my folder/", 20)).toBe(true)
+	it("should return true for folder paths with escaped spaces", () => {
+		// Test with a folder path containing escaped spaces
+		expect(shouldShowContextMenu("@/path/to/my\\ folder/", 20)).toBe(true)
+	})
+
+	it("should return true for nested paths with multiple escaped spaces", () => {
+		// Test with a deeply nested path containing multiple escaped spaces
+		expect(shouldShowContextMenu("@/root\\ dir/my\\ documents/project\\ files/file.txt", 50)).toBe(true)
 	})
 })