feat: add toggle functionality for enabling/disabling all global MCP servers with configuration reload + Tests

Author: seedlord

src/services/mcp/McpHub.ts

@@ -941,20 +941,26 @@ export class McpHub {
 
 			// Update the connection object
 			if (connection) {
-				try {
-					connection.server.disabled = disabled
+				const wasDisabled = connection.server.disabled
+				connection.server.disabled = disabled
+
+				// When the server is activated, reload the configuration
+				if (wasDisabled && !disabled) {
+					await this.initializeMcpServers(serverSource)
+				}
 
-					// Only refresh capabilities if connected
-					if (connection.server.status === "connected") {
+				// Only refresh capabilities if connected
+				if (connection.server.status === "connected") {
+					try {
 						connection.server.tools = await this.fetchToolsList(serverName, serverSource)
 						connection.server.resources = await this.fetchResourcesList(serverName, serverSource)
 						connection.server.resourceTemplates = await this.fetchResourceTemplatesList(
 							serverName,
 							serverSource,
 						)
+					} catch (error) {
+						console.error(`Failed to refresh capabilities for ${serverName}:`, error)
 					}
-				} catch (error) {
-					console.error(`Failed to refresh capabilities for ${serverName}:`, error)
 				}
 			}
 
@@ -1287,4 +1293,33 @@ export class McpHub {
 		}
 		this.disposables.forEach((d) => d.dispose())
 	}
+
+	/**
+	 * Enables or disables all global MCP servers at once.
+	 * When activated, the configuration is reloaded.
+	 * @param disabled true = disable all, false = enable all
+	 */
+	public async toggleAllServersDisabled(disabled: boolean): Promise<void> {
+		// Collect all global server names
+		const globalConnections = this.connections.filter(
+			(conn) => conn.server.source === "global" || !conn.server.source,
+		)
+		const serverNames = globalConnections.map((conn) => conn.server.name)
+
+		// Set the Disabled flag for all serversv
+		for (const name of serverNames) {
+			await this.updateServerConfig(name, { disabled }, "global")
+			const conn = this.findConnection(name, "global")
+			if (conn) {
+				conn.server.disabled = disabled
+			}
+		}
+
+		// If activated, reload configuration
+		if (!disabled) {
+			await this.initializeMcpServers("global")
+		}
+
+		await this.notifyWebviewOfServerChanges()
+	}
 }

src/services/mcp/__tests__/McpHub.test.ts

@@ -560,5 +560,77 @@ describe("McpHub", () => {
 				)
 			})
 		})
+		describe("toggleServerDisabled (Configuration reload)", () => {
+			it("should reload configuration when enabling a server (calls initializeMcpServers)", async () => {
+				const mockConfig: any = {
+					mcpServers: {
+						"test-server": {
+							type: "stdio",
+							command: "node",
+							args: ["test.js"],
+							disabled: true,
+						},
+					},
+				}
+
+				;(fs.readFile as jest.Mock).mockResolvedValueOnce(JSON.stringify(mockConfig))
+
+				mcpHub.connections = [
+					{
+						server: {
+							name: "test-server",
+							config: JSON.stringify(mockConfig.mcpServers["test-server"]),
+							status: "connected",
+							disabled: true,
+						},
+						client: { request: jest.fn() },
+						transport: { close: jest.fn() },
+					} as any,
+				]
+
+				const spy = jest.spyOn(mcpHub as any, "initializeMcpServers").mockResolvedValue(undefined)
+
+				await mcpHub.toggleServerDisabled("test-server", false)
+				// Expectation: initializeMcpServers was called
+				expect(spy).toHaveBeenCalledWith("global")
+				spy.mockRestore()
+			})
+		})
+		describe("toggleAllServersDisabled (global enable/disable)", () => {
+			it("should reload configuration when globally enabling all servers (calls initializeMcpServers)", async () => {
+				// Two global servers, both disabled
+				mcpHub.connections = [
+					{
+						server: {
+							name: "server1",
+							config: JSON.stringify({ type: "stdio", command: "node", args: ["a.js"], disabled: true }),
+							status: "disconnected",
+							disabled: true,
+							source: "global",
+						},
+						client: { request: jest.fn() },
+						transport: { close: jest.fn() },
+					} as any,
+					{
+						server: {
+							name: "server2",
+							config: JSON.stringify({ type: "stdio", command: "node", args: ["b.js"], disabled: true }),
+							status: "disconnected",
+							disabled: true,
+							source: "global",
+						},
+						client: { request: jest.fn() },
+						transport: { close: jest.fn() },
+					} as any,
+				]
+
+				const spy = jest.spyOn(mcpHub as any, "initializeMcpServers").mockResolvedValue(undefined)
+
+				await mcpHub.toggleAllServersDisabled(false) // actiate global
+
+				expect(spy).toHaveBeenCalledWith("global")
+				spy.mockRestore()
+			})
+		})
 	})
 })