PR feedback

Author: mrubens

packages/cloud/src/ShareService.ts

@@ -1,7 +1,7 @@
 import axios from "axios"
 import * as vscode from "vscode"
 
-import type { ShareResponse } from "@roo-code/types"
+import { shareResponseSchema } from "@roo-code/types"
 import { getRooCodeApiUrl } from "./Config"
 import type { AuthService } from "./AuthService"
 import type { SettingsService } from "./SettingsService"
@@ -24,10 +24,6 @@ export class ShareService {
 	 */
 	async shareTask(taskId: string): Promise<boolean> {
 		try {
-			if (!this.authService.hasActiveSession()) {
-				return false
-			}
-
 			const sessionToken = this.authService.getSessionToken()
 			if (!sessionToken) {
 				return false
@@ -45,7 +41,7 @@ export class ShareService {
 				},
 			)
 
-			const data = response.data as ShareResponse
+			const data = shareResponseSchema.parse(response.data)
 			this.log("[share] Share link created successfully:", data)
 
 			if (data.success && data.shareUrl) {

packages/types/src/cloud.ts

@@ -109,8 +109,10 @@ export const ORGANIZATION_DEFAULT: OrganizationSettings = {
  * Share Types
  */
 
-export interface ShareResponse {
-	success: boolean
-	shareUrl?: string
-	error?: string
-}
+export const shareResponseSchema = z.object({
+	success: z.boolean(),
+	shareUrl: z.string().optional(),
+	error: z.string().optional(),
+})
+
+export type ShareResponse = z.infer<typeof shareResponseSchema>

src/i18n/locales/ca/common.json

@@ -82,7 +82,7 @@
 		"custom_storage_path_set": "Ruta d'emmagatzematge personalitzada establerta: {{path}}",
 		"default_storage_path": "S'ha reprès l'ús de la ruta d'emmagatzematge predeterminada",
 		"settings_imported": "Configuració importada correctament.",
-		"share_link_copied": "Enllaç de compartició copiat al portapapers!"
+		"share_link_copied": "Enllaç de compartició copiat al portapapers"
 	},
 	"answers": {
 		"yes": "Sí",

src/i18n/locales/de/common.json

@@ -78,7 +78,7 @@
 		"custom_storage_path_set": "Benutzerdefinierter Speicherpfad festgelegt: {{path}}",
 		"default_storage_path": "Auf Standardspeicherpfad zurückgesetzt",
 		"settings_imported": "Einstellungen erfolgreich importiert.",
-		"share_link_copied": "Share-Link in die Zwischenablage kopiert!"
+		"share_link_copied": "Share-Link in die Zwischenablage kopiert"
 	},
 	"answers": {
 		"yes": "Ja",

src/i18n/locales/en/common.json

@@ -78,7 +78,7 @@
 		"custom_storage_path_set": "Custom storage path set: {{path}}",
 		"default_storage_path": "Reverted to using default storage path",
 		"settings_imported": "Settings imported successfully.",
-		"share_link_copied": "Share link copied to clipboard!"
+		"share_link_copied": "Share link copied to clipboard"
 	},
 	"answers": {
 		"yes": "Yes",

src/i18n/locales/es/common.json

@@ -78,7 +78,7 @@
 		"custom_storage_path_set": "Ruta de almacenamiento personalizada establecida: {{path}}",
 		"default_storage_path": "Se ha vuelto a usar la ruta de almacenamiento predeterminada",
 		"settings_imported": "Configuración importada correctamente.",
-		"share_link_copied": "¡Enlace de compartir copiado al portapapeles!"
+		"share_link_copied": "Enlace de compartir copiado al portapapeles"
 	},
 	"answers": {
 		"yes": "Sí",

src/i18n/locales/fr/common.json

@@ -78,7 +78,7 @@
 		"custom_storage_path_set": "Chemin de stockage personnalisé défini : {{path}}",
 		"default_storage_path": "Retour au chemin de stockage par défaut",
 		"settings_imported": "Paramètres importés avec succès.",
-		"share_link_copied": "Lien de partage copié dans le presse-papiers !"
+		"share_link_copied": "Lien de partage copié dans le presse-papiers"
 	},
 	"answers": {
 		"yes": "Oui",

src/i18n/locales/hi/common.json

@@ -78,7 +78,7 @@
 		"custom_storage_path_set": "कस्टम स्टोरेज पाथ सेट किया गया: {{path}}",
 		"default_storage_path": "डिफ़ॉल्ट स्टोरेज पाथ का उपयोग पुनः शुरू किया गया",
 		"settings_imported": "सेटिंग्स सफलतापूर्वक इम्पोर्ट की गईं।",
-		"share_link_copied": "साझा लिंक क्लिपबोर्ड पर कॉपी किया गया!"
+		"share_link_copied": "साझा लिंक क्लिपबोर्ड पर कॉपी किया गया"
 	},
 	"answers": {
 		"yes": "हां",

src/i18n/locales/it/common.json

@@ -78,7 +78,7 @@
 		"custom_storage_path_set": "Percorso di archiviazione personalizzato impostato: {{path}}",
 		"default_storage_path": "Tornato al percorso di archiviazione predefinito",
 		"settings_imported": "Impostazioni importate con successo.",
-		"share_link_copied": "Link di condivisione copiato negli appunti!"
+		"share_link_copied": "Link di condivisione copiato negli appunti"
 	},
 	"answers": {
 		"yes": "Sì",

src/i18n/locales/zh-CN/common.json

@@ -78,7 +78,7 @@
 		"custom_storage_path_set": "自定义存储路径已设置：{{path}}",
 		"default_storage_path": "已恢复使用默认存储路径",
 		"settings_imported": "设置已成功导入。",
-		"share_link_copied": "分享链接已复制到剪贴板！"
+		"share_link_copied": "分享链接已复制到剪贴板"
 	},
 	"answers": {
 		"yes": "是",