fix: simplify unsaved changes check in CodeIndexSettings component

Author: daniel-lxs

webview-ui/src/components/settings/CodeIndexSettings.tsx

@@ -175,43 +175,6 @@ export const CodeIndexSettings: React.FC<CodeIndexSettingsProps> = ({
 		}
 	}
 
-	// Check if there are unsaved indexing-related changes (excluding search threshold)
-	function hasUnsavedIndexingChanges(config: CodebaseIndexConfig | undefined, apiConfig: ProviderSettings): boolean {
-		// If settings aren't committed, we need to check what specifically changed
-		if (!areSettingsCommitted) {
-			// Get the saved state from vscode
-			const savedState = vscode.getState() as any
-			if (!savedState) return true // If no saved state, consider it as having changes
-
-			const savedConfig = savedState?.codebaseIndexConfig || {}
-			const savedApiConfig = savedState?.apiConfiguration || {}
-
-			// Check if any indexing-related settings changed (excluding search threshold)
-			const indexingConfigChanged =
-				config?.codebaseIndexEnabled !== savedConfig.codebaseIndexEnabled ||
-				config?.codebaseIndexEmbedderProvider !== savedConfig.codebaseIndexEmbedderProvider ||
-				config?.codebaseIndexEmbedderModelId !== savedConfig.codebaseIndexEmbedderModelId ||
-				config?.codebaseIndexEmbedderBaseUrl !== savedConfig.codebaseIndexEmbedderBaseUrl ||
-				config?.codebaseIndexQdrantUrl !== savedConfig.codebaseIndexQdrantUrl
-
-			// Check if API keys changed based on provider
-			const apiKeysChanged =
-				(config?.codebaseIndexEmbedderProvider === "openai" &&
-					apiConfig.codeIndexOpenAiKey !== savedApiConfig.codeIndexOpenAiKey) ||
-				(config?.codebaseIndexEmbedderProvider === "openai-compatible" &&
-					(apiConfig.codebaseIndexOpenAiCompatibleApiKey !==
-						savedApiConfig.codebaseIndexOpenAiCompatibleApiKey ||
-						apiConfig.codebaseIndexOpenAiCompatibleBaseUrl !==
-							savedApiConfig.codebaseIndexOpenAiCompatibleBaseUrl ||
-						apiConfig.codebaseIndexOpenAiCompatibleModelDimension !==
-							savedApiConfig.codebaseIndexOpenAiCompatibleModelDimension)) ||
-				apiConfig.codeIndexQdrantApiKey !== savedApiConfig.codeIndexQdrantApiKey
-
-			return indexingConfigChanged || apiKeysChanged
-		}
-		return false
-	}
-
 	const progressPercentage =
 		indexingStatus.totalItems > 0
 			? (indexingStatus.processedItems / indexingStatus.totalItems) * 100
@@ -541,7 +504,7 @@ export const CodeIndexSettings: React.FC<CodeIndexSettingsProps> = ({
 						</div>
 					</div>
 
-					{hasUnsavedIndexingChanges(codebaseIndexConfig, apiConfiguration) && (
+					{(!areSettingsCommitted || !validateIndexingConfig(codebaseIndexConfig, apiConfiguration)) && (
 						<p className="text-sm text-vscode-descriptionForeground mb-2">
 							{t("settings:codeIndex.unsavedSettingsMessage")}
 						</p>
@@ -552,7 +515,7 @@ export const CodeIndexSettings: React.FC<CodeIndexSettingsProps> = ({
 							<VSCodeButton
 								onClick={() => vscode.postMessage({ type: "startIndexing" })}
 								disabled={
-									hasUnsavedIndexingChanges(codebaseIndexConfig, apiConfiguration) ||
+									!areSettingsCommitted ||
 									!validateIndexingConfig(codebaseIndexConfig, apiConfiguration)
 								}>
 								{t("settings:codeIndex.startIndexingButton")}