Skip to content

Commit 50dd578

Browse files
committed
fix: address PR feedback - update all language files and improve documentation links
- Added <0> placeholders to all 17 non-English translation files for global rules links - Updated documentation anchors to use #global-rules-directory and #setting-up-global-rules - Added aria-label attributes to all VSCodeLink components for better accessibility - Improved UTM campaign parameter naming for clearer tracking
1 parent 9bc6e1a commit 50dd578

File tree

18 files changed

+49
-43
lines changed

18 files changed

+49
-43
lines changed

webview-ui/src/components/modes/ModesView.tsx

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -601,10 +601,12 @@ const ModesView = ({ onDone }: ModesViewProps) => {
601601
<Trans i18nKey="prompts:modes.createModeHelpText">
602602
<VSCodeLink
603603
href={buildDocLink("basic-usage/using-modes", "prompts_view_modes")}
604-
style={{ display: "inline" }}></VSCodeLink>
604+
style={{ display: "inline" }}
605+
aria-label="Learn about using modes"></VSCodeLink>
605606
<VSCodeLink
606607
href={buildDocLink("features/custom-modes", "prompts_view_modes")}
607-
style={{ display: "inline" }}></VSCodeLink>
608+
style={{ display: "inline" }}
609+
aria-label="Learn about customizing modes"></VSCodeLink>
608610
</Trans>
609611
</div>
610612

@@ -1169,10 +1171,11 @@ const ModesView = ({ onDone }: ModesViewProps) => {
11691171
"0": (
11701172
<VSCodeLink
11711173
href={buildDocLink(
1172-
"features/custom-instructions#global-custom-instructions",
1173-
"prompts_mode_custom_instructions_global",
1174+
"features/custom-instructions#global-rules-directory",
1175+
"prompts_mode_specific_global_rules",
11741176
)}
11751177
style={{ display: "inline" }}
1178+
aria-label="Learn about global custom instructions for modes"
11761179
/>
11771180
),
11781181
}}
@@ -1300,7 +1303,8 @@ const ModesView = ({ onDone }: ModesViewProps) => {
13001303
"features/footgun-prompting",
13011304
"prompts_advanced_system_prompt",
13021305
)}
1303-
style={{ display: "inline" }}></VSCodeLink>
1306+
style={{ display: "inline" }}
1307+
aria-label="Read important information about overriding system prompts"></VSCodeLink>
13041308
),
13051309
"2": <strong />,
13061310
}}
@@ -1319,10 +1323,11 @@ const ModesView = ({ onDone }: ModesViewProps) => {
13191323
<Trans i18nKey="prompts:globalCustomInstructions.description">
13201324
<VSCodeLink
13211325
href={buildDocLink(
1322-
"features/custom-instructions#global-custom-instructions",
1326+
"features/custom-instructions#setting-up-global-rules",
13231327
"prompts_global_custom_instructions",
13241328
)}
1325-
style={{ display: "inline" }}></VSCodeLink>
1329+
style={{ display: "inline" }}
1330+
aria-label="Learn more about global custom instructions"></VSCodeLink>
13261331
</Trans>
13271332
</div>
13281333
<VSCodeTextArea
@@ -1364,10 +1369,11 @@ const ModesView = ({ onDone }: ModesViewProps) => {
13641369
"0": (
13651370
<VSCodeLink
13661371
href={buildDocLink(
1367-
"features/custom-instructions#global-custom-instructions",
1368-
"prompts_global_custom_instructions_global",
1372+
"features/custom-instructions#setting-up-global-rules",
1373+
"prompts_global_rules",
13691374
)}
13701375
style={{ display: "inline" }}
1376+
aria-label="Learn about setting up global custom instructions"
13711377
/>
13721378
),
13731379
}}

webview-ui/src/i18n/locales/ca/prompts.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/de/prompts.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/es/prompts.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/fr/prompts.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/hi/prompts.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/id/prompts.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/it/prompts.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/ja/prompts.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/ko/prompts.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)