Skip to content

Commit 51c47dc

Browse files
committed
PR feedback
1 parent adade37 commit 51c47dc

File tree

2 files changed

+16
-12
lines changed

2 files changed

+16
-12
lines changed

src/__tests__/commands.spec.ts

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@ describe("Command Utilities", () => {
1111
const testCwd = "/test/project"
1212

1313
describe("getCommandNameFromFile", () => {
14-
it("should strip all extensions from filename", () => {
14+
it("should strip .md extension only", () => {
1515
expect(getCommandNameFromFile("my-command.md")).toBe("my-command")
16-
expect(getCommandNameFromFile("test.txt")).toBe("test")
16+
expect(getCommandNameFromFile("test.txt")).toBe("test.txt")
1717
expect(getCommandNameFromFile("no-extension")).toBe("no-extension")
18-
expect(getCommandNameFromFile("multiple.dots.file.md")).toBe("multiple")
18+
expect(getCommandNameFromFile("multiple.dots.file.md")).toBe("multiple.dots.file")
19+
expect(getCommandNameFromFile("api.config.md")).toBe("api.config")
20+
expect(getCommandNameFromFile("deploy_prod.md")).toBe("deploy_prod")
1921
})
2022
})
2123

@@ -64,14 +66,14 @@ describe("Command Utilities", () => {
6466
expect(getCommandNameFromFile("command")).toBe("command")
6567
expect(getCommandNameFromFile("my-command")).toBe("my-command")
6668

67-
// Files with multiple dots - only strip first extension
68-
expect(getCommandNameFromFile("my.complex.command.md")).toBe("my")
69-
expect(getCommandNameFromFile("v1.2.3.txt")).toBe("v1")
69+
// Files with multiple dots - only strip .md extension
70+
expect(getCommandNameFromFile("my.complex.command.md")).toBe("my.complex.command")
71+
expect(getCommandNameFromFile("v1.2.3.txt")).toBe("v1.2.3.txt")
7072

7173
// Edge cases
72-
expect(getCommandNameFromFile(".")).toBe("")
73-
expect(getCommandNameFromFile("..")).toBe("")
74-
expect(getCommandNameFromFile(".hidden.md")).toBe("")
74+
expect(getCommandNameFromFile(".")).toBe(".")
75+
expect(getCommandNameFromFile("..")).toBe("..")
76+
expect(getCommandNameFromFile(".hidden.md")).toBe(".hidden")
7577
})
7678
})
7779

src/services/command/commands.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,13 @@ async function scanCommandDirectory(
8686
}
8787

8888
/**
89-
* Extract command name from filename (strip all extensions)
89+
* Extract command name from filename (strip .md extension only)
9090
*/
9191
export function getCommandNameFromFile(filename: string): string {
92-
const dotIndex = filename.indexOf(".")
93-
return dotIndex === -1 ? filename : filename.substring(0, dotIndex)
92+
if (filename.toLowerCase().endsWith(".md")) {
93+
return filename.slice(0, -3)
94+
}
95+
return filename
9496
}
9597

9698
/**

0 commit comments

Comments
 (0)