refactor: improve code quality based on PR review

- Remove console.log statements from Task.ts (use comments instead)
- Fix method naming confusion in openai-native.ts:
  - Renamed formatStructuredInput to formatFullConversation (clearer purpose)
  - Renamed prepareStructuredInput to prepareResponsesApiInput (clearer purpose)
- Add proper TypeScript types for GPT-5 metadata (new types.ts file)
- Fix error message inconsistency (GPT-5 -> Responses API)
- Extract magic string 'gpt-5' to constant GPT5_MODEL_PREFIX
- Remove dead code (isResponsesApiModel method that always returned true)
- Improve JSDoc for store parameter with detailed explanation
- Update tests to use new method names

All tests passing (30/30)

Author: daniel-lxs

src/api/index.ts

@@ -53,8 +53,11 @@ export interface ApiHandlerCreateMessageMetadata {
 	 */
 	suppressPreviousResponseId?: boolean
 	/**
-	 * Controls whether the response should be stored for 30 days (OpenAI Responses API).
-	 * Defaults to true if not specified.
+	 * Controls whether the response should be stored for 30 days in OpenAI's Responses API.
+	 * When true (default), responses are stored and can be referenced in future requests
+	 * using the previous_response_id for efficient conversation continuity.
+	 * Set to false to opt out of response storage for privacy or compliance reasons.
+	 * @default true
 	 */
 	store?: boolean
 }

src/api/providers/__tests__/openai-native.spec.ts

@@ -928,10 +928,14 @@ describe("OpenAiNativeHandler", () => {
 
 			// Test with metadata that has previousResponseId
 			// @ts-expect-error - private method
-			const { formattedInput, previousResponseId } = gpt5Handler.prepareStructuredInput(systemPrompt, messages, {
-				taskId: "task1",
-				previousResponseId: "resp_123",
-			})
+			const { formattedInput, previousResponseId } = gpt5Handler.prepareResponsesApiInput(
+				systemPrompt,
+				messages,
+				{
+					taskId: "task1",
+					previousResponseId: "resp_123",
+				},
+			)
 
 			expect(previousResponseId).toBe("resp_123")
 			expect(formattedInput).toEqual([

src/api/providers/openai-native.ts

@@ -28,6 +28,9 @@ export type OpenAiNativeModel = ReturnType<OpenAiNativeHandler["getModel"]>
 
 // GPT-5 specific types
 
+// Constants for model identification
+const GPT5_MODEL_PREFIX = "gpt-5"
+
 export class OpenAiNativeHandler extends BaseProvider implements SingleCompletionHandler {
 	protected options: ApiHandlerOptions
 	private client: OpenAI
@@ -155,7 +158,7 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 		}
 
 		// Format input and capture continuity id
-		const { formattedInput, previousResponseId } = this.prepareStructuredInput(systemPrompt, messages, metadata)
+		const { formattedInput, previousResponseId } = this.prepareResponsesApiInput(systemPrompt, messages, metadata)
 		const requestPreviousResponseId = effectivePreviousResponseId || previousResponseId
 
 		// Create a new promise for this request's response ID
@@ -222,7 +225,9 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 			...(model.info.supportsTemperature !== false && {
 				temperature:
 					this.options.modelTemperature ??
-					(model.id.startsWith("gpt-5") ? GPT5_DEFAULT_TEMPERATURE : OPENAI_NATIVE_DEFAULT_TEMPERATURE),
+					(model.id.startsWith(GPT5_MODEL_PREFIX)
+						? GPT5_DEFAULT_TEMPERATURE
+						: OPENAI_NATIVE_DEFAULT_TEMPERATURE),
 			}),
 			// Explicitly include the calculated max output tokens.
 			// Use the per-request reserved output computed by Roo (params.maxTokens from getModelParams).
@@ -261,7 +266,7 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 			if (is400Error && requestBody.previous_response_id && isPreviousResponseError) {
 				// Log the error and retry without the previous_response_id
 				console.warn(
-					`[GPT-5] Previous response ID not found (${requestBody.previous_response_id}), retrying without it`,
+					`[Responses API] Previous response ID not found (${requestBody.previous_response_id}), retrying without it`,
 				)
 
 				// Remove the problematic previous_response_id and retry
@@ -301,8 +306,8 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 		}
 	}
 
-	private formatStructuredInput(systemPrompt: string, messages: Anthropic.Messages.MessageParam[]): any {
-		// Format the conversation for the Responses API using structured format
+	private formatFullConversation(systemPrompt: string, messages: Anthropic.Messages.MessageParam[]): any {
+		// Format the entire conversation history for the Responses API using structured format
 		// This supports both text and images
 		const formattedMessages: any[] = []
 
@@ -526,7 +531,8 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 	}
 
 	/**
-	 * Prepares the structured input and conversation continuity parameters for a Responses API call.
+	 * Prepares the input and conversation continuity parameters for a Responses API call.
+	 * Decides whether to send full conversation or just the latest message based on previousResponseId.
 	 *
 	 * - If a `previousResponseId` is available (either from metadata or the handler's state),
 	 *   it formats only the most recent user message for the input and returns the response ID
@@ -535,7 +541,7 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 	 *
 	 * @returns An object containing the formatted input and the previous response ID (if used).
 	 */
-	private prepareStructuredInput(
+	private prepareResponsesApiInput(
 		systemPrompt: string,
 		messages: Anthropic.Messages.MessageParam[],
 		metadata?: ApiHandlerCreateMessageMetadata,
@@ -560,7 +566,7 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 			return { formattedInput: [], previousResponseId }
 		} else {
 			// Format full conversation history (returns an array of structured messages)
-			const formattedInput = this.formatStructuredInput(systemPrompt, messages)
+			const formattedInput = this.formatFullConversation(systemPrompt, messages)
 			return { formattedInput }
 		}
 	}
@@ -1108,10 +1114,7 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 		return info.reasoningEffort as ReasoningEffortWithMinimal | undefined
 	}
 
-	private isResponsesApiModel(modelId: string): boolean {
-		// ALL models now use the Responses API
-		return true
-	}
+	// Removed isResponsesApiModel method as ALL models now use the Responses API
 
 	override getModel() {
 		const modelId = this.options.apiModelId
@@ -1126,18 +1129,18 @@ export class OpenAiNativeHandler extends BaseProvider implements SingleCompletio
 			modelId: id,
 			model: info,
 			settings: this.options,
-			defaultTemperature: id.startsWith("gpt-5") ? GPT5_DEFAULT_TEMPERATURE : OPENAI_NATIVE_DEFAULT_TEMPERATURE,
+			defaultTemperature: id.startsWith(GPT5_MODEL_PREFIX)
+				? GPT5_DEFAULT_TEMPERATURE
+				: OPENAI_NATIVE_DEFAULT_TEMPERATURE,
 		})
 
-		// For models using the Responses API (GPT-5 and Codex Mini), ensure we support reasoning effort
-		if (this.isResponsesApiModel(id)) {
-			const effort =
-				(this.options.reasoningEffort as ReasoningEffortWithMinimal | undefined) ??
-				(info.reasoningEffort as ReasoningEffortWithMinimal | undefined)
+		// For models using the Responses API, ensure we support reasoning effort
+		const effort =
+			(this.options.reasoningEffort as ReasoningEffortWithMinimal | undefined) ??
+			(info.reasoningEffort as ReasoningEffortWithMinimal | undefined)
 
-			if (effort) {
-				;(params.reasoning as any) = { reasoning_effort: effort }
-			}
+		if (effort) {
+			;(params.reasoning as any) = { reasoning_effort: effort }
 		}
 
 		// The o3 models are named like "o3-mini-[reasoning-effort]", which are

src/core/task/Task.ts

@@ -99,6 +99,7 @@ import { getMessagesSinceLastSummary, summarizeConversation } from "../condense"
 import { maybeRemoveImageBlocks } from "../../api/transform/image-cleaning"
 import { restoreTodoListForTask } from "../tools/updateTodoListTool"
 import { AutoApprovalHandler } from "./AutoApprovalHandler"
+import { Gpt5Metadata, ClineMessageWithMetadata } from "./types"
 
 const MAX_EXPONENTIAL_BACKOFF_SECONDS = 600 // 10 minutes
 
@@ -711,9 +712,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 			this.emit(RooCodeEventName.TaskIdle, this.taskId)
 		}
 
-		console.log(`[Task#${this.taskId}] pWaitFor askResponse(${type}) -> blocking`)
+		// Wait for askResponse to be set
 		await pWaitFor(() => this.askResponse !== undefined || this.lastMessageTs !== askTs, { interval: 100 })
-		console.log(`[Task#${this.taskId}] pWaitFor askResponse(${type}) -> unblocked (${this.askResponse})`)
 
 		if (this.lastMessageTs !== askTs) {
 			// Could happen if we send multiple asks in a row i.e. with
@@ -1012,7 +1012,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 
 		let imageBlocks: Anthropic.ImageBlockParam[] = formatResponse.imageBlocks(images)
 
-		console.log(`[subtasks] task ${this.taskId}.${this.instanceId} starting`)
+		// Task starting
 
 		await this.initiateTaskLoop([
 			{
@@ -1048,7 +1048,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 	}
 
 	private async resumeTaskFromHistory() {
-		console.log(`[Task#${this.taskId}] Resuming task from history`)
+		// Resuming task from history
 
 		if (this.enableTaskBridge) {
 			try {
@@ -1068,10 +1068,13 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 
 		// Check for any stored GPT-5 response IDs in the message history
 		const gpt5Messages = modifiedClineMessages.filter(
-			(m) => m.type === "say" && (m as any).say === "text" && (m as any).metadata?.gpt5?.previous_response_id,
+			(m) =>
+				m.type === "say" &&
+				m.say === "text" &&
+				(m as ClineMessageWithMetadata).metadata?.gpt5?.previous_response_id,
 		)
 		if (gpt5Messages.length > 0) {
-			const lastGpt5Message = gpt5Messages[gpt5Messages.length - 1] as any
+			const lastGpt5Message = gpt5Messages[gpt5Messages.length - 1] as ClineMessage & ClineMessageWithMetadata
 		}
 
 		// Remove any resume messages that may have been added before
@@ -1303,13 +1306,13 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 
 		await this.overwriteApiConversationHistory(modifiedApiConversationHistory)
 
-		console.log(`[subtasks] task ${this.taskId}.${this.instanceId} resuming from history item`)
+		// Task resuming from history item
 
 		await this.initiateTaskLoop(newUserContent)
 	}
 
 	public dispose(): void {
-		console.log(`[Task] disposing task ${this.taskId}.${this.instanceId}`)
+		// Disposing task
 
 		// Stop waiting for child task completion.
 		if (this.pauseInterval) {
@@ -1372,7 +1375,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 	}
 
 	public async abortTask(isAbandoned = false) {
-		console.log(`[subtasks] aborting task ${this.taskId}.${this.instanceId}`)
+		// Aborting task
 
 		// Will stop any autonomously running promises.
 		if (isAbandoned) {
@@ -1612,7 +1615,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 					// lastMessage.ts = Date.now() DO NOT update ts since it is used as a key for virtuoso list
 					lastMessage.partial = false
 					// instead of streaming partialMessage events, we do a save and post like normal to persist to disk
-					console.log("updating partial message", lastMessage)
+					// updating partial message
 					// await this.saveClineMessages()
 				}
 
@@ -1713,7 +1716,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 					}
 
 					if (this.abort) {
-						console.log(`aborting stream, this.abandoned = ${this.abandoned}`)
+						// Aborting stream
 
 						if (!this.abandoned) {
 							// Only need to gracefully abort if this instance
@@ -2140,18 +2143,16 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 					this.clineMessages,
 					(m) =>
 						m.type === "say" &&
-						(m as any).say === "text" &&
-						(m as any).metadata?.gpt5?.previous_response_id,
+						m.say === "text" &&
+						!!(m as ClineMessageWithMetadata).metadata?.gpt5?.previous_response_id,
 				)
 				if (idx !== -1) {
 					// Use the previous_response_id from the last assistant message for this request
-					previousResponseId = ((this.clineMessages[idx] as any).metadata.gpt5.previous_response_id ||
-						undefined) as string | undefined
+					const message = this.clineMessages[idx] as ClineMessage & ClineMessageWithMetadata
+					previousResponseId = message.metadata?.gpt5?.previous_response_id
 				}
 			} else if (this.skipPrevResponseIdOnce) {
-				console.log(
-					`[Task#${this.taskId}] Skipping previous_response_id due to recent condense operation - will send full conversation context`,
-				)
+				// Skipping previous_response_id due to recent condense operation - will send full conversation context
 			}
 		} catch (error) {
 			console.error(`[Task#${this.taskId}] Error retrieving GPT-5 response ID:`, error)
@@ -2327,17 +2328,20 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 			const lastResponseId: string | undefined = (this.api as any)?.getLastResponseId?.()
 			const idx = findLastIndex(
 				this.clineMessages,
-				(m) => m.type === "say" && (m as any).say === "text" && m.partial !== true,
+				(m) => m.type === "say" && m.say === "text" && m.partial !== true,
 			)
 			if (idx !== -1) {
-				const msg = this.clineMessages[idx] as any
-				msg.metadata = msg.metadata ?? {}
-				msg.metadata.gpt5 = {
+				const msg = this.clineMessages[idx] as ClineMessage & ClineMessageWithMetadata
+				if (!msg.metadata) {
+					msg.metadata = {}
+				}
+				const gpt5Metadata: Gpt5Metadata = {
 					...(msg.metadata.gpt5 ?? {}),
 					previous_response_id: lastResponseId,
 					instructions: this.lastUsedInstructions,
 					reasoning_summary: (reasoningMessage ?? "").trim() || undefined,
 				}
+				msg.metadata.gpt5 = gpt5Metadata
 			}
 		} catch (error) {
 			console.error(`[Task#${this.taskId}] Error persisting GPT-5 metadata:`, error)

src/core/task/types.ts

@@ -0,0 +1,37 @@
+/**
+ * Type definitions for Task-related metadata
+ */
+
+/**
+ * GPT-5 specific metadata stored with assistant messages
+ * for maintaining conversation continuity across requests
+ */
+export interface Gpt5Metadata {
+	/**
+	 * The response ID from the previous GPT-5 API response
+	 * Used to maintain conversation continuity in subsequent requests
+	 */
+	previous_response_id?: string
+
+	/**
+	 * The system instructions/prompt used for this response
+	 * Stored to track what instructions were active when the response was generated
+	 */
+	instructions?: string
+
+	/**
+	 * The reasoning summary from GPT-5's reasoning process
+	 * Contains the model's internal reasoning if reasoning mode was enabled
+	 */
+	reasoning_summary?: string
+}
+
+/**
+ * Extended ClineMessage type with GPT-5 metadata
+ */
+export interface ClineMessageWithMetadata {
+	metadata?: {
+		gpt5?: Gpt5Metadata
+		[key: string]: any
+	}
+}