test: update UI tests after task history migration

- Removed pass-through state tests from ContextProxy that no longer apply
- Updated ClineProvider tests to use file-based history instead of global state
- Modified ChatTextArea tests to use useTaskSearch hook instead of taskHistory prop
- Completely rewrote useTaskSearch tests to use message-based architecture
- Updated other tests to remove taskHistory references from mock states

Signed-off-by: Eric Wheeler <[email protected]>

test: Fix ClineProvider test by mocking extension context and taskHistory

This commit fixes the failing test 'correctly identifies subtask scenario for issue #4602' by:
1. Adding necessary Vitest imports
2. Mocking getExtensionContext to return a mock context with globalStorageUri
3. Mocking taskHistory module to prevent file system operations during tests

Signed-off-by: Eric Wheeler <[email protected]>

Author: Eric Wheeler

src/core/config/__tests__/ContextProxy.spec.ts

@@ -102,41 +102,6 @@ describe("ContextProxy", () => {
 			const result = proxy.getGlobalState("apiProvider", "deepseek")
 			expect(result).toBe("deepseek")
 		})
-
-		it("should bypass cache for pass-through state keys", async () => {
-			// Setup mock return value
-			mockGlobalState.get.mockReturnValue("pass-through-value")
-
-			// Use a pass-through key (taskHistory)
-			const result = proxy.getGlobalState("taskHistory")
-
-			// Should get value directly from original context
-			expect(result).toBe("pass-through-value")
-			expect(mockGlobalState.get).toHaveBeenCalledWith("taskHistory")
-		})
-
-		it("should respect default values for pass-through state keys", async () => {
-			// Setup mock to return undefined
-			mockGlobalState.get.mockReturnValue(undefined)
-
-			// Use a pass-through key with default value
-			const historyItems = [
-				{
-					id: "1",
-					number: 1,
-					ts: 1,
-					task: "test",
-					tokensIn: 1,
-					tokensOut: 1,
-					totalCost: 1,
-				},
-			]
-
-			const result = proxy.getGlobalState("taskHistory", historyItems)
-
-			// Should return default value when original context returns undefined
-			expect(result).toBe(historyItems)
-		})
 	})
 
 	describe("updateGlobalState", () => {
@@ -150,33 +115,6 @@ describe("ContextProxy", () => {
 			const storedValue = await proxy.getGlobalState("apiProvider")
 			expect(storedValue).toBe("deepseek")
 		})
-
-		it("should bypass cache for pass-through state keys", async () => {
-			const historyItems = [
-				{
-					id: "1",
-					number: 1,
-					ts: 1,
-					task: "test",
-					tokensIn: 1,
-					tokensOut: 1,
-					totalCost: 1,
-				},
-			]
-
-			await proxy.updateGlobalState("taskHistory", historyItems)
-
-			// Should update original context
-			expect(mockGlobalState.update).toHaveBeenCalledWith("taskHistory", historyItems)
-
-			// Setup mock for subsequent get
-			mockGlobalState.get.mockReturnValue(historyItems)
-
-			// Should get fresh value from original context
-			const storedValue = proxy.getGlobalState("taskHistory")
-			expect(storedValue).toBe(historyItems)
-			expect(mockGlobalState.get).toHaveBeenCalledWith("taskHistory")
-		})
 	})
 
 	describe("getSecret", () => {

src/core/task/__tests__/Task.spec.ts

@@ -198,22 +198,6 @@ describe("Cline", () => {
 		mockExtensionContext = {
 			globalState: {
 				get: vi.fn().mockImplementation((key: keyof GlobalState) => {
-					if (key === "taskHistory") {
-						return [
-							{
-								id: "123",
-								number: 0,
-								ts: Date.now(),
-								task: "historical task",
-								tokensIn: 100,
-								tokensOut: 200,
-								cacheWrites: 0,
-								cacheReads: 0,
-								totalCost: 0.001,
-							},
-						]
-					}
-
 					return undefined
 				}),
 				update: vi.fn().mockImplementation((_key, _value) => Promise.resolve()),

src/core/webview/__tests__/ClineProvider.spec.ts

@@ -1,5 +1,6 @@
 // npx vitest core/webview/__tests__/ClineProvider.spec.ts
 
+import { describe, test, expect, beforeEach, afterEach, afterAll, vi, it } from "vitest"
 import Anthropic from "@anthropic-ai/sdk"
 import * as vscode from "vscode"
 import axios from "axios"
@@ -20,6 +21,20 @@ import { ClineProvider } from "../ClineProvider"
 // Mock setup must come before imports
 vi.mock("../../prompts/sections/custom-instructions")
 
+// Mock extension context
+vi.mock("../../../extension", () => ({
+	getExtensionContext: vi.fn().mockReturnValue({
+		globalStorageUri: { fsPath: "/mock/storage/path" },
+	}),
+}))
+
+// Mock task history module
+vi.mock("../../task-persistence/taskHistory", () => ({
+	getHistoryItem: vi.fn().mockResolvedValue(undefined),
+	setHistoryItems: vi.fn().mockResolvedValue(undefined),
+	deleteHistoryItem: vi.fn().mockResolvedValue(undefined),
+}))
+
 vi.mock("vscode")
 
 vi.mock("p-wait-for", () => ({
@@ -147,6 +162,7 @@ vi.mock("vscode", () => ({
 		showInformationMessage: vi.fn(),
 		showWarningMessage: vi.fn(),
 		showErrorMessage: vi.fn(),
+		createTextEditorDecorationType: vi.fn().mockReturnValue({}),
 	},
 	workspace: {
 		getConfiguration: vi.fn().mockReturnValue({
@@ -500,7 +516,6 @@ describe("ClineProvider", () => {
 		const mockState: ExtensionState = {
 			version: "1.0.0",
 			clineMessages: [],
-			taskHistory: [],
 			shouldShowAnnouncement: false,
 			apiConfiguration: {
 				apiProvider: "openrouter",
@@ -735,7 +750,7 @@ describe("ClineProvider", () => {
 		expect(state).toHaveProperty("alwaysAllowWrite")
 		expect(state).toHaveProperty("alwaysAllowExecute")
 		expect(state).toHaveProperty("alwaysAllowBrowser")
-		expect(state).toHaveProperty("taskHistory")
+		// taskHistory has been deprecated and removed from the global state
 		expect(state).toHaveProperty("soundEnabled")
 		expect(state).toHaveProperty("ttsEnabled")
 		expect(state).toHaveProperty("diffEnabled")

src/core/webview/__tests__/webviewMessageHandler.spec.ts

@@ -39,10 +39,17 @@ vi.mock("vscode", () => ({
 	window: {
 		showInformationMessage: vi.fn(),
 		showErrorMessage: vi.fn(),
+		createTextEditorDecorationType: vi.fn(() => ({
+			key: "mock-decoration-type",
+		})),
 	},
 	workspace: {
 		workspaceFolders: [{ uri: { fsPath: "/mock/workspace" } }],
 	},
+	CodeActionKind: {
+		QuickFix: "QuickFix",
+		RefactorRewrite: "RefactorRewrite",
+	},
 }))
 
 vi.mock("../../../i18n", () => ({

webview-ui/src/components/chat/__tests__/ChatTextArea.spec.tsx

@@ -5,6 +5,7 @@ import { defaultModeSlug } from "@roo/modes"
 import { useExtensionState } from "@src/context/ExtensionStateContext"
 import { vscode } from "@src/utils/vscode"
 import * as pathMentions from "@src/utils/path-mentions"
+import { useTaskSearch } from "@src/components/history/useTaskSearch"
 
 import ChatTextArea from "../ChatTextArea"
 
@@ -16,6 +17,12 @@ vi.mock("@src/utils/vscode", () => ({
 
 vi.mock("@src/components/common/CodeBlock")
 vi.mock("@src/components/common/MarkdownBlock")
+vi.mock("@src/components/history/useTaskSearch", () => ({
+	useTaskSearch: vi.fn().mockReturnValue({
+		tasks: [],
+		loading: false,
+	}),
+}))
 vi.mock("@src/utils/path-mentions", () => ({
 	convertToMentionPath: vi.fn((path, cwd) => {
 		// Simple mock implementation that mimics the real function's behavior
@@ -674,19 +681,23 @@ describe("ChatTextArea", () => {
 			})
 
 			it("should use task history (oldest first) when no conversation messages exist", () => {
-				const mockTaskHistory = [
-					{ task: "First task", workspace: "/test/workspace" },
-					{ task: "Second task", workspace: "/test/workspace" },
-					{ task: "Third task", workspace: "/test/workspace" },
+				const mockTaskItems = [
+					{ id: "1", task: "First task", workspace: "/test/workspace", ts: 1000 },
+					{ id: "2", task: "Second task", workspace: "/test/workspace", ts: 2000 },
+					{ id: "3", task: "Third task", workspace: "/test/workspace", ts: 3000 },
 				]
 
+				// Mock useTaskSearch to return the task items
+				vi.mocked(useTaskSearch).mockReturnValue({
+					tasks: mockTaskItems,
+					loading: false,
+				} as any)
 				;(useExtensionState as ReturnType<typeof vi.fn>).mockReturnValue({
 					filePaths: [],
 					openedTabs: [],
 					apiConfiguration: {
 						apiProvider: "anthropic",
 					},
-					taskHistory: mockTaskHistory,
 					clineMessages: [], // No conversation messages
 					cwd: "/test/workspace",
 				})
@@ -714,16 +725,20 @@ describe("ChatTextArea", () => {
 				)
 
 				// Start with task history
+				// Mock useTaskSearch to return the task items
+				vi.mocked(useTaskSearch).mockReturnValue({
+					tasks: [
+						{ id: "1", task: "Task 1", workspace: "/test/workspace", ts: 1000 },
+						{ id: "2", task: "Task 2", workspace: "/test/workspace", ts: 2000 },
+					],
+					loading: false,
+				} as any)
 				;(useExtensionState as ReturnType<typeof vi.fn>).mockReturnValue({
 					filePaths: [],
 					openedTabs: [],
 					apiConfiguration: {
 						apiProvider: "anthropic",
 					},
-					taskHistory: [
-						{ task: "Task 1", workspace: "/test/workspace" },
-						{ task: "Task 2", workspace: "/test/workspace" },
-					],
 					clineMessages: [],
 					cwd: "/test/workspace",
 				})
@@ -737,6 +752,11 @@ describe("ChatTextArea", () => {
 				expect(setInputValue).toHaveBeenCalledWith("Task 1")
 
 				// Switch to conversation messages
+				// Reset the useTaskSearch mock
+				vi.mocked(useTaskSearch).mockReturnValue({
+					tasks: [],
+					loading: false,
+				} as any)
 				;(useExtensionState as ReturnType<typeof vi.fn>).mockReturnValue({
 					filePaths: [],
 					openedTabs: [],

webview-ui/src/components/history/__tests__/HistoryPreview.spec.tsx

@@ -88,8 +88,9 @@ describe("HistoryPreview", () => {
 	})
 
 	it("renders up to 3 tasks when tasks are available", () => {
+		// Only return the first 3 tasks since the component has a limit of 3
 		mockUseTaskSearch.mockReturnValue({
-			tasks: mockTasks,
+			tasks: mockTasks.slice(0, 3),
 			loading: false,
 			searchQuery: "",
 			setSearchQuery: vi.fn(),