fix: minor fixes and new cases for webView/ClineProvider unit test, remove outdated lm-studio fetcher

Author: pwilkin

src/api/providers/fetchers/lm-studio.ts

@@ -1,23 +1,22 @@
-import * as path from "path"
 import fs from "fs/promises"
+import * as path from "path"
 
 import NodeCache from "node-cache"
 import { safeWriteJson } from "../../../utils/safeWriteJson"
 
 import { ContextProxy } from "../../../core/config/ContextProxy"
-import { getCacheDirectoryPath } from "../../../utils/storage"
-import { RouterName, ModelRecord } from "../../../shared/api"
+import { ModelRecord, RouterName } from "../../../shared/api"
 import { fileExistsAtPath } from "../../../utils/fs"
+import { getCacheDirectoryPath } from "../../../utils/storage"
 
-import { getOpenRouterModels } from "./openrouter"
-import { getRequestyModels } from "./requesty"
+import { GetModelsOptions } from "../../../shared/api"
 import { getGlamaModels } from "./glama"
-import { getUnboundModels } from "./unbound"
 import { getLiteLLMModels } from "./litellm"
-import { getLmStudioModels } from "./lm-studio"
-import { GetModelsOptions } from "../../../shared/api"
-import { getOllamaModels } from "./ollama"
 import { getLMStudioModels } from "./lmstudio"
+import { getOllamaModels } from "./ollama"
+import { getOpenRouterModels } from "./openrouter"
+import { getRequestyModels } from "./requesty"
+import { getUnboundModels } from "./unbound"
 
 const memoryCache = new NodeCache({ stdTTL: 5 * 60, checkperiod: 5 * 60 })
 

src/api/providers/fetchers/modelCache.ts

@@ -16,6 +16,7 @@ import { Task, TaskOptions } from "../../task/Task"
 import { safeWriteJson } from "../../../utils/safeWriteJson"
 
 import { ClineProvider } from "../ClineProvider"
+import { LmStudioHandler } from "../../../api/providers"
 
 // Mock setup must come before imports
 vi.mock("../../prompts/sections/custom-instructions")
@@ -2371,6 +2372,7 @@ describe("ClineProvider - Router Models", () => {
 				unboundApiKey: "unbound-key",
 				litellmApiKey: "litellm-key",
 				litellmBaseUrl: "http://localhost:4000",
+				lmStudioBaseUrl: "http://localhost:1234",
 			},
 		} as any)
 
@@ -2404,6 +2406,10 @@ describe("ClineProvider - Router Models", () => {
 			apiKey: "litellm-key",
 			baseUrl: "http://localhost:4000",
 		})
+		expect(getModels).toHaveBeenCalledWith({
+			provider: "lmstudio",
+			baseUrl: "http://localhost:1234",
+		})
 
 		// Verify response was sent
 		expect(mockPostMessage).toHaveBeenCalledWith({
@@ -2415,7 +2421,7 @@ describe("ClineProvider - Router Models", () => {
 				unbound: mockModels,
 				litellm: mockModels,
 				ollama: {},
-				lmstudio: {},
+				lmstudio: mockModels,
 			},
 		})
 	})
@@ -2432,6 +2438,7 @@ describe("ClineProvider - Router Models", () => {
 				unboundApiKey: "unbound-key",
 				litellmApiKey: "litellm-key",
 				litellmBaseUrl: "http://localhost:4000",
+				lmStudioBaseUrl: "http://localhost:1234",
 			},
 		} as any)
 
@@ -2447,6 +2454,7 @@ describe("ClineProvider - Router Models", () => {
 			.mockResolvedValueOnce(mockModels) // glama success
 			.mockRejectedValueOnce(new Error("Unbound API error")) // unbound fail
 			.mockRejectedValueOnce(new Error("LiteLLM connection failed")) // litellm fail
+			.mockRejectedValueOnce(new Error("LMStudio API error")) // lmstudio fail
 
 		await messageHandler({ type: "requestRouterModels" })
 
@@ -2492,6 +2500,13 @@ describe("ClineProvider - Router Models", () => {
 			error: "LiteLLM connection failed",
 			values: { provider: "litellm" },
 		})
+
+		expect(mockPostMessage).toHaveBeenCalledWith({
+			type: "singleRouterModelFetchResponse",
+			success: false,
+			error: "LMStudio API error",
+			values: { provider: "lmstudio" },
+		})
 	})
 
 	test("handles requestRouterModels with LiteLLM values from message", async () => {
@@ -2570,7 +2585,7 @@ describe("ClineProvider - Router Models", () => {
 				unbound: mockModels,
 				litellm: {},
 				ollama: {},
-				lmstudio: {},
+				lmstudio: mockModels,
 			},
 		})
 	})

src/core/webview/__tests__/ClineProvider.spec.ts

@@ -105,6 +105,7 @@ describe("webviewMessageHandler - requestRouterModels", () => {
 				unboundApiKey: "unbound-key",
 				litellmApiKey: "litellm-key",
 				litellmBaseUrl: "http://localhost:4000",
+				lmStudioBaseUrl: "http://localhost:1234",
 			},
 		})
 	})
@@ -141,6 +142,10 @@ describe("webviewMessageHandler - requestRouterModels", () => {
 			apiKey: "litellm-key",
 			baseUrl: "http://localhost:4000",
 		})
+		expect(mockGetModels).toHaveBeenCalledWith({
+			provider: "lmstudio",
+			baseUrl: "http://localhost:1234",
+		})
 
 		// Verify response was sent
 		expect(mockClineProvider.postMessageToWebview).toHaveBeenCalledWith({
@@ -152,7 +157,7 @@ describe("webviewMessageHandler - requestRouterModels", () => {
 				unbound: mockModels,
 				litellm: mockModels,
 				ollama: {},
-				lmstudio: {},
+				lmstudio: mockModels,
 			},
 		})
 	})
@@ -239,7 +244,7 @@ describe("webviewMessageHandler - requestRouterModels", () => {
 				unbound: mockModels,
 				litellm: {},
 				ollama: {},
-				lmstudio: {},
+				lmstudio: mockModels,
 			},
 		})
 	})
@@ -261,6 +266,7 @@ describe("webviewMessageHandler - requestRouterModels", () => {
 			.mockResolvedValueOnce(mockModels) // glama
 			.mockRejectedValueOnce(new Error("Unbound API error")) // unbound
 			.mockRejectedValueOnce(new Error("LiteLLM connection failed")) // litellm
+			.mockRejectedValueOnce(new Error("LMStudio API error")) // lmstudio"))
 
 		await webviewMessageHandler(mockClineProvider, {
 			type: "requestRouterModels",
@@ -311,6 +317,7 @@ describe("webviewMessageHandler - requestRouterModels", () => {
 			.mockRejectedValueOnce(new Error("Glama API error")) // glama
 			.mockRejectedValueOnce(new Error("Unbound API error")) // unbound
 			.mockRejectedValueOnce(new Error("LiteLLM connection failed")) // litellm
+			.mockRejectedValueOnce(new Error("LMStudio API error")) // lmstudio
 
 		await webviewMessageHandler(mockClineProvider, {
 			type: "requestRouterModels",
@@ -351,6 +358,13 @@ describe("webviewMessageHandler - requestRouterModels", () => {
 			error: "LiteLLM connection failed",
 			values: { provider: "litellm" },
 		})
+
+		expect(mockClineProvider.postMessageToWebview).toHaveBeenCalledWith({
+			type: "singleRouterModelFetchResponse",
+			success: false,
+			error: "LMStudio API error",
+			values: { provider: "lmstudio" },
+		})
 	})
 
 	it("prefers config values over message values for LiteLLM", async () => {

src/core/webview/__tests__/webviewMessageHandler.spec.ts

@@ -568,9 +568,8 @@ export const webviewMessageHandler = async (
 
 			const fetchedRouterModels: Partial<Record<RouterName, ModelRecord>> = {
 				...routerModels,
-				// Initialize ollama and lmstudio with empty objects since they use separate handlers
+				// Initialize ollama with empty objects since it uses separate handlers
 				ollama: {},
-				lmstudio: {},
 			}
 
 			results.forEach((result, index) => {
@@ -579,18 +578,14 @@ export const webviewMessageHandler = async (
 				if (result.status === "fulfilled") {
 					fetchedRouterModels[routerName] = result.value.models
 
-					// Ollama and LM Studio settings pages still need these events
+					// Ollama settings pages still need these events
 					if (routerName === "ollama" && Object.keys(result.value.models).length > 0) {
 						provider.postMessageToWebview({
 							type: "ollamaModels",
 							ollamaModels: Object.keys(result.value.models),
 						})
-					} else if (routerName === "lmstudio" && Object.keys(result.value.models).length > 0) {
-						provider.postMessageToWebview({
-							type: "lmStudioModels",
-							lmStudioModels: Object.keys(result.value.models),
-						})
 					}
+					// LM Studio models have moved to main router models message
 				} else {
 					// Handle rejection: Post a specific error message for this provider
 					const errorMessage = result.reason instanceof Error ? result.reason.message : String(result.reason)