Skip to content

Commit 57977aa

Browse files
committed
Track all tab switches in posthog
1 parent 07f5f3f commit 57977aa

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

packages/telemetry/src/TelemetryService.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,11 @@ export class TelemetryService {
153153
}
154154

155155
/**
156-
* Captures when the ModesView settings UI is shown
156+
* Captures when a tab is shown due to user action
157+
* @param tab The tab that was shown
157158
*/
158-
public captureModesViewShown(): void {
159-
this.captureEvent(TelemetryEventName.MODE_SETTINGS_SHOWN)
159+
public captureTabShown(tab: string): void {
160+
this.captureEvent(TelemetryEventName.TAB_SHOWN, { tab })
160161
}
161162

162163
/**

packages/types/src/telemetry.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export enum TelemetryEventName {
3131
CHECKPOINT_RESTORED = "Checkpoint Restored",
3232
CHECKPOINT_DIFFED = "Checkpoint Diffed",
3333

34-
MODE_SETTINGS_SHOWN = "Mode Settings Shown",
34+
TAB_SHOWN = "Tab Shown",
3535
MODE_SETTINGS_CHANGED = "Mode Setting Changed",
3636
CUSTOM_MODE_CREATED = "Custom Mode Created",
3737

@@ -123,7 +123,7 @@ export const rooCodeTelemetryEventSchema = z.discriminatedUnion("type", [
123123
TelemetryEventName.CONSECUTIVE_MISTAKE_ERROR,
124124
TelemetryEventName.CONTEXT_CONDENSED,
125125
TelemetryEventName.SLIDING_WINDOW_TRUNCATION,
126-
TelemetryEventName.MODE_SETTINGS_SHOWN,
126+
TelemetryEventName.TAB_SHOWN,
127127
TelemetryEventName.MODE_SETTINGS_CHANGED,
128128
TelemetryEventName.CUSTOM_MODE_CREATED,
129129
]),

src/core/webview/webviewMessageHandler.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1703,9 +1703,9 @@ export const webviewMessageHandler = async (
17031703

17041704
case "switchTab": {
17051705
if (message.tab) {
1706-
// This could be more generic, but keeping it specific for now
1707-
if (message.tab === "modes" && TelemetryService.hasInstance()) {
1708-
TelemetryService.instance.captureModesViewShown()
1706+
// Capture tab shown event for all switchTab messages (which are user-initiated)
1707+
if (TelemetryService.hasInstance()) {
1708+
TelemetryService.instance.captureTabShown(message.tab)
17091709
}
17101710

17111711
await provider.postMessageToWebview({ type: "action", action: "switchTab", tab: message.tab })

0 commit comments

Comments
 (0)