Settings changes

playcations · playcations · commit 5967a60329e4 · 2025-07-04T10:27:36.000-04:00
Removed the virtualization settings for FilesChangedOverview
diff --git a/packages/types/src/global-settings.ts b/packages/types/src/global-settings.ts
@@ -106,7 +106,6 @@ export const globalSettingsSchema = z.object({
 	profileThresholds: z.record(z.string(), z.number()).optional(),
 	hasOpenedModeSelector: z.boolean().optional(),
 	filesChangedEnabled: z.boolean().optional(),
-	filesChangedMaxDisplayFiles: z.number().optional(),
 })
 
 export type GlobalSettings = z.infer<typeof globalSettingsSchema>
diff --git a/src/core/webview/ClineProvider.ts b/src/core/webview/ClineProvider.ts
@@ -1694,7 +1694,6 @@ export class ClineProvider
 		} = await this.getState()
 
 		const filesChangedEnabled = this.getGlobalState("filesChangedEnabled")
-		const filesChangedMaxDisplayFiles = this.getGlobalState("filesChangedMaxDisplayFiles")
 
 		const telemetryKey = process.env.POSTHOG_API_KEY
 		const machineId = vscode.env.machineId
@@ -1805,7 +1804,6 @@ export class ClineProvider
 			cloudApiUrl: getRooCodeApiUrl(),
 			hasOpenedModeSelector: this.getGlobalState("hasOpenedModeSelector") ?? false,
 			filesChangedEnabled: this.getGlobalState("filesChangedEnabled") ?? true,
-			filesChangedMaxDisplayFiles: this.getGlobalState("filesChangedMaxDisplayFiles") ?? 50,
 		}
 	}
 
diff --git a/src/core/webview/__tests__/ClineProvider.spec.ts b/src/core/webview/__tests__/ClineProvider.spec.ts
@@ -540,7 +540,6 @@ describe("ClineProvider", () => {
 			profileThresholds: {},
 			hasOpenedModeSelector: false,
 			filesChangedEnabled: true,
-			filesChangedMaxDisplayFiles: 50,
 		}
 
 		const message: ExtensionMessage = {
diff --git a/src/core/webview/webviewMessageHandler.ts b/src/core/webview/webviewMessageHandler.ts
@@ -962,7 +962,6 @@ export const webviewMessageHandler = async (
 					customModePrompts: updatedPrompts,
 					hasOpenedModeSelector: currentState.hasOpenedModeSelector ?? false,
 					filesChangedEnabled: currentState.filesChangedEnabled ?? true,
-					filesChangedMaxDisplayFiles: currentState.filesChangedMaxDisplayFiles ?? 50,
 				}
 				provider.postMessageToWebview({ type: "state", state: stateWithPrompts })
 
diff --git a/src/package.json b/src/package.json
@@ -344,13 +344,6 @@
 					"type": "boolean",
 					"default": true,
 					"description": "%settings.filesChangedEnabled.description%"
-				},
-				"roo-cline.filesChangedMaxDisplayFiles": {
-					"type": "number",
-					"default": 50,
-					"minimum": 10,
-					"maximum": 200,
-					"description": "%settings.filesChangedMaxDisplayFiles.description%"
 				}
 			}
 		}
diff --git a/src/package.nls.json b/src/package.nls.json
@@ -33,6 +33,5 @@
 	"settings.customStoragePath.description": "Custom storage path. Leave empty to use the default location. Supports absolute paths (e.g. 'D:\\RooCodeStorage')",
 	"settings.enableCodeActions.description": "Enable Roo Code quick fixes",
 	"settings.autoImportSettingsPath.description": "Path to a RooCode configuration file to automatically import on extension startup. Supports absolute paths and paths relative to the home directory (e.g. '~/Documents/roo-code-settings.json'). Leave empty to disable auto-import.",
-	"settings.filesChangedEnabled.description": "Show an overview of files modified by the AI during conversation",
-	"settings.filesChangedMaxDisplayFiles.description": "Maximum number of files to display before enabling virtualization for performance (10-200)"
+	"settings.filesChangedEnabled.description": "Show an overview of files modified by the AI during conversation"
 }
diff --git a/src/shared/ExtensionMessage.ts b/src/shared/ExtensionMessage.ts
@@ -273,7 +273,6 @@ export type ExtensionState = Pick<
 	profileThresholds: Record<string, number>
 	hasOpenedModeSelector: boolean
 	filesChangedEnabled: boolean
-	filesChangedMaxDisplayFiles: number
 }
 
 export interface ClineSayTool {
diff --git a/src/shared/WebviewMessage.ts b/src/shared/WebviewMessage.ts
@@ -181,7 +181,6 @@ export interface WebviewMessage {
 		| "switchTab"
 		| "shareTaskSuccess"
 		| "filesChangedEnabled"
-		| "filesChangedMaxDisplayFiles"
 	text?: string
 	tab?: "settings" | "history" | "mcp" | "modes" | "chat" | "marketplace" | "account"
 	disabled?: boolean
diff --git a/webview-ui/src/components/file-changes/FilesChangedOverview.tsx b/webview-ui/src/components/file-changes/FilesChangedOverview.tsx
@@ -32,12 +32,12 @@ const FilesChangedOverview: React.FC<FilesChangedOverviewProps> = ({
 	onRejectAll,
 }) => {
 	const { t } = useTranslation()
-	const { filesChangedEnabled, filesChangedMaxDisplayFiles } = useExtensionState()
+	const { filesChangedEnabled } = useExtensionState()
 	const files = changeset.files
 	const [isCollapsed, setIsCollapsed] = React.useState(true)
 
 	// Performance optimization: Use virtualization for large file lists
-	const VIRTUALIZATION_THRESHOLD = filesChangedMaxDisplayFiles || 50
+	const VIRTUALIZATION_THRESHOLD = 50
 	const ITEM_HEIGHT = 60 // Approximate height of each file item
 	const MAX_VISIBLE_ITEMS = 10
 	const [scrollTop, setScrollTop] = React.useState(0)
diff --git a/webview-ui/src/components/settings/InterfaceSettings.tsx b/webview-ui/src/components/settings/InterfaceSettings.tsx
@@ -6,21 +6,14 @@ import { Monitor } from "lucide-react"
 import { SetCachedStateField } from "./types"
 import { SectionHeader } from "./SectionHeader"
 import { Section } from "./Section"
-import { Slider } from "../ui"
 import { vscode } from "@/utils/vscode"
 
 type InterfaceSettingsProps = HTMLAttributes<HTMLDivElement> & {
 	filesChangedEnabled?: boolean
-	filesChangedMaxDisplayFiles?: number
-	setCachedStateField: SetCachedStateField<"filesChangedEnabled" | "filesChangedMaxDisplayFiles">
+	setCachedStateField: SetCachedStateField<"filesChangedEnabled">
 }
 
-export const InterfaceSettings = ({
-	filesChangedEnabled,
-	filesChangedMaxDisplayFiles,
-	setCachedStateField,
-	...props
-}: InterfaceSettingsProps) => {
+export const InterfaceSettings = ({ filesChangedEnabled, setCachedStateField, ...props }: InterfaceSettingsProps) => {
 	const { t } = useAppTranslation()
 
 	return (
@@ -57,32 +50,6 @@ export const InterfaceSettings = ({
 							{t("settings:interface.filesChanged.enabled.description")}
 						</div>
 					</div>
-
-					<div>
-						<span className="block font-medium mb-1">
-							{t("settings:interface.filesChanged.maxDisplayFiles.label")}
-						</span>
-						<div className="flex items-center gap-2">
-							<Slider
-								min={10}
-								max={200}
-								step={1}
-								value={[filesChangedMaxDisplayFiles ?? 50]}
-								onValueChange={([value]) => {
-									setCachedStateField("filesChangedMaxDisplayFiles", value)
-									vscode.postMessage({
-										type: "filesChangedMaxDisplayFiles",
-										value: value,
-									})
-								}}
-								data-testid="files-changed-max-display-files-slider"
-							/>
-							<span className="w-10">{filesChangedMaxDisplayFiles ?? 50}</span>
-						</div>
-						<div className="text-vscode-descriptionForeground text-sm mt-1">
-							{t("settings:interface.filesChanged.maxDisplayFiles.description")}
-						</div>
-					</div>
 				</div>
 			</Section>
 		</div>
diff --git a/webview-ui/src/components/settings/SettingsView.tsx b/webview-ui/src/components/settings/SettingsView.tsx
@@ -178,7 +178,6 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 		customSupportPrompts,
 		profileThresholds,
 		filesChangedEnabled,
-		filesChangedMaxDisplayFiles,
 	} = cachedState
 
 	const apiConfiguration = useMemo(() => cachedState.apiConfiguration ?? {}, [cachedState.apiConfiguration])
@@ -645,7 +644,6 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 					{activeTab === "interface" && (
 						<InterfaceSettings
 							filesChangedEnabled={filesChangedEnabled}
-							filesChangedMaxDisplayFiles={filesChangedMaxDisplayFiles}
 							setCachedStateField={setCachedStateField}
 						/>
 					)}
diff --git a/webview-ui/src/context/ExtensionStateContext.tsx b/webview-ui/src/context/ExtensionStateContext.tsx
@@ -129,8 +129,6 @@ export interface ExtensionStateContextType extends ExtensionState {
 	routerModels?: RouterModels
 	filesChangedEnabled: boolean
 	setFilesChangedEnabled: (value: boolean) => void
-	filesChangedMaxDisplayFiles: number
-	setFilesChangedMaxDisplayFiles: (value: number) => void
 }
 
 export const ExtensionStateContext = createContext<ExtensionStateContextType | undefined>(undefined)
@@ -222,7 +220,6 @@ export const ExtensionStateContextProvider: React.FC<{ children: React.ReactNode
 		},
 		codebaseIndexModels: { ollama: {}, openai: {} },
 		filesChangedEnabled: true,
-		filesChangedMaxDisplayFiles: 50,
 	})
 
 	const [didHydrateState, setDidHydrateState] = useState(false)
@@ -461,8 +458,6 @@ export const ExtensionStateContextProvider: React.FC<{ children: React.ReactNode
 		setProfileThresholds: (value) => setState((prevState) => ({ ...prevState, profileThresholds: value })),
 		setFilesChangedEnabled: (value: boolean) =>
 			setState((prevState) => ({ ...prevState, filesChangedEnabled: value })),
-		setFilesChangedMaxDisplayFiles: (value: number) =>
-			setState((prevState) => ({ ...prevState, filesChangedMaxDisplayFiles: value })),
 	}
 
 	return <ExtensionStateContext.Provider value={contextValue}>{children}</ExtensionStateContext.Provider>
diff --git a/webview-ui/src/context/__tests__/ExtensionStateContext.spec.tsx b/webview-ui/src/context/__tests__/ExtensionStateContext.spec.tsx
@@ -210,7 +210,6 @@ describe("mergeExtensionState", () => {
 			profileThresholds: {},
 			hasOpenedModeSelector: false, // Add the new required property
 			filesChangedEnabled: true,
-			filesChangedMaxDisplayFiles: 50,
 		}
 
 		const prevState: ExtensionState = {
diff --git a/webview-ui/src/i18n/locales/en/settings.json b/webview-ui/src/i18n/locales/en/settings.json
@@ -418,10 +418,6 @@
 			"enabled": {
 				"label": "Show files changed overview",
 				"description": "Display an overview of files modified by the AI during conversation. When disabled, the files changed section will be hidden from the interface."
-			},
-			"maxDisplayFiles": {
-				"label": "Virtualization threshold",
-				"description": "Maximum number of files to display before enabling virtualization for performance. Higher values show more files at once but may impact performance with large file sets."
 			}
 		}
 	},

Original file line number	Diff line number	Diff line change
`@@ -1694,7 +1694,6 @@ export class ClineProvider`
`1694`	`1694`	`} = await this.getState()`
`1695`	`1695`
`1696`	`1696`	`const filesChangedEnabled = this.getGlobalState("filesChangedEnabled")`
`1697`		`- const filesChangedMaxDisplayFiles = this.getGlobalState("filesChangedMaxDisplayFiles")`
`1698`	`1697`
`1699`	`1698`	`const telemetryKey = process.env.POSTHOG_API_KEY`
`1700`	`1699`	`const machineId = vscode.env.machineId`
`@@ -1805,7 +1804,6 @@ export class ClineProvider`
`1805`	`1804`	`cloudApiUrl: getRooCodeApiUrl(),`
`1806`	`1805`	`hasOpenedModeSelector: this.getGlobalState("hasOpenedModeSelector") ?? false,`
`1807`	`1806`	`filesChangedEnabled: this.getGlobalState("filesChangedEnabled") ?? true,`
`1808`		`- filesChangedMaxDisplayFiles: this.getGlobalState("filesChangedMaxDisplayFiles") ?? 50,`
`1809`	`1807`	`}`
`1810`	`1808`	`}`
`1811`	`1809`
Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,6 @@ describe("ClineProvider", () => {`
`540`	`540`	`profileThresholds: {},`
`541`	`541`	`hasOpenedModeSelector: false,`
`542`	`542`	`filesChangedEnabled: true,`
`543`		`- filesChangedMaxDisplayFiles: 50,`
`544`	`543`	`}`
`545`	`544`
`546`	`545`	`const message: ExtensionMessage = {`
Original file line number	Diff line number	Diff line change
`@@ -962,7 +962,6 @@ export const webviewMessageHandler = async (`
`962`	`962`	`customModePrompts: updatedPrompts,`
`963`	`963`	`hasOpenedModeSelector: currentState.hasOpenedModeSelector ?? false,`
`964`	`964`	`filesChangedEnabled: currentState.filesChangedEnabled ?? true,`
`965`		`- filesChangedMaxDisplayFiles: currentState.filesChangedMaxDisplayFiles ?? 50,`
`966`	`965`	`}`
`967`	`966`	`provider.postMessageToWebview({ type: "state", state: stateWithPrompts })`
`968`	`967`
Original file line number	Diff line number	Diff line change
`@@ -344,13 +344,6 @@`
`344`	`344`	`"type": "boolean",`
`345`	`345`	`"default": true,`
`346`	`346`	`"description": "%settings.filesChangedEnabled.description%"`
`347`		`- },`
`348`		`- "roo-cline.filesChangedMaxDisplayFiles": {`
`349`		`- "type": "number",`
`350`		`- "default": 50,`
`351`		`- "minimum": 10,`
`352`		`- "maximum": 200,`
`353`		`- "description": "%settings.filesChangedMaxDisplayFiles.description%"`
`354`	`347`	`}`
`355`	`348`	`}`
`356`	`349`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,5 @@`
`33`	`33`	`"settings.customStoragePath.description": "Custom storage path. Leave empty to use the default location. Supports absolute paths (e.g. 'D:\\RooCodeStorage')",`
`34`	`34`	`"settings.enableCodeActions.description": "Enable Roo Code quick fixes",`
`35`	`35`	`"settings.autoImportSettingsPath.description": "Path to a RooCode configuration file to automatically import on extension startup. Supports absolute paths and paths relative to the home directory (e.g. '~/Documents/roo-code-settings.json'). Leave empty to disable auto-import.",`
`36`		`- "settings.filesChangedEnabled.description": "Show an overview of files modified by the AI during conversation",`
`37`		`- "settings.filesChangedMaxDisplayFiles.description": "Maximum number of files to display before enabling virtualization for performance (10-200)"`
	`36`	`+ "settings.filesChangedEnabled.description": "Show an overview of files modified by the AI during conversation"`
`38`	`37`	`}`
Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,6 @@ export type ExtensionState = Pick<`
`273`	`273`	`profileThresholds: Record<string, number>`
`274`	`274`	`hasOpenedModeSelector: boolean`
`275`	`275`	`filesChangedEnabled: boolean`
`276`		`- filesChangedMaxDisplayFiles: number`
`277`	`276`	`}`
`278`	`277`
`279`	`278`	`export interface ClineSayTool {`