Skip to content

Commit 5a2f2ea

Browse files
committed
Revert "Fix settings done button with unsaved changes"
This reverts commit e69f27d.
1 parent 6ae11dd commit 5a2f2ea

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

.changeset/twenty-rice-own.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

webview-ui/src/components/settings/SettingsView.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone },
173173
text: currentApiConfigName,
174174
apiConfiguration,
175175
})
176+
// onDone()
176177
setChangeDetected(false)
177178
}
178179
}
@@ -216,11 +217,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone },
216217

217218
const onConfirmDialogResult = useCallback((confirm: boolean) => {
218219
if (confirm) {
219-
setChangeDetected(false)
220-
// Wait for the change detection to be updated
221-
setTimeout(() => {
222-
confirmDialogHandler.current?.()
223-
}, 100)
220+
confirmDialogHandler.current?.()
224221
}
225222
}, [])
226223

0 commit comments

Comments
 (0)