fix(image-uris): broaden Unix path regex to include common Linux roots

daniel-lxs · daniel-lxs · commit 5d3f45bec057 · 2025-10-27T20:46:27.000-05:00
Use /^[^?#]*\/(?:Users|home|root|var|tmp|opt)\/[^?#]{1,300}\.(png|jpg|jpeg|gif|webp)$/i to support Linux/macOS while keeping bounds and avoiding backtracking.
diff --git a/src/integrations/misc/imageDataUrl.ts b/src/integrations/misc/imageDataUrl.ts
@@ -85,7 +85,7 @@ function webviewUriToFilePath(webviewUri: string): string {
 			// Use specific, bounded patterns to prevent ReDoS
 			// Match exact patterns without backtracking
 			const unixMatch = decoded.match(
-				/^[^?#]*\/Users\/[a-zA-Z0-9._-]{1,50}\/[^?#]{1,300}\.(png|jpg|jpeg|gif|webp)$/i,
+				/^[^?#]*\/(?:Users|home|root|var|tmp|opt)\/[^?#]{1,300}\.(png|jpg|jpeg|gif|webp)$/i,
 			)
 			if (unixMatch) {
 				return unixMatch[0]

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ function webviewUriToFilePath(webviewUri: string): string {`
`85`	`85`	`// Use specific, bounded patterns to prevent ReDoS`
`86`	`86`	`// Match exact patterns without backtracking`
`87`	`87`	`const unixMatch = decoded.match(`
`88`		`- /^[^?#]*\/Users\/[a-zA-Z0-9._-]{1,50}\/[^?#]{1,300}\.(png\|jpg\|jpeg\|gif\|webp)$/i,`
	`88`	`+ /^[^?#]*\/(?:Users\|home\|root\|var\|tmp\|opt)\/[^?#]{1,300}\.(png\|jpg\|jpeg\|gif\|webp)$/i,`
`89`	`89`	`)`
`90`	`90`	`if (unixMatch) {`
`91`	`91`	`return unixMatch[0]`