fix: replace implicit coercions with explicit boolean checks

Replace implicit boolean coercions (git diff --staged | catvariable) with explicit type-aware checks
to satisfy the no-implicit-coercion ESLint rule. Also add debug logging to
empty blocks to satisfy the no-empty rule.

- Use type-specific checks (typeof x === 'string') for string variables
- Use explicit comparisons (x === true) for boolean variables
- Remove redundant null checks for variables that can't be null
- Add console.debug statements to empty catch blocks

Signed-off-by: Eric Wheeler <[email protected]>

Author: Eric Wheeler

src/api/providers/__tests__/openai.spec.ts

@@ -174,6 +174,7 @@ describe("OpenAiHandler", () => {
 			const stream = reasoningHandler.createMessage(systemPrompt, messages)
 			// Consume the stream to trigger the API call
 			for await (const _chunk of stream) {
+				console.debug("Consuming stream for reasoning test")
 			}
 			// Assert the mockCreate was called with reasoning_effort
 			expect(mockCreate).toHaveBeenCalled()
@@ -191,6 +192,7 @@ describe("OpenAiHandler", () => {
 			const stream = noReasoningHandler.createMessage(systemPrompt, messages)
 			// Consume the stream to trigger the API call
 			for await (const _chunk of stream) {
+				console.debug("Consuming stream for no-reasoning test")
 			}
 			// Assert the mockCreate was called without reasoning_effort
 			expect(mockCreate).toHaveBeenCalled()

src/api/providers/vscode-lm.ts

@@ -291,7 +291,7 @@ export class VsCodeLmHandler extends BaseProvider implements SingleCompletionHan
 		if (!this.client) {
 			console.debug("Roo Code <Language Model API>: Getting client with options:", {
 				vsCodeLmModelSelector: this.options.vsCodeLmModelSelector,
-				hasOptions: !!this.options,
+				hasOptions: true, // this.options is guaranteed to be an ApiHandlerOptions object
 				selectorKeys: this.options.vsCodeLmModelSelector ? Object.keys(this.options.vsCodeLmModelSelector) : [],
 			})
 

src/core/condense/index.ts

@@ -93,8 +93,8 @@ export async function summarizeConversation(
 	TelemetryService.instance.captureContextCondensed(
 		taskId,
 		isAutomaticTrigger ?? false,
-		!!customCondensingPrompt?.trim(),
-		!!condensingApiHandler,
+		typeof customCondensingPrompt === "string" && customCondensingPrompt.trim() !== "",
+		condensingApiHandler !== undefined,
 	)
 
 	const response: SummarizeResponse = { messages, cost: 0, summary: "" }

src/core/config/ContextProxy.ts

@@ -205,7 +205,7 @@ export class ContextProxy {
 
 		await this.setValues({
 			...PROVIDER_SETTINGS_KEYS.filter((key) => !isSecretStateKey(key))
-				.filter((key) => !!this.stateCache[key])
+				.filter((key) => this.stateCache[key] != null)
 				.reduce((acc, key) => ({ ...acc, [key]: undefined }), {} as ProviderSettings),
 			...values,
 		})

src/core/config/importExport.ts

@@ -117,5 +117,7 @@ export const exportSettings = async ({ providerSettingsManager, contextProxy }:
 		const dirname = path.dirname(uri.fsPath)
 		await fs.mkdir(dirname, { recursive: true })
 		await fs.writeFile(uri.fsPath, JSON.stringify({ providerProfiles, globalSettings }, null, 2), "utf-8")
-	} catch (e) {}
+	} catch (e) {
+		console.debug("Error exporting settings:", e)
+	}
 }

src/core/tools/executeCommandTool.ts

@@ -171,7 +171,9 @@ export async function executeCommand(
 					message = { text, images }
 					process.continue()
 				}
-			} catch (_error) {}
+			} catch (_error) {
+				console.debug("Error in onWillRespond:", _error)
+			}
 		},
 		onCompleted: (output: string | undefined) => {
 			result = Terminal.compressTerminalOutput(output ?? "", terminalOutputLineLimit)
@@ -197,7 +199,12 @@ export async function executeCommand(
 		}
 	}
 
-	const terminal = await TerminalRegistry.getOrCreateTerminal(workingDir, !!customCwd, cline.taskId, terminalProvider)
+	const terminal = await TerminalRegistry.getOrCreateTerminal(
+		workingDir,
+		typeof customCwd === "string" && customCwd !== "",
+		cline.taskId,
+		terminalProvider,
+	)
 
 	if (terminal instanceof Terminal) {
 		terminal.terminal.show(true)

src/core/tools/writeToFileTool.ts

@@ -123,7 +123,7 @@ export async function writeToFileTool(
 				const isNewFile = !fileExists
 
 				// Check if diffStrategy is enabled
-				const diffStrategyEnabled = !!cline.diffStrategy
+				const diffStrategyEnabled = cline.diffStrategy !== undefined
 
 				// Use more specific error message for line_count that provides guidance based on the situation
 				await cline.say(

src/core/webview/ClineProvider.ts

@@ -825,7 +825,7 @@ export class ClineProvider
 	}
 
 	public hasProviderProfileEntry(name: string): boolean {
-		return !!this.getProviderProfileEntry(name)
+		return this.getProviderProfileEntry(name) !== undefined
 	}
 
 	async upsertProviderProfile(
@@ -1656,7 +1656,7 @@ export class ClineProvider
 			apiProvider: apiConfiguration?.apiProvider,
 			modelId: task?.api?.getModel().id,
 			diffStrategy: task?.diffStrategy?.getName(),
-			isSubtask: task ? !!task.parentTask : undefined,
+			isSubtask: task ? task.parentTask !== undefined : undefined,
 		}
 	}
 }

src/core/webview/webviewMessageHandler.ts

@@ -629,7 +629,7 @@ export const webviewMessageHandler = async (provider: ClineProvider, message: We
 					// Send the result back to the webview
 					await provider.postMessageToWebview({
 						type: "browserConnectionResult",
-						success: !!chromeHostUrl,
+						success: typeof chromeHostUrl === "string" && chromeHostUrl !== "",
 						text: `Auto-discovered and tested connection to Chrome: ${chromeHostUrl}`,
 						values: { endpoint: chromeHostUrl },
 					})
@@ -1008,7 +1008,10 @@ export const webviewMessageHandler = async (provider: ClineProvider, message: We
 					// Try to get enhancement config first, fall back to current config.
 					let configToUse: ProviderSettings = apiConfiguration
 
-					if (enhancementApiConfigId && !!listApiConfigMeta.find(({ id }) => id === enhancementApiConfigId)) {
+					if (
+						enhancementApiConfigId &&
+						listApiConfigMeta.find(({ id }) => id === enhancementApiConfigId) !== undefined
+					) {
 						const { name: _, ...providerSettings } = await provider.providerSettingsManager.getProfile({
 							id: enhancementApiConfigId,
 						})

src/integrations/misc/open-file.ts

@@ -138,7 +138,9 @@ export async function openFile(filePath: string, options: OpenFileOptions = {})
 					break
 				}
 			}
-		} catch {} // not essential, sometimes tab operations fail
+		} catch (e) {
+			console.debug("Error processing tab operations:", e)
+		} // not essential, sometimes tab operations fail
 
 		const document = await vscode.workspace.openTextDocument(uriToProcess)
 		const selection =