refactor: rename .roo/roo_modes to .roo/modes for cleaner directory structure

- Changed ROO_MODES_DIR constant from "roo_modes" to "modes"
- Updated all references in CustomModesManager.ts
- Updated all test descriptions and mocks in CustomModesManager.spec.ts
- All tests passing successfully

Author: roomote

src/core/config/CustomModesManager.ts

@@ -17,7 +17,7 @@ import { ensureSettingsDirectoryExists } from "../../utils/globalContext"
 import { t } from "../../i18n"
 
 const ROOMODES_FILENAME = ".roomodes"
-const ROO_MODES_DIR = "roo_modes"
+const ROO_MODES_DIR = "modes"
 
 // Type definitions for import/export functionality
 interface RuleFile {
@@ -323,7 +323,7 @@ export class CustomModesManager {
 		this.disposables.push(settingsWatcher.onDidDelete(handleModeFileChange))
 		this.disposables.push(settingsWatcher)
 
-		// Watch global .roo/roo_modes directory
+		// Watch global .roo/modes directory
 		const globalRooModesDir = path.join(getGlobalRooDirectory(), ROO_MODES_DIR)
 		const globalRooModesPattern = path.join(globalRooModesDir, "*.{yaml,yml}")
 		const globalRooModesWatcher = vscode.workspace.createFileSystemWatcher(globalRooModesPattern)
@@ -332,7 +332,7 @@ export class CustomModesManager {
 		this.disposables.push(globalRooModesWatcher.onDidDelete(handleModeFileChange))
 		this.disposables.push(globalRooModesWatcher)
 
-		// Watch .roomodes file and project .roo/roo_modes directory if workspace exists
+		// Watch .roomodes file and project .roo/modes directory if workspace exists
 		const workspaceFolders = vscode.workspace.workspaceFolders
 		if (workspaceFolders && workspaceFolders.length > 0) {
 			const workspaceRoot = getWorkspacePath()
@@ -345,7 +345,7 @@ export class CustomModesManager {
 			this.disposables.push(roomodesWatcher.onDidDelete(handleModeFileChange))
 			this.disposables.push(roomodesWatcher)
 
-			// Watch project .roo/roo_modes directory
+			// Watch project .roo/modes directory
 			const projectRooModesDir = path.join(workspaceRoot, ".roo", ROO_MODES_DIR)
 			const projectRooModesPattern = path.join(projectRooModesDir, "*.{yaml,yml}")
 			const projectRooModesWatcher = vscode.workspace.createFileSystemWatcher(projectRooModesPattern)
@@ -368,15 +368,15 @@ export class CustomModesManager {
 		const settingsPath = await this.getCustomModesFilePath()
 		const settingsModes = await this.loadModesFromFile(settingsPath, "global")
 
-		// Get modes from .roo/roo_modes directories (both global and project)
+		// Get modes from .roo/modes directories (both global and project)
 		const allRooModesDirModes: ModeConfig[] = []
 
-		// Load from global .roo/roo_modes
+		// Load from global .roo/modes
 		const globalRooModesDir = path.join(getGlobalRooDirectory(), ROO_MODES_DIR)
 		const globalRooModesDirModes = await this.loadModesFromDirectory(globalRooModesDir, "global")
 		allRooModesDirModes.push(...globalRooModesDirModes)
 
-		// Load from project .roo/roo_modes if workspace exists
+		// Load from project .roo/modes if workspace exists
 		const workspacePath = getWorkspacePath()
 		if (workspacePath) {
 			const projectRooModesDir = path.join(workspacePath, ".roo", ROO_MODES_DIR)
@@ -390,9 +390,9 @@ export class CustomModesManager {
 
 		// Create a map to store modes with proper precedence
 		// Precedence order (highest to lowest):
-		// 1. .roo/roo_modes (project)
+		// 1. .roo/modes (project)
 		// 2. .roomodes (project)
-		// 3. .roo/roo_modes (global)
+		// 3. .roo/modes (global)
 		// 4. settings file (global)
 		const modesMap = new Map<string, ModeConfig>()
 
@@ -402,7 +402,7 @@ export class CustomModesManager {
 			modesMap.set(mode.slug, mode)
 		}
 
-		// 3. Global .roo/roo_modes
+		// 3. Global .roo/modes
 		for (const mode of globalRooModesDirModes) {
 			modesMap.set(mode.slug, mode)
 		}
@@ -412,7 +412,7 @@ export class CustomModesManager {
 			modesMap.set(mode.slug, mode)
 		}
 
-		// 1. Project .roo/roo_modes (highest precedence)
+		// 1. Project .roo/modes (highest precedence)
 		for (const mode of allRooModesDirModes.filter((m) => m.source === "project")) {
 			modesMap.set(mode.slug, mode)
 		}
@@ -586,7 +586,7 @@ export class CustomModesManager {
 						}
 					}
 
-					// Check and delete from .roo/roo_modes directories
+					// Check and delete from .roo/modes directories
 					const rooDirectories = getRooDirectoriesForCwd(getWorkspacePath() || process.cwd())
 					for (const rooDir of rooDirectories) {
 						const rooModesDir = path.join(rooDir, ROO_MODES_DIR)

src/core/config/__tests__/CustomModesManager.spec.ts

@@ -114,17 +114,17 @@ describe("CustomModesManager", () => {
 			expect(modes).toHaveLength(2)
 		})
 
-		it("should load modes from .roo/roo_modes directory", async () => {
+		it("should load modes from .roo/modes directory", async () => {
 			const settingsModes = [{ slug: "mode1", name: "Mode 1", roleDefinition: "Role 1", groups: ["read"] }]
 			const rooModesMode1 = { slug: "mode2", name: "Mode 2", roleDefinition: "Role 2", groups: ["read"] }
 			const rooModesMode2 = { slug: "mode3", name: "Mode 3", roleDefinition: "Role 3", groups: ["edit"] }
 
 			;(fileExistsAtPath as Mock).mockImplementation(async (path: string) => {
-				// Return true for settings path and roo_modes directories
-				return path === mockSettingsPath || path.includes("roo_modes") || path === mockRoomodes
+				// Return true for settings path and modes directories
+				return path === mockSettingsPath || path.includes("modes") || path === mockRoomodes
 			})
 			;(fs.readdir as Mock).mockImplementation(async (path: string) => {
-				if (path.includes("roo_modes")) {
+				if (path.includes("modes")) {
 					return [
 						{ name: "mode1.yaml", isFile: () => true },
 						{ name: "mode2.yml", isFile: () => true },
@@ -155,7 +155,7 @@ describe("CustomModesManager", () => {
 			expect(modes.map((m) => m.slug)).toContain("mode3")
 		})
 
-		it("should respect precedence: project .roo/roo_modes > .roomodes > global .roo/roo_modes > settings", async () => {
+		it("should respect precedence: project .roo/modes > .roomodes > global .roo/modes > settings", async () => {
 			const settingsMode = { slug: "test", name: "Settings", roleDefinition: "Settings Role", groups: ["read"] }
 			const globalRooMode = {
 				slug: "test",
@@ -175,7 +175,7 @@ describe("CustomModesManager", () => {
 				return true // All paths exist
 			})
 			;(fs.readdir as Mock).mockImplementation(async (path: string) => {
-				if (path.includes("roo_modes")) {
+				if (path.includes("modes")) {
 					return [{ name: "test.yaml", isFile: () => true }]
 				}
 				return []
@@ -187,12 +187,12 @@ describe("CustomModesManager", () => {
 				if (path === mockRoomodes) {
 					return yaml.stringify({ customModes: [roomodesMode] })
 				}
-				// Global .roo/roo_modes
-				if (path.includes("roo_modes") && !path.includes(mockWorkspacePath)) {
+				// Global .roo/modes
+				if (path.includes("modes") && !path.includes(mockWorkspacePath)) {
 					return yaml.stringify({ customModes: [globalRooMode] })
 				}
-				// Project .roo/roo_modes
-				if (path.includes("roo_modes") && path.includes(mockWorkspacePath)) {
+				// Project .roo/modes
+				if (path.includes("modes") && path.includes(mockWorkspacePath)) {
 					return yaml.stringify({ customModes: [projectRooMode] })
 				}
 				throw new Error("File not found")
@@ -202,16 +202,16 @@ describe("CustomModesManager", () => {
 
 			// Should have only one mode with the slug "test"
 			expect(modes).toHaveLength(1)
-			// Project .roo/roo_modes should take precedence
+			// Project .roo/modes should take precedence
 			expect(modes[0].name).toBe("Project Roo")
 			expect(modes[0].roleDefinition).toBe("Project Roo Role")
 		})
 
-		it("should handle empty .roo/roo_modes directory", async () => {
+		it("should handle empty .roo/modes directory", async () => {
 			const settingsModes = [{ slug: "mode1", name: "Mode 1", roleDefinition: "Role 1", groups: ["read"] }]
 
 			;(fileExistsAtPath as Mock).mockImplementation(async (path: string) => {
-				return path === mockSettingsPath || path.includes("roo_modes")
+				return path === mockSettingsPath || path.includes("modes")
 			})
 			;(fs.readdir as Mock).mockImplementation(async () => {
 				return [] // Empty directory
@@ -230,12 +230,12 @@ describe("CustomModesManager", () => {
 			expect(modes[0].slug).toBe("mode1")
 		})
 
-		it("should handle non-existent .roo/roo_modes directory", async () => {
+		it("should handle non-existent .roo/modes directory", async () => {
 			const settingsModes = [{ slug: "mode1", name: "Mode 1", roleDefinition: "Role 1", groups: ["read"] }]
 
 			;(fileExistsAtPath as Mock).mockImplementation(async (path: string) => {
-				// roo_modes directories don't exist
-				if (path.includes("roo_modes")) {
+				// modes directories don't exist
+				if (path.includes("modes")) {
 					return false
 				}
 				return path === mockSettingsPath
@@ -254,14 +254,14 @@ describe("CustomModesManager", () => {
 			expect(modes[0].slug).toBe("mode1")
 		})
 
-		it("should preserve sourceFile property for modes loaded from .roo/roo_modes", async () => {
+		it("should preserve sourceFile property for modes loaded from .roo/modes", async () => {
 			const rooModesMode = { slug: "test", name: "Test Mode", roleDefinition: "Test Role", groups: ["read"] }
 
 			;(fileExistsAtPath as Mock).mockImplementation(async (path: string) => {
-				return path === mockSettingsPath || path.includes("roo_modes")
+				return path === mockSettingsPath || path.includes("modes")
 			})
 			;(fs.readdir as Mock).mockImplementation(async (path: string) => {
-				if (path.includes("roo_modes")) {
+				if (path.includes("modes")) {
 					return [{ name: "test.yaml", isFile: () => true }]
 				}
 				return []