cleanup: remove taskHistory from global state

Removed taskHistory field and all its references from the codebase as part
of migrating to file-based storage.

- Removed taskHistory from GlobalSettings schema
- Removed import of historyItemSchema
- Removed taskHistory from ExtensionState interface
- Cleared PASS_THROUGH_STATE_KEYS array in ContextProxy
- Updated ClineProvider to use file-based API instead of global state
- Updated UI components to work without taskHistory prop

Signed-off-by: Eric Wheeler <[email protected]>

Author: Eric Wheeler

packages/types/src/global-settings.ts

@@ -7,7 +7,6 @@ import {
 	providerSettingsEntrySchema,
 	providerSettingsSchema,
 } from "./provider-settings.js"
-import { historyItemSchema } from "./history.js"
 import { codebaseIndexModelsSchema, codebaseIndexConfigSchema } from "./codebase-index.js"
 import { experimentsSchema } from "./experiment.js"
 import { telemetrySettingsSchema } from "./telemetry.js"
@@ -26,8 +25,6 @@ export const globalSettingsSchema = z.object({
 
 	lastShownAnnouncementId: z.string().optional(),
 	customInstructions: z.string().optional(),
-	taskHistory: z.array(historyItemSchema).optional(),
-
 	condensingApiConfigId: z.string().optional(),
 	customCondensingPrompt: z.string().optional(),
 

src/core/config/ContextProxy.ts

@@ -23,12 +23,11 @@ type GlobalStateKey = keyof GlobalState
 type SecretStateKey = keyof SecretState
 type RooCodeSettingsKey = keyof RooCodeSettings
 
-const PASS_THROUGH_STATE_KEYS = ["taskHistory"]
+const PASS_THROUGH_STATE_KEYS: string[] = []
 
 export const isPassThroughStateKey = (key: string) => PASS_THROUGH_STATE_KEYS.includes(key)
 
 const globalSettingsExportSchema = globalSettingsSchema.omit({
-	taskHistory: true,
 	listApiConfigMeta: true,
 	currentApiConfigName: true,
 })

src/core/webview/ClineProvider.ts

@@ -46,6 +46,7 @@ import { Terminal } from "../../integrations/terminal/Terminal"
 import { downloadTask } from "../../integrations/misc/export-markdown"
 import { getTheme } from "../../integrations/theme/getTheme"
 import WorkspaceTracker from "../../integrations/workspace/WorkspaceTracker"
+import { getHistoryItem, setHistoryItems, deleteHistoryItem } from "../task-persistence/taskHistory"
 import { McpHub } from "../../services/mcp/McpHub"
 import { McpServerManager } from "../../services/mcp/McpServerManager"
 import { MarketplaceManager } from "../../services/marketplace"
@@ -1128,8 +1129,8 @@ export class ClineProvider
 		uiMessagesFilePath: string
 		apiConversationHistory: Anthropic.MessageParam[]
 	}> {
-		const history = this.getGlobalState("taskHistory") ?? []
-		const historyItem = history.find((item) => item.id === id)
+		// Get the history item from the file-based storage
+		const historyItem = await getHistoryItem(id)
 
 		if (historyItem) {
 			const { getTaskDirectoryPath } = await import("../../utils/storage")
@@ -1155,10 +1156,9 @@ export class ClineProvider
 			}
 		}
 
-		// if we tried to get a task that doesn't exist, remove it from state
-		// FIXME: this seems to happen sometimes when the json file doesnt save to disk for some reason
-		await this.deleteTaskFromState(id)
-		throw new Error("Task not found")
+		// If we tried to get a task that doesn't exist, delete it from storage
+		await deleteHistoryItem(id)
+		throw new Error(`Task not found, removed from index: ${id}`)
 	}
 
 	async showTaskWithId(id: string) {
@@ -1241,9 +1241,7 @@ export class ClineProvider
 	}
 
 	async deleteTaskFromState(id: string) {
-		const taskHistory = this.getGlobalState("taskHistory") ?? []
-		const updatedTaskHistory = taskHistory.filter((task) => task.id !== id)
-		await this.updateGlobalState("taskHistory", updatedTaskHistory)
+		await deleteHistoryItem(id)
 		await this.postStateToWebview()
 	}
 
@@ -1387,7 +1385,6 @@ export class ClineProvider
 			ttsSpeed,
 			diffEnabled,
 			enableCheckpoints,
-			taskHistory,
 			soundVolume,
 			browserViewportSize,
 			screenshotQuality,
@@ -1472,12 +1469,9 @@ export class ClineProvider
 			autoCondenseContextPercent: autoCondenseContextPercent ?? 100,
 			uriScheme: vscode.env.uriScheme,
 			currentTaskItem: this.getCurrentCline()?.taskId
-				? (taskHistory || []).find((item: HistoryItem) => item.id === this.getCurrentCline()?.taskId)
+				? await getHistoryItem(this.getCurrentCline()!.taskId)
 				: undefined,
 			clineMessages: this.getCurrentCline()?.clineMessages || [],
-			taskHistory: (taskHistory || [])
-				.filter((item: HistoryItem) => item.ts && item.task)
-				.sort((a: HistoryItem, b: HistoryItem) => b.ts - a.ts),
 			soundEnabled: soundEnabled ?? false,
 			ttsEnabled: ttsEnabled ?? false,
 			ttsSpeed: ttsSpeed ?? 1.0,
@@ -1645,7 +1639,6 @@ export class ClineProvider
 			allowedMaxRequests: stateValues.allowedMaxRequests,
 			autoCondenseContext: stateValues.autoCondenseContext ?? true,
 			autoCondenseContextPercent: stateValues.autoCondenseContextPercent ?? 100,
-			taskHistory: stateValues.taskHistory,
 			allowedCommands: stateValues.allowedCommands,
 			deniedCommands: stateValues.deniedCommands,
 			soundEnabled: stateValues.soundEnabled ?? false,
@@ -1725,17 +1718,11 @@ export class ClineProvider
 	}
 
 	async updateTaskHistory(item: HistoryItem): Promise<HistoryItem[]> {
-		const history = (this.getGlobalState("taskHistory") as HistoryItem[] | undefined) || []
-		const existingItemIndex = history.findIndex((h) => h.id === item.id)
+		await setHistoryItems([item])
 
-		if (existingItemIndex !== -1) {
-			history[existingItemIndex] = item
-		} else {
-			history.push(item)
-		}
-
-		await this.updateGlobalState("taskHistory", history)
-		return history
+		// Return all history items for the current workspace
+		const { getHistoryItemsForSearch } = await import("../task-persistence/taskHistory")
+		return await getHistoryItemsForSearch({ workspacePath: this.cwd })
 	}
 
 	// ContextProxy

src/shared/ExtensionMessage.ts

@@ -242,8 +242,6 @@ export type ExtensionState = Pick<
 	uriScheme?: string
 	shouldShowAnnouncement: boolean
 
-	taskHistory: HistoryItem[]
-
 	writeDelayMs: number
 	requestDelaySeconds: number
 

webview-ui/src/components/chat/ChatTextArea.tsx

@@ -84,7 +84,6 @@ const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>(
 			cwd,
 			pinnedApiConfigs,
 			togglePinnedApiConfig,
-			taskHistory,
 			clineMessages,
 		} = useExtensionState()
 
@@ -184,7 +183,6 @@ const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>(
 		// Use custom hook for prompt history navigation
 		const { handleHistoryNavigation, resetHistoryNavigation, resetOnInputChange } = usePromptHistory({
 			clineMessages,
-			taskHistory,
 			cwd,
 			inputValue,
 			setInputValue,

webview-ui/src/components/chat/ChatView.tsx

@@ -86,7 +86,6 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 	const {
 		clineMessages: messages,
 		currentTaskItem,
-		taskHistory,
 		apiConfiguration,
 		organizationAllowList,
 		mcpServers,
@@ -1712,7 +1711,7 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 							<RooTips cycle={false} />
 						</div>
 						{/* Show the task history preview if expanded and tasks exist */}
-						{taskHistory.length > 0 && isExpanded && <HistoryPreview />}
+						{ isExpanded && <HistoryPreview />}
 					</div>
 				</div>
 			)}

webview-ui/src/components/chat/hooks/usePromptHistory.ts

@@ -1,9 +1,9 @@
-import { ClineMessage, HistoryItem } from "@roo-code/types"
+import { ClineMessage } from "@roo-code/types"
 import { useCallback, useEffect, useMemo, useState } from "react"
+import { useTaskSearch } from "../../../components/history/useTaskSearch"
 
 interface UsePromptHistoryProps {
 	clineMessages: ClineMessage[] | undefined
-	taskHistory: HistoryItem[] | undefined
 	cwd: string | undefined
 	inputValue: string
 	setInputValue: (value: string) => void
@@ -26,7 +26,6 @@ export interface UsePromptHistoryReturn {
 
 export const usePromptHistory = ({
 	clineMessages,
-	taskHistory,
 	cwd,
 	inputValue,
 	setInputValue,
@@ -39,6 +38,9 @@ export const usePromptHistory = ({
 	const [tempInput, setTempInput] = useState("")
 	const [promptHistory, setPromptHistory] = useState<string[]>([])
 
+	// Use the useTaskSearch hook to get the task history
+	const { tasks } = useTaskSearch({ workspacePath: cwd, limit: MAX_PROMPT_HISTORY_SIZE })
+
 	// Initialize prompt history with hybrid approach: conversation messages if in task, otherwise task history
 	const filteredPromptHistory = useMemo(() => {
 		// First try to get conversation messages (user_feedback from clineMessages)
@@ -58,16 +60,16 @@ export const usePromptHistory = ({
 		}
 
 		// Fall back to task history only when starting fresh (no active conversation)
-		if (!taskHistory?.length || !cwd) {
+		if (!tasks.length || !cwd) {
 			return []
 		}
 
 		// Extract user prompts from task history for the current workspace only
-		return taskHistory
-			.filter((item) => item.task?.trim() && (!item.workspace || item.workspace === cwd))
+		return tasks
+			.filter((item) => item.task?.trim())
 			.map((item) => item.task)
 			.slice(0, MAX_PROMPT_HISTORY_SIZE)
-	}, [clineMessages, taskHistory, cwd])
+	}, [clineMessages, tasks, cwd])
 
 	// Update prompt history when filtered history changes and reset navigation
 	useEffect(() => {

webview-ui/src/context/ExtensionStateContext.tsx

@@ -160,7 +160,6 @@ export const ExtensionStateContextProvider: React.FC<{ children: React.ReactNode
 	const [state, setState] = useState<ExtensionState & { organizationAllowList?: OrganizationAllowList }>({
 		version: "",
 		clineMessages: [],
-		taskHistory: [],
 		shouldShowAnnouncement: false,
 		allowedCommands: [],
 		deniedCommands: [],