Fix settings saving logic to ensure the saved settings are used (#3976)

* feat: Enhance configuration change handling and model dimension checks

* fix: Update embedder creation to use modelId from config

* test: Add unit tests for ServiceFactory embedder and vector store creation

* test: Add comprehensive restart detection tests for configuration changes

* feat: Implement model ID selection logic for provider changes in CodeIndexSettings

* fix: Initialize configuration on constructor to prevent false restart triggers

* fix: Enhance API key handling and restart logic in CodeIndexConfigManager

* fix: Improve handling of external settings changes and automatic indexing in webviewMessageHandler

* fix: Ensure handleExternalSettingsChange only restarts service when manager is initialized

* refactor: remove console logs

* fix: Load configuration during initialization to ensure correct state and restart requirements

Author: daniel-lxs

src/core/webview/webviewMessageHandler.ts

@@ -1331,7 +1331,18 @@ export const webviewMessageHandler = async (provider: ClineProvider, message: We
 			await updateGlobalState("codebaseIndexConfig", codebaseIndexConfig)
 
 			try {
-				await provider.codeIndexManager?.initialize(provider.contextProxy)
+				if (provider.codeIndexManager) {
+					await provider.codeIndexManager.handleExternalSettingsChange()
+
+					// If now configured and enabled, start indexing automatically
+					if (provider.codeIndexManager.isFeatureEnabled && provider.codeIndexManager.isFeatureConfigured) {
+						if (!provider.codeIndexManager.isInitialized) {
+							await provider.codeIndexManager.initialize(provider.contextProxy)
+						}
+						// Start indexing in background (no await)
+						provider.codeIndexManager.startIndexing()
+					}
+				}
 			} catch (error) {
 				provider.log(
 					`[CodeIndexManager] Error during background CodeIndexManager configuration/indexing: ${error.message || error}`,