refactor: simplify whitelist implementation based on review feedback

- Remove unnecessary complexity and manual gitignore parsing
- Fix root cause: ripgrep's glob patterns filtering hidden directories
- Delete unused files (ignore-utils.ts, RooIgnoreController.gitignore.spec.ts)
- Simplify RooIgnoreController back to original implementation
- Keep all whitelist logic contained in list-files.ts
- Add isPathInIgnoredDirectory methods to scanner and file-watcher

The implementation is now ~30 lines instead of ~100 lines, directly
addressing the root cause identified by daniel-lxs where ripgrep's
-g '!**/.*/**' pattern was filtering out hidden directories even
when --no-ignore-vcs was used.

Author: MuriloFP

src/core/ignore/RooIgnoreController.ts

@@ -3,7 +3,6 @@ import { fileExistsAtPath } from "../../utils/fs"
 import fs from "fs/promises"
 import ignore, { Ignore } from "ignore"
 import * as vscode from "vscode"
-import { GITIGNORE_WHITELIST } from "../../services/glob/constants"
 
 export const LOCK_TEXT_SYMBOL = "\u{1F512}"
 
@@ -15,9 +14,7 @@ export const LOCK_TEXT_SYMBOL = "\u{1F512}"
 export class RooIgnoreController {
 	private cwd: string
 	private ignoreInstance: Ignore
-	private gitignoreInstance: Ignore | null = null
 	private disposables: vscode.Disposable[] = []
-	private whitelist = GITIGNORE_WHITELIST
 	rooIgnoreContent: string | undefined
 
 	constructor(cwd: string) {
@@ -34,7 +31,6 @@ export class RooIgnoreController {
 	 */
 	async initialize(): Promise<void> {
 		await this.loadRooIgnore()
-		await this.loadGitignore()
 	}
 
 	/**
@@ -83,75 +79,6 @@ export class RooIgnoreController {
 		}
 	}
 
-	/**
-	 * Load patterns from .gitignore if it exists
-	 */
-	async loadGitignore(): Promise<void> {
-		try {
-			this.gitignoreInstance = ignore()
-			const gitignorePath = path.join(this.cwd, ".gitignore")
-			if (await fileExistsAtPath(gitignorePath)) {
-				const content = await fs.readFile(gitignorePath, "utf8")
-				this.gitignoreInstance.add(content)
-			}
-		} catch (error) {
-			console.error("Error loading .gitignore:", error)
-			this.gitignoreInstance = null
-		}
-	}
-
-	/**
-	 * Check if a path is whitelisted
-	 * @param filePath - Path to check (relative to cwd)
-	 * @returns true if path is whitelisted
-	 */
-	isWhitelisted(filePath: string): boolean {
-		// Convert to relative path if absolute
-		let relativePath: string
-		if (path.isAbsolute(filePath)) {
-			relativePath = path.relative(this.cwd, filePath)
-		} else {
-			relativePath = filePath
-		}
-
-		// Normalize the path
-		const normalizedPath = path.normalize(relativePath).replace(/\\/g, "/")
-
-		return this.whitelist.some((pattern) => {
-			const normalizedPattern = path.normalize(pattern).replace(/\\/g, "/")
-			// Check if this is the whitelisted path or under it
-			return (
-				normalizedPath === normalizedPattern ||
-				normalizedPath.startsWith(normalizedPattern + "/") ||
-				// Check if this is a parent of the whitelisted path
-				normalizedPattern.startsWith(normalizedPath + "/")
-			)
-		})
-	}
-
-	/**
-	 * Check if a path is ignored by gitignore (considering whitelist)
-	 * @param filePath - Path to check (relative to cwd)
-	 * @returns true if path is ignored by gitignore and not whitelisted
-	 */
-	isGitignored(filePath: string): boolean {
-		if (!this.gitignoreInstance) {
-			return false
-		}
-
-		// Check whitelist first
-		if (this.isWhitelisted(filePath)) {
-			return false
-		}
-
-		try {
-			const relativePath = path.relative(this.cwd, path.resolve(this.cwd, filePath)).replace(/\\/g, "/")
-			return this.gitignoreInstance.ignores(relativePath)
-		} catch (error) {
-			return false
-		}
-	}
-
 	/**
 	 * Check if a file should be accessible to the LLM
 	 * @param filePath - Path to check (relative to cwd)

src/core/ignore/__tests__/RooIgnoreController.gitignore.spec.ts

@@ -22,7 +22,8 @@ import {
 import { codeParser } from "./parser"
 import { CacheManager } from "../cache-manager"
 import { generateNormalizedAbsolutePath, generateRelativeFilePath } from "../shared/get-relative-path"
-import { isPathInIgnoredDirectory } from "../../glob/ignore-utils"
+import { DIRS_TO_IGNORE } from "../../glob/constants"
+import * as path from "path"
 
 /**
  * Implementation of the file watcher interface
@@ -455,7 +456,7 @@ export class FileWatcher implements IFileWatcher {
 	async processFile(filePath: string): Promise<FileProcessingResult> {
 		try {
 			// Check if file is in an ignored directory
-			if (isPathInIgnoredDirectory(filePath)) {
+			if (this.isPathInIgnoredDirectory(filePath)) {
 				return {
 					path: filePath,
 					status: "skipped" as const,
@@ -543,4 +544,23 @@ export class FileWatcher implements IFileWatcher {
 			}
 		}
 	}
+
+	/**
+	 * Check if a path is within an ignored directory
+	 */
+	private isPathInIgnoredDirectory(filePath: string): boolean {
+		const normalizedPath = path.normalize(filePath)
+		const pathParts = normalizedPath.split(path.sep)
+
+		return pathParts.some((part) => {
+			// Check if any part of the path matches an ignored directory
+			return DIRS_TO_IGNORE.some((dir) => {
+				if (dir === ".*") {
+					// Special case for hidden directories (starting with .)
+					return part.startsWith(".") && part !== "."
+				}
+				return part === dir
+			})
+		})
+	}
 }