Move auto-approval from ChatView to Task (#9157)

Author: cte

packages/types/src/__tests__/message.test.ts

@@ -0,0 +1,14 @@
+// pnpm --filter @roo-code/types test src/__tests__/message.test.ts
+
+import { clineAsks, isIdleAsk, isInteractiveAsk, isResumableAsk, isNonBlockingAsk } from "../message.js"
+
+describe("ask messages", () => {
+	test("all ask messages are classified", () => {
+		for (const ask of clineAsks) {
+			expect(
+				isIdleAsk(ask) || isInteractiveAsk(ask) || isResumableAsk(ask) || isNonBlockingAsk(ask),
+				`${ask} is not classified`,
+			).toBe(true)
+		}
+	})
+})

packages/types/src/message.ts

@@ -43,25 +43,6 @@ export const clineAsks = [
 export const clineAskSchema = z.enum(clineAsks)
 
 export type ClineAsk = z.infer<typeof clineAskSchema>
-
-// Needs classification:
-// - `followup`
-
-/**
- * NonBlockingAsk
- *
- * Asks that should not block task execution. These are informational or optional
- * asks where the task can proceed even without an immediate user response.
- */
-
-export const nonBlockingAsks = ["command_output"] as const satisfies readonly ClineAsk[]
-
-export type NonBlockingAsk = (typeof nonBlockingAsks)[number]
-
-export function isNonBlockingAsk(ask: ClineAsk): ask is NonBlockingAsk {
-	return (nonBlockingAsks as readonly ClineAsk[]).includes(ask)
-}
-
 /**
  * IdleAsk
  *
@@ -116,6 +97,21 @@ export function isInteractiveAsk(ask: ClineAsk): ask is InteractiveAsk {
 	return (interactiveAsks as readonly ClineAsk[]).includes(ask)
 }
 
+/**
+ * NonBlockingAsk
+ *
+ * Asks that are not associated with an actual approval, and are only used
+ * to update chat messages.
+ */
+
+export const nonBlockingAsks = ["command_output"] as const satisfies readonly ClineAsk[]
+
+export type NonBlockingAsk = (typeof nonBlockingAsks)[number]
+
+export function isNonBlockingAsk(ask: ClineAsk): ask is NonBlockingAsk {
+	return (nonBlockingAsks as readonly ClineAsk[]).includes(ask)
+}
+
 /**
  * ClineSay
  */

pnpm-lock.yaml

@@ -1,4 +1,5 @@
 import { GlobalState, ClineMessage, ClineAsk } from "@roo-code/types"
+
 import { getApiMetrics } from "../../shared/getApiMetrics"
 import { ClineAskResponse } from "../../shared/WebviewMessage"
 

src/core/task/AutoApprovalHandler.ts renamed to src/core/auto-approval/AutoApprovalHandler.ts

@@ -2,7 +2,6 @@ import { GlobalState, ClineMessage } from "@roo-code/types"
 
 import { AutoApprovalHandler } from "../AutoApprovalHandler"
 
-// Mock getApiMetrics
 vi.mock("../../../shared/getApiMetrics", () => ({
 	getApiMetrics: vi.fn(),
 }))