fix: resolve memory leak in RooHandler event listener

- Add private authStateListener property to store listener reference
- Store listener function reference for proper cleanup
- Implement dispose() method to remove event listener
- Fix API key issue by using cloudService reference instead of CloudService.instance
- Update tests to include on/off methods in CloudService mock

This prevents memory leaks when multiple RooHandler instances are created
and ensures proper cleanup of event listeners.

Author: roomote

src/api/providers/__tests__/roo.spec.ts

@@ -82,6 +82,8 @@ vitest.mock("@roo-code/cloud", () => ({
 				authService: {
 					getSessionToken: () => mockGetSessionTokenFn(),
 				},
+				on: vitest.fn(),
+				off: vitest.fn(),
 			}
 		},
 	},
@@ -413,7 +415,11 @@ describe("RooHandler", () => {
 
 			try {
 				Object.defineProperty(CloudService, "instance", {
-					get: () => ({ authService: undefined }),
+					get: () => ({
+						authService: undefined,
+						on: vitest.fn(),
+						off: vitest.fn(),
+					}),
 					configurable: true,
 				})
 

src/api/providers/roo.ts

@@ -12,6 +12,8 @@ import { DEFAULT_HEADERS } from "./constants"
 import { BaseOpenAiCompatibleProvider } from "./base-openai-compatible-provider"
 
 export class RooHandler extends BaseOpenAiCompatibleProvider<RooModelId> {
+	private authStateListener?: (state: { state: AuthState }) => void
+
 	constructor(options: ApiHandlerOptions) {
 		let sessionToken: string | undefined = undefined
 
@@ -34,11 +36,11 @@ export class RooHandler extends BaseOpenAiCompatibleProvider<RooModelId> {
 		if (CloudService.hasInstance()) {
 			const cloudService = CloudService.instance
 
-			cloudService.on("auth-state-changed", (state: { state: AuthState }) => {
+			this.authStateListener = (state: { state: AuthState }) => {
 				if (state.state === "active-session") {
 					this.client = new OpenAI({
 						baseURL: this.baseURL,
-						apiKey: CloudService.instance.authService?.getSessionToken() ?? "unauthenticated",
+						apiKey: cloudService.authService?.getSessionToken() ?? "unauthenticated",
 						defaultHeaders: DEFAULT_HEADERS,
 					})
 				} else if (state.state === "logged-out") {
@@ -48,7 +50,15 @@ export class RooHandler extends BaseOpenAiCompatibleProvider<RooModelId> {
 						defaultHeaders: DEFAULT_HEADERS,
 					})
 				}
-			})
+			}
+
+			cloudService.on("auth-state-changed", this.authStateListener)
+		}
+	}
+
+	dispose() {
+		if (this.authStateListener && CloudService.hasInstance()) {
+			CloudService.instance.off("auth-state-changed", this.authStateListener)
 		}
 	}