fix: always include mode instructions regardless of Power Steering setting

- Mode roleDefinition and customInstructions are now always included in environment details
- Previously these were only included when Power Steering was enabled
- Updated tests to verify mode instructions are included in both cases

Fixes #7277

Author: roomote

src/core/environment/__tests__/getEnvironmentDetails.spec.ts

@@ -313,11 +313,21 @@ describe("getEnvironmentDetails", () => {
 		expect(mockInactiveTerminal.getCurrentWorkingDirectory).toHaveBeenCalled()
 	})
 
-	it("should include experiment-specific details when Power Steering is enabled", async () => {
+	it("should always include mode role and custom instructions regardless of Power Steering", async () => {
+		// Test with Power Steering disabled
+		mockState.experiments = { [EXPERIMENT_IDS.POWER_STEERING]: false }
+		;(experiments.isEnabled as Mock).mockReturnValue(false)
+
+		let result = await getEnvironmentDetails(mockCline as Task)
+
+		expect(result).toContain("<role>You are a code assistant</role>")
+		expect(result).toContain("<custom_instructions>Custom instructions</custom_instructions>")
+
+		// Test with Power Steering enabled
 		mockState.experiments = { [EXPERIMENT_IDS.POWER_STEERING]: true }
 		;(experiments.isEnabled as Mock).mockReturnValue(true)
 
-		const result = await getEnvironmentDetails(mockCline as Task)
+		result = await getEnvironmentDetails(mockCline as Task)
 
 		expect(result).toContain("<role>You are a code assistant</role>")
 		expect(result).toContain("<custom_instructions>Custom instructions</custom_instructions>")

src/core/environment/getEnvironmentDetails.ts

@@ -228,13 +228,10 @@ export async function getEnvironmentDetails(cline: Task, includeFileDetails: boo
 	details += `<slug>${currentMode}</slug>\n`
 	details += `<name>${modeDetails.name}</name>\n`
 	details += `<model>${modelId}</model>\n`
+	details += `<role>${modeDetails.roleDefinition}</role>\n`
 
-	if (Experiments.isEnabled(experiments ?? {}, EXPERIMENT_IDS.POWER_STEERING)) {
-		details += `<role>${modeDetails.roleDefinition}</role>\n`
-
-		if (modeDetails.customInstructions) {
-			details += `<custom_instructions>${modeDetails.customInstructions}</custom_instructions>\n`
-		}
+	if (modeDetails.customInstructions) {
+		details += `<custom_instructions>${modeDetails.customInstructions}</custom_instructions>\n`
 	}
 
 	if (includeFileDetails) {