Skip to content

Commit 70a5d2b

Browse files
authored
Require node v20 everywhere (#922)
1 parent 65740b3 commit 70a5d2b

File tree

7 files changed

+16
-15
lines changed

7 files changed

+16
-15
lines changed

.github/workflows/changeset-release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
env:
1010
REPO_PATH: ${{ github.repository }}
1111
GIT_REF: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || 'main' }}
12+
NODE_VERSION: 20.18.1
1213

1314
jobs:
1415
# Job 1: Create version bump PR when changesets are merged to main
@@ -33,7 +34,7 @@ jobs:
3334
- name: Setup Node.js
3435
uses: actions/setup-node@v4
3536
with:
36-
node-version: 20
37+
node-version: ${{ env.NODE_VERSION }}
3738
cache: 'npm'
3839

3940
- name: Install Dependencies

.github/workflows/code-qa.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ on:
88
types: [opened, reopened, ready_for_review, synchronize]
99
branches: [main]
1010

11+
env:
12+
NODE_VERSION: 20.18.1
13+
1114
jobs:
1215
compile:
1316
runs-on: ubuntu-latest
@@ -17,7 +20,7 @@ jobs:
1720
- name: Setup Node.js
1821
uses: actions/setup-node@v4
1922
with:
20-
node-version: '18'
23+
node-version: ${{ env.NODE_VERSION }}
2124
cache: 'npm'
2225
- name: Install dependencies
2326
run: npm run install:all
@@ -66,7 +69,7 @@ jobs:
6669
- name: Setup Node.js
6770
uses: actions/setup-node@v4
6871
with:
69-
node-version: '18'
72+
node-version: ${{ env.NODE_VERSION }}
7073
cache: 'npm'
7174
- name: Install dependencies
7275
run: npm run install:all
@@ -121,7 +124,7 @@ jobs:
121124
- name: Setup Node.js
122125
uses: actions/setup-node@v4
123126
with:
124-
node-version: '18'
127+
node-version: ${{ env.NODE_VERSION }}
125128
cache: 'npm'
126129
- name: Install dependencies
127130
run: npm run install:all

.github/workflows/marketplace-publish.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66

77
env:
88
GIT_REF: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || 'main' }}
9+
NODE_VERSION: 20.18.1
910

1011
jobs:
1112
publish-extension:
@@ -21,15 +22,12 @@ jobs:
2122
- uses: actions/checkout@v4
2223
with:
2324
ref: ${{ env.GIT_REF }}
24-
2525
- uses: actions/setup-node@v4
2626
with:
27-
node-version: 18
28-
27+
node-version: ${{ env.NODE_VERSION }}
2928
- run: |
3029
git config user.name "github-actions[bot]"
3130
git config user.email "github-actions[bot]@users.noreply.github.com"
32-
3331
- name: Install Dependencies
3432
run: |
3533
npm install -g vsce ovsx
@@ -46,14 +44,12 @@ jobs:
4644
echo "$package" | grep -q "extension/webview-ui/build/assets/index.js" || exit 1
4745
echo "$package" | grep -q "extension/node_modules/@vscode/codicons/dist/codicon.ttf" || exit 1
4846
echo "$package" | grep -q ".env" || exit 1
49-
5047
- name: Create and Push Git Tag
5148
run: |
5249
current_package_version=$(node -p "require('./package.json').version")
5350
git tag -a "v${current_package_version}" -m "Release v${current_package_version}"
5451
git push origin "v${current_package_version}"
5552
echo "Successfully created and pushed git tag v${current_package_version}"
56-
5753
- name: Publish Extension
5854
env:
5955
VSCE_PAT: ${{ secrets.VSCE_PAT }}
@@ -62,7 +58,6 @@ jobs:
6258
current_package_version=$(node -p "require('./package.json').version")
6359
npm run publish:marketplace
6460
echo "Successfully published version $current_package_version to VS Code Marketplace"
65-
6661
- name: Create GitHub Release
6762
env:
6863
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
lts/*
1+
v20.18.1

flake.nix

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
name = "roo-code";
1717

1818
packages = with pkgs; [
19-
nodejs_18
20-
corepack_18
19+
nodejs_20
20+
corepack_20
2121
];
2222
};
2323
in {

package-lock.json

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
"theme": "dark"
1111
},
1212
"engines": {
13-
"vscode": "^1.84.0"
13+
"vscode": "^1.84.0",
14+
"node": ">=20.18.1"
1415
},
1516
"author": {
1617
"name": "Roo Vet"

0 commit comments

Comments
 (0)