Added terminal process fixes and improvements

Author: bramburn

webview-ui/src/components/chat/ChatTextArea.tsx

@@ -32,6 +32,7 @@ interface ChatTextAreaProps {
 	inputValue: string
 	setInputValue: (value: string) => void
 	textAreaDisabled: boolean
+	selectApiConfigDisabled: boolean
 	placeholderText: string
 	selectedImages: string[]
 	setSelectedImages: React.Dispatch<React.SetStateAction<string[]>>
@@ -50,6 +51,7 @@ const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>(
 			inputValue,
 			setInputValue,
 			textAreaDisabled,
+			selectApiConfigDisabled,
 			placeholderText,
 			selectedImages,
 			setSelectedImages,
@@ -975,7 +977,7 @@ const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>(
 						<div className={cn("flex-1", "min-w-0", "overflow-hidden")}>
 							<SelectDropdown
 								value={currentConfigId}
-								disabled={textAreaDisabled}
+								disabled={selectApiConfigDisabled}
 								title={t("chat:selectApiConfig")}
 								placeholder={displayName} // Always show the current name
 								options={[

webview-ui/src/components/chat/ChatView.tsx

@@ -1359,6 +1359,7 @@ const ChatView = ({ isHidden, showAnnouncement, hideAnnouncement, showHistoryVie
 				inputValue={inputValue}
 				setInputValue={setInputValue}
 				textAreaDisabled={textAreaDisabled}
+				selectApiConfigDisabled={textAreaDisabled && clineAsk !== "api_req_failed"}
 				placeholderText={placeholderText}
 				selectedImages={selectedImages}
 				setSelectedImages={setSelectedImages}

webview-ui/src/components/chat/__tests__/ChatTextArea.test.tsx

@@ -47,6 +47,7 @@ describe("ChatTextArea", () => {
 		setInputValue: jest.fn(),
 		onSend: jest.fn(),
 		textAreaDisabled: false,
+		selectApiConfigDisabled: false,
 		onSelectImages: jest.fn(),
 		shouldDisableImages: false,
 		placeholderText: "Type a message...",
@@ -408,4 +409,21 @@ describe("ChatTextArea", () => {
 			expect(setInputValue).not.toHaveBeenCalled()
 		})
 	})
+
+	describe("selectApiConfig", () => {
+		// Helper function to get the API config dropdown
+		const getApiConfigDropdown = () => {
+			return screen.getByTitle("chat:selectApiConfig")
+		}
+		it("should be enabled independently of textAreaDisabled", () => {
+			render(<ChatTextArea {...defaultProps} textAreaDisabled={true} selectApiConfigDisabled={false} />)
+			const apiConfigDropdown = getApiConfigDropdown()
+			expect(apiConfigDropdown).not.toHaveAttribute("disabled")
+		})
+		it("should be disabled when selectApiConfigDisabled is true", () => {
+			render(<ChatTextArea {...defaultProps} textAreaDisabled={true} selectApiConfigDisabled={true} />)
+			const apiConfigDropdown = getApiConfigDropdown()
+			expect(apiConfigDropdown).toHaveAttribute("disabled")
+		})
+	})
 })

webview-ui/src/components/settings/constants.ts

@@ -39,22 +39,30 @@ export const PROVIDERS = [
 	{ value: "human-relay", label: "Human Relay" },
 ].sort((a, b) => a.label.localeCompare(b.label))
 
+//This list alpha sorted and updated April 2, 2025 to include any region that supported 1 or
+//more models shown at https://docs.aws.amazon.com/bedrock/latest/userguide/models-regions.html
+
 export const AWS_REGIONS = [
-	{ value: "us-east-1", label: "us-east-1" },
-	{ value: "us-east-2", label: "us-east-2" },
-	{ value: "us-west-2", label: "us-west-2" },
-	{ value: "ap-south-1", label: "ap-south-1" },
 	{ value: "ap-northeast-1", label: "ap-northeast-1" },
 	{ value: "ap-northeast-2", label: "ap-northeast-2" },
+	{ value: "ap-south-1", label: "ap-south-1" },
 	{ value: "ap-southeast-1", label: "ap-southeast-1" },
 	{ value: "ap-southeast-2", label: "ap-southeast-2" },
 	{ value: "ca-central-1", label: "ca-central-1" },
 	{ value: "eu-central-1", label: "eu-central-1" },
+	{ value: "eu-central-2", label: "eu-central-2" },
+	{ value: "eu-north-1", label: "eu-north-1" },
+	{ value: "eu-south-1", label: "eu-south-1" },
+	{ value: "eu-south-2", label: "eu-south-2" },
 	{ value: "eu-west-1", label: "eu-west-1" },
 	{ value: "eu-west-2", label: "eu-west-2" },
 	{ value: "eu-west-3", label: "eu-west-3" },
 	{ value: "sa-east-1", label: "sa-east-1" },
+	{ value: "us-east-1", label: "us-east-1" },
+	{ value: "us-east-2", label: "us-east-2" },
+	{ value: "us-gov-east-1", label: "us-gov-east-1" },
 	{ value: "us-gov-west-1", label: "us-gov-west-1" },
+	{ value: "us-west-2", label: "us-west-2" },
 ]
 
 export const VERTEX_REGIONS = [

webview-ui/src/components/ui/select-dropdown.tsx

@@ -83,7 +83,7 @@ export const SelectDropdown = React.forwardRef<React.ElementRef<typeof DropdownM
 		}
 
 		return (
-			<DropdownMenu open={open} onOpenChange={setOpen}>
+			<DropdownMenu open={open} onOpenChange={setOpen} modal={false}>
 				<DropdownMenuTrigger
 					ref={ref}
 					disabled={disabled}