fix: resolve failing MCP tool tests

- Fix image limiting warning logic by checking original array length before slicing
- Add missing getState mock in test to support MCP settings access
- Update test assertion to match actual function signature with images parameter

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: shivangag

src/core/tools/__tests__/useMcpToolTool.spec.ts

@@ -1147,6 +1147,10 @@ describe("useMcpToolTool", () => {
 					callTool: vi.fn().mockResolvedValue(mockToolResult),
 				}),
 				postMessageToWebview: vi.fn(),
+				getState: vi.fn().mockResolvedValue({
+					mcpMaxImagesPerResponse: 20,
+					mcpMaxImageSizeMB: 10,
+				}),
 			})
 
 			const block: ToolUse = {
@@ -1174,7 +1178,7 @@ describe("useMcpToolTool", () => {
 			expect(mockTask.consecutiveMistakeCount).toBe(0)
 			expect(mockTask.recordToolError).not.toHaveBeenCalled()
 			expect(mockTask.say).toHaveBeenCalledWith("mcp_server_request_started")
-			expect(mockTask.say).toHaveBeenCalledWith("mcp_server_response", "Tool executed successfully")
+			expect(mockTask.say).toHaveBeenCalledWith("mcp_server_response", "Tool executed successfully", [])
 		})
 
 		it("should reject unknown server names with available servers listed", async () => {

src/core/tools/useMcpToolTool.ts

@@ -269,7 +269,15 @@ async function processToolContent(toolResult: any, cline: Task): Promise<{ text:
 	const maxImageSizeMB = Math.max(0.1, Math.min(50, state?.mcpMaxImageSizeMB ?? 10))
 
 	// Separate content by type for efficient processing
-	const imageItems = toolResult.content.filter((item: any) => item.type === "image").slice(0, maxImagesPerResponse) // Limit images before processing
+	const allImageItems = toolResult.content.filter((item: any) => item.type === "image")
+	const imageItems = allImageItems.slice(0, maxImagesPerResponse) // Limit images before processing
+
+	// Check if we need to warn about exceeding the limit
+	if (allImageItems.length > maxImagesPerResponse) {
+		console.warn(
+			`MCP response contains more than ${maxImagesPerResponse} images. Additional images will be ignored to prevent performance issues.`,
+		)
+	}
 
 	// Process images in parallel
 	const validatedImages = await Promise.all(
@@ -287,12 +295,6 @@ async function processToolContent(toolResult: any, cline: Task): Promise<{ text:
 		}
 	})
 
-	if (imageItems.length > maxImagesPerResponse) {
-		console.warn(
-			`MCP response contains more than ${maxImagesPerResponse} images. Additional images will be ignored to prevent performance issues.`,
-		)
-	}
-
 	return {
 		text: textParts.filter(Boolean).join("\n\n"),
 		images,