staged changes after revert to 4517eb7

Author: hannesrudolph

src/core/assistant-message/presentAssistantMessage.ts

@@ -37,6 +37,7 @@ import { Task } from "../task/Task"
 import { codebaseSearchTool } from "../tools/codebaseSearchTool"
 import { experiments, EXPERIMENT_IDS } from "../../shared/experiments"
 import { applyDiffToolLegacy } from "../tools/applyDiffTool"
+import { t } from "../../i18n"
 
 /**
  * Processes and presents assistant message content to the user interface.
@@ -327,7 +328,7 @@ export async function presentAssistantMessage(cline: Task) {
 					undefined, // partial
 					undefined, // checkpoint
 					undefined, // progressStatus
-					{ title: `Tool Call Error: ${block.name}` }, // Custom title with tool name
+					{ title: t("tools:errors.toolCallError", { toolName: block.name }) }, // Custom title with tool name
 				)
 
 				pushToolResult(formatResponse.toolError(errorString, block.name))

src/core/prompts/responses.ts

@@ -3,6 +3,7 @@ import * as path from "path"
 import * as diff from "diff"
 import { RooIgnoreController, LOCK_TEXT_SYMBOL } from "../ignore/RooIgnoreController"
 import { RooProtectedController } from "../protect/RooProtectedController"
+import { t } from "../../i18n"
 
 export const formatResponse = {
 	toolDenied: () => `The user denied this operation.`,
@@ -14,7 +15,9 @@ export const formatResponse = {
 		`The user approved this operation and provided the following context:\n<feedback>\n${feedback}\n</feedback>`,
 
 	toolError: (error?: string, toolName?: string) => {
-		const title = toolName ? `Tool Call Error: ${toolName}` : "Tool Execution Error"
+		const title = toolName
+			? t("tools:errors.toolCallError", { toolName, defaultValue: `Tool Call Error: ${toolName}` })
+			: t("tools:errors.toolExecutionError", { defaultValue: "Tool Execution Error" })
 		return `${title}\n<error>\n${error}\n</error>`
 	},
 

src/core/task/Task.ts

@@ -1141,16 +1141,22 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 	}
 
 	async sayAndCreateMissingParamError(toolName: ToolName, paramName: string, relPath?: string) {
+		const message = relPath
+			? t("tools:errors.missingParamForToolWithPath", {
+					toolName,
+					relPath: relPath.toPosix(),
+					paramName,
+				})
+			: t("tools:errors.missingParamForTool", { toolName, paramName })
+
 		await this.say(
 			"error",
-			`Roo tried to use ${toolName}${
-				relPath ? ` for '${relPath.toPosix()}'` : ""
-			} without value for required parameter '${paramName}'. Retrying...`,
+			message,
 			undefined, // images
 			undefined, // partial
 			undefined, // checkpoint
 			undefined, // progressStatus
-			{ title: `Tool Call Error: ${toolName}` }, // Custom title for the error
+			{ title: t("tools:errors.toolCallError", { toolName }) }, // Custom title for the error
 		)
 		return formatResponse.toolError(formatResponse.missingToolParameterError(paramName), toolName)
 	}

src/core/tools/askFollowupQuestionTool.ts

@@ -2,6 +2,7 @@ import { Task } from "../task/Task"
 import { ToolUse, AskApproval, HandleError, PushToolResult, RemoveClosingTag } from "../../shared/tools"
 import { formatResponse } from "../prompts/responses"
 import { parseXml } from "../../utils/xml"
+import { t } from "../../i18n"
 
 export async function askFollowupQuestionTool(
 	cline: Task,
@@ -55,7 +56,7 @@ export async function askFollowupQuestionTool(
 						undefined,
 						undefined,
 						undefined,
-						{ title: "Parse Error" },
+						{ title: t("tools:errors.parseError") },
 					)
 					pushToolResult(formatResponse.toolError("Invalid operations xml format", "ask_followup_question"))
 					return

src/core/tools/attemptCompletionTool.ts

@@ -1,5 +1,6 @@
 import Anthropic from "@anthropic-ai/sdk"
 import * as vscode from "vscode"
+import { t } from "../../i18n"
 
 import { RooCodeEventName } from "@roo-code/types"
 import { TelemetryService } from "@roo-code/telemetry"
@@ -44,10 +45,7 @@ export async function attemptCompletionTool(
 		cline.recordToolError("attempt_completion")
 
 		pushToolResult(
-			formatResponse.toolError(
-				"Cannot complete task while there are incomplete todos. Please finish all todos before attempting completion.",
-				"attempt_completion",
-			),
+			formatResponse.toolError(t("tools:attemptCompletion.errors.incompleteTodos"), "attempt_completion"),
 		)
 
 		return
@@ -126,7 +124,7 @@ export async function attemptCompletionTool(
 
 			toolResults.push({
 				type: "text",
-				text: `The user has provided feedback on the results. Consider their input to continue the task, and then attempt completion again.\n<feedback>\n${text}\n</feedback>`,
+				text: `${t("tools:attemptCompletion.userFeedbackLead")}\n<feedback>\n${text}\n</feedback>`,
 			})
 
 			toolResults.push(...formatResponse.imageBlocks(images))