fix: address PR review feedback for Gemini tools feature

- Fix Hindi translation grammatical error in settings.json
- Internationalize 'Sources:' string and error messages in gemini.ts
- Add comprehensive error scenario tests to gemini-handler.spec.ts
- Remove unused currentModelId prop from Gemini component
- Update all locale files with new translation keys

Author: daniel-lxs

src/api/providers/__tests__/gemini-handler.spec.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, vi } from "vitest"
+import { t } from "i18next"
 import { GeminiHandler } from "../gemini"
 import type { ApiHandlerOptions } from "../../../shared/api"
 
@@ -33,4 +34,104 @@ describe("GeminiHandler backend support", () => {
 		const promptConfig = stub.mock.calls[0][0].config
 		expect(promptConfig.tools).toBeUndefined()
 	})
+
+	describe("error scenarios", () => {
+		it("should handle grounding metadata extraction failure gracefully", async () => {
+			const options = {
+				apiProvider: "gemini",
+				enableGrounding: true,
+			} as ApiHandlerOptions
+			const handler = new GeminiHandler(options)
+
+			const mockStream = async function* () {
+				yield {
+					candidates: [
+						{
+							groundingMetadata: {
+								// Invalid structure - missing groundingChunks
+							},
+							content: { parts: [{ text: "test response" }] },
+						},
+					],
+					usageMetadata: { promptTokenCount: 10, candidatesTokenCount: 5 },
+				}
+			}
+
+			const stub = vi.fn().mockReturnValue(mockStream())
+			// @ts-ignore access private client
+			handler["client"].models.generateContentStream = stub
+
+			const messages = []
+			for await (const chunk of handler.createMessage("test", [] as any)) {
+				messages.push(chunk)
+			}
+
+			// Should still return the main content without sources
+			expect(messages.some((m) => m.type === "text" && m.text === "test response")).toBe(true)
+			expect(messages.some((m) => m.type === "text" && m.text?.includes("Sources:"))).toBe(false)
+		})
+
+		it("should handle malformed grounding metadata", async () => {
+			const options = {
+				apiProvider: "gemini",
+				enableGrounding: true,
+			} as ApiHandlerOptions
+			const handler = new GeminiHandler(options)
+
+			const mockStream = async function* () {
+				yield {
+					candidates: [
+						{
+							groundingMetadata: {
+								groundingChunks: [
+									{ web: null }, // Missing URI
+									{ web: { uri: "https://example.com" } }, // Valid
+									{}, // Missing web property entirely
+								],
+							},
+							content: { parts: [{ text: "test response" }] },
+						},
+					],
+					usageMetadata: { promptTokenCount: 10, candidatesTokenCount: 5 },
+				}
+			}
+
+			const stub = vi.fn().mockReturnValue(mockStream())
+			// @ts-ignore access private client
+			handler["client"].models.generateContentStream = stub
+
+			const messages = []
+			for await (const chunk of handler.createMessage("test", [] as any)) {
+				messages.push(chunk)
+			}
+
+			// Should only include valid citations
+			const sourceMessage = messages.find((m) => m.type === "text" && m.text?.includes("[2]"))
+			expect(sourceMessage).toBeDefined()
+			if (sourceMessage && "text" in sourceMessage) {
+				expect(sourceMessage.text).toContain("https://example.com")
+				expect(sourceMessage.text).not.toContain("[1]")
+				expect(sourceMessage.text).not.toContain("[3]")
+			}
+		})
+
+		it("should handle API errors when tools are enabled", async () => {
+			const options = {
+				apiProvider: "gemini",
+				enableUrlContext: true,
+				enableGrounding: true,
+			} as ApiHandlerOptions
+			const handler = new GeminiHandler(options)
+
+			const mockError = new Error("API rate limit exceeded")
+			const stub = vi.fn().mockRejectedValue(mockError)
+			// @ts-ignore access private client
+			handler["client"].models.generateContentStream = stub
+
+			await expect(async () => {
+				const generator = handler.createMessage("test", [] as any)
+				await generator.next()
+			}).rejects.toThrow(t("common:errors.gemini.generate_stream", { error: "API rate limit exceeded" }))
+		})
+	})
 })

src/api/providers/gemini.ts

@@ -134,7 +134,7 @@ export class GeminiHandler extends BaseProvider implements SingleCompletionHandl
 			if (pendingGroundingMetadata) {
 				const citations = this.extractCitationsOnly(pendingGroundingMetadata)
 				if (citations) {
-					yield { type: "text", text: `\n\nSources: ${citations}` }
+					yield { type: "text", text: `\n\n${t("common:errors.gemini.sources")} ${citations}` }
 				}
 			}
 
@@ -230,7 +230,7 @@ export class GeminiHandler extends BaseProvider implements SingleCompletionHandl
 			if (candidate?.groundingMetadata) {
 				const citations = this.extractCitationsOnly(candidate.groundingMetadata)
 				if (citations) {
-					text += `\n\nSources: ${citations}`
+					text += `\n\n${t("common:errors.gemini.sources")} ${citations}`
 				}
 			}
 

src/i18n/locales/ca/common.json

@@ -80,7 +80,8 @@
 		},
 		"gemini": {
 			"generate_stream": "Gemini generate context stream error: {{error}}",
-			"generate_complete_prompt": "Gemini completion error: {{error}}"
+			"generate_complete_prompt": "Gemini completion error: {{error}}",
+			"sources": "Sources:"
 		}
 	},
 	"warnings": {