Skip to content

Commit 83be0f6

Browse files
author
Eric Oliver
committed
address reviewer feedback
1 parent 901f99f commit 83be0f6

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

src/cli/cli-entry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ program
299299
})
300300
getCLILogger().debug("[cli-entry] GlobalCLIMcpService initialized successfully")
301301
} catch (error) {
302-
getCLILogger().debug("[cli-entry] Failed to initialize GlobalCLIMcpService:", error)
302+
getCLILogger().warn("[cli-entry] Failed to initialize GlobalCLIMcpService:", error)
303303
if (options.verbose) {
304304
console.warn(
305305
chalk.yellow("Warning: MCP initialization failed:"),

src/cli/commands/__tests__/BatchProcessor.test.ts

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,12 @@ describe("BatchProcessor", () => {
9191
jest.advanceTimersByTime(59000)
9292

9393
// Task should still be running, no timeout yet
94-
expect(runPromise).not.toBe(undefined)
94+
await expect(
95+
Promise.race([
96+
runPromise,
97+
new Promise((resolve) => setTimeout(resolve, 1000)), // Ensure promise does not resolve within 1 second
98+
]),
99+
).resolves.not.toBe(runPromise)
95100

96101
// Now wait the full 60 seconds from the last activity
97102
jest.advanceTimersByTime(1000)
@@ -121,7 +126,12 @@ describe("BatchProcessor", () => {
121126
mockTask.emit(event[0], ...event.slice(1))
122127

123128
// Should not timeout yet
124-
expect(runPromise).not.toBe(undefined)
129+
await expect(
130+
Promise.race([
131+
runPromise,
132+
new Promise((resolve) => setTimeout(resolve, 1000)), // Ensure promise does not resolve within 1 second
133+
]),
134+
).resolves.not.toBe(runPromise)
125135
}
126136

127137
// Wait full timeout after last activity
@@ -192,7 +202,12 @@ describe("BatchProcessor", () => {
192202
jest.advanceTimersByTime(59000)
193203

194204
// Should still be running
195-
expect(runPromise).not.toBe(undefined)
205+
await expect(
206+
Promise.race([
207+
runPromise,
208+
new Promise((resolve) => setTimeout(resolve, 1000)), // Ensure promise does not resolve within 1 second
209+
]),
210+
).resolves.not.toBe(runPromise)
196211

197212
// Wait the final second to trigger timeout
198213
jest.advanceTimersByTime(1000)

0 commit comments

Comments
 (0)