settings bug fixes.

Added handlers for FilesChangedEnabled so settings work properly.

Author: playcations

src/core/checkpoints/index.ts

@@ -117,6 +117,7 @@ export function getCheckpointService(cline: Task) {
 							baseHash,
 							cline.taskId,
 							provider.context.globalStorageUri.fsPath,
+							provider,
 						)
 						log(`[Task#getCheckpointService] FileChangeManager created with baseline: ${baseHash}`)
 					} catch (error) {

src/core/webview/webviewMessageHandler.ts

@@ -720,6 +720,11 @@ export const webviewMessageHandler = async (
 			await updateGlobalState("soundEnabled", soundEnabled)
 			await provider.postStateToWebview()
 			break
+		case "filesChangedEnabled":
+			const filesChangedEnabled = message.bool ?? true
+			await updateGlobalState("filesChangedEnabled", filesChangedEnabled)
+			await provider.postStateToWebview()
+			break
 		case "soundVolume":
 			const soundVolume = message.value ?? 0.5
 			await updateGlobalState("soundVolume", soundVolume)

src/integrations/editor/DiffViewProvider.ts

@@ -234,18 +234,21 @@ export class DiffViewProvider {
 						lineDiff.linesRemoved,
 					)
 
-					// Notify the webview about the file changes
-					const updatedChangeset = task.fileChangeManager.getChanges()
+					// Notify the webview about the file changes (only if tracking is enabled)
 					const provider = task.providerRef.deref()
-					if (provider && updatedChangeset.files.length > 0) {
-						const serializableChangeset = {
-							...updatedChangeset,
-							files: Array.from(updatedChangeset.files.values()),
+					const filesChangedEnabled = provider?.getValue("filesChangedEnabled") ?? true
+					if (provider && filesChangedEnabled) {
+						const updatedChangeset = task.fileChangeManager.getChanges()
+						if (updatedChangeset.files.length > 0) {
+							const serializableChangeset = {
+								...updatedChangeset,
+								files: Array.from(updatedChangeset.files.values()),
+							}
+							provider.postMessageToWebview({
+								type: "filesChanged",
+								filesChanged: serializableChangeset,
+							})
 						}
-						provider.postMessageToWebview({
-							type: "filesChanged",
-							filesChanged: serializableChangeset,
-						})
 					}
 
 					console.log(

src/services/file-changes/FileChangeManager.ts

@@ -4,6 +4,9 @@ import * as fs from "fs/promises"
 import * as path from "path"
 import { EventEmitter } from "vscode"
 
+// Type imports for provider reference
+import type { ClineProvider } from "../../core/webview/ClineProvider"
+
 // Error types for better error handling
 export enum FileChangeErrorType {
 	PERSISTENCE_FAILED = "PERSISTENCE_FAILED",
@@ -41,15 +44,17 @@ export class FileChangeManager {
 	private persistenceInProgress = false
 	private pendingPersistence = false
 	private errorHandler?: FileChangeErrorHandler
+	private providerRef?: WeakRef<ClineProvider>
 
-	constructor(baseCheckpoint: string, taskId?: string, globalStoragePath?: string) {
+	constructor(baseCheckpoint: string, taskId?: string, globalStoragePath?: string, provider?: ClineProvider) {
 		this.instanceId = crypto.randomUUID()
 		this.changeset = {
 			baseCheckpoint,
 			files: new Map<string, FileChange>(),
 		}
 		this.taskId = taskId || ""
 		this.globalStoragePath = globalStoragePath || ""
+		this.providerRef = provider ? new WeakRef(provider) : undefined
 
 		console.log(`[DEBUG] FileChangeManager created for task ${this.taskId}. Instance ID: ${this.instanceId}`)
 
@@ -69,6 +74,25 @@ export class FileChangeManager {
 		this.errorHandler = handler
 	}
 
+	/**
+	 * Check if file change tracking is enabled
+	 */
+	private isFileChangeTrackingEnabled(): boolean {
+		const provider = this.providerRef?.deref()
+		if (!provider) {
+			// If no provider reference, default to enabled for backward compatibility
+			return true
+		}
+
+		try {
+			return provider.getValue("filesChangedEnabled") ?? true
+		} catch (error) {
+			// If we can't get the state, default to enabled
+			console.warn("FileChangeManager: Could not check filesChangedEnabled setting, defaulting to enabled")
+			return true
+		}
+	}
+
 	/**
 	 * Create a FileChangeError from a generic error
 	 */
@@ -108,6 +132,12 @@ export class FileChangeManager {
 		linesAdded?: number,
 		linesRemoved?: number,
 	): void {
+		// Check if file change tracking is enabled
+		if (!this.isFileChangeTrackingEnabled()) {
+			console.log(`FileChangeManager: File change tracking is disabled, skipping recording for URI: ${uri}`)
+			return
+		}
+
 		console.log(
 			`FileChangeManager: Recording change for URI: ${uri}, Type: ${type}, From: ${fromCheckpoint}, To: ${toCheckpoint}`,
 		)

webview-ui/src/components/settings/InterfaceSettings.tsx

@@ -6,7 +6,6 @@ import { Monitor } from "lucide-react"
 import { SetCachedStateField } from "./types"
 import { SectionHeader } from "./SectionHeader"
 import { Section } from "./Section"
-import { vscode } from "@/utils/vscode"
 
 type InterfaceSettingsProps = HTMLAttributes<HTMLDivElement> & {
 	filesChangedEnabled?: boolean
@@ -38,10 +37,6 @@ export const InterfaceSettings = ({ filesChangedEnabled, setCachedStateField, ..
 							checked={filesChangedEnabled ?? true}
 							onChange={(e: any) => {
 								setCachedStateField("filesChangedEnabled", e.target.checked)
-								vscode.postMessage({
-									type: "filesChangedEnabled",
-									bool: e.target.checked,
-								})
 							}}
 							data-testid="files-changed-enabled-checkbox">
 							{t("settings:interface.filesChanged.enabled.label")}

webview-ui/src/components/settings/SettingsView.tsx

@@ -282,6 +282,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 			vscode.postMessage({ type: "autoCondenseContextPercent", value: autoCondenseContextPercent })
 			vscode.postMessage({ type: "browserToolEnabled", bool: browserToolEnabled })
 			vscode.postMessage({ type: "soundEnabled", bool: soundEnabled })
+			vscode.postMessage({ type: "filesChangedEnabled", bool: filesChangedEnabled })
 			vscode.postMessage({ type: "ttsEnabled", bool: ttsEnabled })
 			vscode.postMessage({ type: "ttsSpeed", value: ttsSpeed })
 			vscode.postMessage({ type: "soundVolume", value: soundVolume })