Skip to content

Commit 8e63064

Browse files
committed
Fix settings colors for themes that use color transparency
1 parent 1807408 commit 8e63064

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

webview-ui/src/components/settings/SectionHeader.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ type SectionHeaderProps = HTMLAttributes<HTMLDivElement> & {
88
}
99

1010
export const SectionHeader = ({ description, children, className, ...props }: SectionHeaderProps) => (
11-
<div className={cn("sticky top-0 z-10 bg-vscode-panel-border px-5 py-4", className)} {...props}>
11+
<div
12+
className={cn("sticky top-0 z-10 bg-vscode-sideBar-background dark:brightness-90 px-5 py-4", className)}
13+
{...props}>
1214
<h4 className="m-0">{children}</h4>
1315
{description && <p className="text-vscode-descriptionForeground text-sm mt-2 mb-0">{description}</p>}
1416
</div>

webview-ui/src/components/settings/SettingsView.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone },
242242

243243
return (
244244
<div className="fixed inset-0 flex flex-col overflow-hidden">
245-
<div className="px-5 py-2.5 border-b border-vscode-panel-border">
245+
<div className="px-5 py-2.5 border-b border-vscode-sideBar-border">
246246
<div className="flex flex-col">
247247
<div className="flex justify-between items-center">
248248
<div className="flex items-center gap-2">
@@ -287,7 +287,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone },
287287
</div>
288288

289289
<div
290-
className="flex flex-col flex-1 overflow-auto divide-y divide-vscode-panel-border"
290+
className="flex flex-col flex-1 overflow-auto divide-y divide-vscode-sideBar-border"
291291
onScroll={handleScroll}>
292292
<div ref={providersRef}>
293293
<SectionHeader>

webview-ui/src/index.css

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,14 @@
100100
--color-vscode-toolbar-hoverBackground: var(--vscode-toolbar-hoverBackground);
101101

102102
--color-vscode-panel-border: var(--vscode-panel-border);
103+
104+
--color-vscode-sideBar-foreground: var(--vscode-sideBar-foreground);
105+
--color-vscode-sideBar-background: var(--vscode-sideBar-background);
106+
--color-vscode-sideBar-border: var(--vscode-sideBar-border);
107+
108+
--color-vscode-sideBarSectionHeader-foreground: var(--vscode-sideBarSectionHeader-foreground);
109+
--color-vscode-sideBarSectionHeader-background: var(--vscode-sideBarSectionHeader-background);
110+
--color-vscode-sideBarSectionHeader-border: var(--vscode-sideBarSectionHeader-border);
103111
}
104112

105113
@layer base {

0 commit comments

Comments
 (0)