Skip to content

Commit 90ab20b

Browse files
committed
fix: propagate updateCustomMode errors to prevent false-positive import success
updateCustomMode() was catching and swallowing all errors, causing importModeWithRules() to return success even when mode persistence failed. This led to auto-switch attempting to activate modes that never persisted.
1 parent 2bdaff0 commit 90ab20b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/core/config/CustomModesManager.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ export class CustomModesManager {
412412
const errorMessage = `Invalid mode configuration: ${errorMessages}`
413413
logger.error("Mode validation failed", { slug, errors: validationResult.error.errors })
414414
vscode.window.showErrorMessage(t("common:customModes.errors.updateFailed", { error: errorMessage }))
415-
return
415+
throw new Error(errorMessage)
416416
}
417417

418418
const isProjectMode = config.source === "project"
@@ -458,6 +458,7 @@ export class CustomModesManager {
458458
const errorMessage = error instanceof Error ? error.message : String(error)
459459
logger.error("Failed to update custom mode", { slug, error: errorMessage })
460460
vscode.window.showErrorMessage(t("common:customModes.errors.updateFailed", { error: errorMessage }))
461+
throw error
461462
}
462463
}
463464

0 commit comments

Comments
 (0)