fix: remove unintended DISABLE_DIFF_VISUALIZATION feature from LaTeX PR

hannesrudolph · hannesrudolph · commit 913795302bf8 · 2025-06-17T12:11:05.000-06:00
- Removed DISABLE_DIFF_VISUALIZATION from experiment types and configurations
- Removed disableDiffVisualization parameter from Task and DiffViewProvider
- Removed all DISABLE_DIFF_VISUALIZATION translations from locale files
- Removed disable-diff-visualization changeset
- Keep only LaTeX rendering related changes in this PR
diff --git a/.changeset/disable-diff-visualization.md b/.changeset/disable-diff-visualization.md
diff --git a/packages/types/src/experiment.ts b/packages/types/src/experiment.ts
@@ -6,13 +6,7 @@ import type { Keys, Equals, AssertEqual } from "./type-fu.js"
  * ExperimentId
  */
 
-export const experimentIds = [
-	"powerSteering",
-	"disableCompletionCommand",
-	"marketplace",
-	"multiFileApplyDiff",
-	"disableDiffVisualization",
-] as const
+export const experimentIds = ["powerSteering", "disableCompletionCommand", "marketplace", "multiFileApplyDiff"] as const
 
 export const experimentIdsSchema = z.enum(experimentIds)
 
@@ -27,7 +21,6 @@ export const experimentsSchema = z.object({
 	disableCompletionCommand: z.boolean().optional(),
 	marketplace: z.boolean().optional(),
 	multiFileApplyDiff: z.boolean().optional(),
-	disableDiffVisualization: z.boolean().optional(),
 })
 
 export type Experiments = z.infer<typeof experimentsSchema>
diff --git a/src/core/task/Task.ts b/src/core/task/Task.ts
@@ -104,7 +104,6 @@ export type TaskOptions = {
 	provider: ClineProvider
 	apiConfiguration: ProviderSettings
 	enableDiff?: boolean
-	disableDiffVisualization?: boolean
 	enableCheckpoints?: boolean
 	fuzzyMatchThreshold?: number
 	consecutiveMistakeLimit?: number
@@ -199,7 +198,6 @@ export class Task extends EventEmitter<ClineEvents> {
 		provider,
 		apiConfiguration,
 		enableDiff = false,
-		disableDiffVisualization = false,
 		enableCheckpoints = true,
 		fuzzyMatchThreshold = 1.0,
 		consecutiveMistakeLimit = 3,
@@ -244,7 +242,7 @@ export class Task extends EventEmitter<ClineEvents> {
 		this.consecutiveMistakeLimit = consecutiveMistakeLimit
 		this.providerRef = new WeakRef(provider)
 		this.globalStoragePath = provider.context.globalStorageUri.fsPath
-		this.diffViewProvider = new DiffViewProvider(this.cwd, disableDiffVisualization)
+		this.diffViewProvider = new DiffViewProvider(this.cwd)
 		this.enableCheckpoints = enableCheckpoints
 
 		this.rootTask = rootTask
diff --git a/src/core/webview/ClineProvider.ts b/src/core/webview/ClineProvider.ts
@@ -538,8 +538,6 @@ export class ClineProvider
 			experiments,
 		} = await this.getState()
 
-		const disableDiffVisualization = experiments.disableDiffVisualization ?? false
-
 		if (!ProfileValidator.isProfileAllowed(apiConfiguration, organizationAllowList)) {
 			throw new OrganizationAllowListViolationError(t("common:errors.violated_organization_allowlist"))
 		}
@@ -548,7 +546,6 @@ export class ClineProvider
 			provider: this,
 			apiConfiguration,
 			enableDiff,
-			disableDiffVisualization,
 			enableCheckpoints,
 			fuzzyMatchThreshold,
 			task,
@@ -581,13 +578,10 @@ export class ClineProvider
 			experiments,
 		} = await this.getState()
 
-		const disableDiffVisualization = experiments.disableDiffVisualization ?? false
-
 		const cline = new Task({
 			provider: this,
 			apiConfiguration,
 			enableDiff,
-			disableDiffVisualization,
 			enableCheckpoints,
 			fuzzyMatchThreshold,
 			historyItem,
diff --git a/src/integrations/editor/DiffViewProvider.ts b/src/integrations/editor/DiffViewProvider.ts
@@ -34,10 +34,7 @@ export class DiffViewProvider {
 	private streamedLines: string[] = []
 	private preDiagnostics: [vscode.Uri, vscode.Diagnostic[]][] = []
 
-	constructor(
-		private cwd: string,
-		private disableDiffVisualization: boolean = false,
-	) {}
+	constructor(private cwd: string) {}
 
 	async open(relPath: string): Promise<void> {
 		this.relPath = relPath
@@ -95,13 +92,7 @@ export class DiffViewProvider {
 			this.documentWasOpen = true
 		}
 
-		// If diff visualization is disabled, open the file directly
-		if (this.disableDiffVisualization) {
-			const document = await vscode.workspace.openTextDocument(absolutePath)
-			this.activeDiffEditor = await vscode.window.showTextDocument(document, { preview: false })
-		} else {
-			this.activeDiffEditor = await this.openDiffEditor()
-		}
+		this.activeDiffEditor = await this.openDiffEditor()
 		this.fadedOverlayController = new DecorationController("fadedOverlay", this.activeDiffEditor)
 		this.activeLineController = new DecorationController("activeLine", this.activeDiffEditor)
 		// Apply faded overlay to all lines initially.
diff --git a/src/shared/__tests__/experiments.spec.ts b/src/shared/__tests__/experiments.spec.ts
@@ -30,7 +30,6 @@ describe("experiments", () => {
 				marketplace: false,
 				disableCompletionCommand: false,
 				multiFileApplyDiff: false,
-				disableDiffVisualization: false,
 			}
 			expect(Experiments.isEnabled(experiments, EXPERIMENT_IDS.POWER_STEERING)).toBe(false)
 		})
@@ -41,7 +40,6 @@ describe("experiments", () => {
 				marketplace: false,
 				disableCompletionCommand: false,
 				multiFileApplyDiff: false,
-				disableDiffVisualization: false,
 			}
 			expect(Experiments.isEnabled(experiments, EXPERIMENT_IDS.POWER_STEERING)).toBe(true)
 		})
@@ -52,7 +50,6 @@ describe("experiments", () => {
 				marketplace: false,
 				disableCompletionCommand: false,
 				multiFileApplyDiff: false,
-				disableDiffVisualization: false,
 			}
 			expect(Experiments.isEnabled(experiments, EXPERIMENT_IDS.POWER_STEERING)).toBe(false)
 		})
@@ -73,7 +70,6 @@ describe("experiments", () => {
 				marketplace: false,
 				disableCompletionCommand: false,
 				multiFileApplyDiff: false,
-				disableDiffVisualization: false,
 			}
 			expect(Experiments.isEnabled(experiments, EXPERIMENT_IDS.MARKETPLACE)).toBe(false)
 		})
@@ -84,7 +80,6 @@ describe("experiments", () => {
 				marketplace: true,
 				disableCompletionCommand: false,
 				multiFileApplyDiff: false,
-				disableDiffVisualization: false,
 			}
 			expect(Experiments.isEnabled(experiments, EXPERIMENT_IDS.MARKETPLACE)).toBe(true)
 		})
diff --git a/src/shared/experiments.ts b/src/shared/experiments.ts
@@ -5,7 +5,6 @@ export const EXPERIMENT_IDS = {
 	MULTI_FILE_APPLY_DIFF: "multiFileApplyDiff",
 	DISABLE_COMPLETION_COMMAND: "disableCompletionCommand",
 	POWER_STEERING: "powerSteering",
-	DISABLE_DIFF_VISUALIZATION: "disableDiffVisualization",
 } as const satisfies Record<string, ExperimentId>
 
 type _AssertExperimentIds = AssertEqual<Equals<ExperimentId, Values<typeof EXPERIMENT_IDS>>>
@@ -21,7 +20,6 @@ export const experimentConfigsMap: Record<ExperimentKey, ExperimentConfig> = {
 	MULTI_FILE_APPLY_DIFF: { enabled: false },
 	DISABLE_COMPLETION_COMMAND: { enabled: false },
 	POWER_STEERING: { enabled: false },
-	DISABLE_DIFF_VISUALIZATION: { enabled: false },
 }
 
 export const experimentDefault = Object.fromEntries(
diff --git a/webview-ui/src/context/__tests__/ExtensionStateContext.test.tsx b/webview-ui/src/context/__tests__/ExtensionStateContext.test.tsx
@@ -225,7 +225,6 @@ describe("mergeExtensionState", () => {
 				marketplace: false,
 				disableCompletionCommand: false,
 				multiFileApplyDiff: true,
-				disableDiffVisualization: false,
 			} as Record<ExperimentId, boolean>,
 		}
 
@@ -241,7 +240,6 @@ describe("mergeExtensionState", () => {
 			marketplace: false,
 			disableCompletionCommand: false,
 			multiFileApplyDiff: true,
-			disableDiffVisualization: false,
 		})
 	})
 })
diff --git a/webview-ui/src/i18n/locales/ca/settings.json b/webview-ui/src/i18n/locales/ca/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "Habilita edicions de fitxers concurrents",
 			"description": "Quan està activat, Roo pot editar múltiples fitxers en una sola petició. Quan està desactivat, Roo ha d'editar fitxers d'un en un. Desactivar això pot ajudar quan es treballa amb models menys capaços o quan vols més control sobre les modificacions de fitxers."
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "Desactivar la visualització de diferències per a totes les eines d'edició",
-			"description": "Quan estigui activat, els fitxers s'obriran directament a l'editor en lloc de mostrar una vista de diferències per a totes les eines d'edició (write_to_file, apply_diff, insert_content, search_and_replace). Això ajuda a prevenir bloquejos de LSP amb fitxers molt grans. Els canvis encara són visibles a la finestra de xat."
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/de/settings.json b/webview-ui/src/i18n/locales/de/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "Gleichzeitige Dateibearbeitungen aktivieren",
 			"description": "Wenn aktiviert, kann Roo mehrere Dateien in einer einzigen Anfrage bearbeiten. Wenn deaktiviert, muss Roo Dateien einzeln bearbeiten. Das Deaktivieren kann helfen, wenn du mit weniger fähigen Modellen arbeitest oder mehr Kontrolle über Dateiänderungen haben möchtest."
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "Diff-Visualisierung für alle Bearbeitungswerkzeuge deaktivieren",
-			"description": "Wenn aktiviert, werden Dateien direkt im Editor geöffnet, anstatt eine Diff-Ansicht für alle Bearbeitungswerkzeuge (write_to_file, apply_diff, insert_content, search_and_replace) anzuzeigen. Dies hilft, LSP-Abstürze bei sehr großen Dateien zu vermeiden. Änderungen sind weiterhin im Chatfenster sichtbar."
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/en/settings.json b/webview-ui/src/i18n/locales/en/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "Enable concurrent file edits",
 			"description": "When enabled, Roo can edit multiple files in a single request. When disabled, Roo must edit files one at a time. Disabling this can help when working with less capable models or when you want more control over file modifications."
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "Disable diff visualization for all edit tools",
-			"description": "When enabled, files will open directly in the editor instead of showing a diff view for all edit tools (write_to_file, apply_diff, insert_content, search_and_replace). This helps prevent LSP crashes with very large files. Changes are still visible in the chat window."
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/es/settings.json b/webview-ui/src/i18n/locales/es/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "Habilitar ediciones de archivos concurrentes",
 			"description": "Cuando está habilitado, Roo puede editar múltiples archivos en una sola solicitud. Cuando está deshabilitado, Roo debe editar archivos de uno en uno. Deshabilitar esto puede ayudar cuando trabajas con modelos menos capaces o cuando quieres más control sobre las modificaciones de archivos."
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "Desactivar la visualización de diferencias para todas las herramientas de edición",
-			"description": "Cuando está habilitado, los archivos se abrirán directamente en el editor en lugar de mostrar una vista de diferencias para todas las herramientas de edición (write_to_file, apply_diff, insert_content, search_and_replace). Esto ayuda a prevenir bloqueos de LSP con archivos muy grandes. Los cambios siguen siendo visibles en la ventana de chat."
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/fr/settings.json b/webview-ui/src/i18n/locales/fr/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "Activer les éditions de fichiers concurrentes",
 			"description": "Lorsque cette option est activée, Roo peut éditer plusieurs fichiers en une seule requête. Lorsqu'elle est désactivée, Roo doit éditer les fichiers un par un. Désactiver cette option peut aider lorsque tu travailles avec des modèles moins capables ou lorsque tu veux plus de contrôle sur les modifications de fichiers."
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "Désactiver la visualisation des différences pour tous les outils d'édition",
-			"description": "Lorsqu'il est activé, les fichiers s'ouvrent directement dans l'éditeur au lieu d'afficher une vue différentielle pour tous les outils d'édition (write_to_file, apply_diff, insert_content, search_and_replace). Cela permet d'éviter les plantages du LSP avec des fichiers très volumineux. Les modifications sont toujours visibles dans la fenêtre de discussion."
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/hi/settings.json b/webview-ui/src/i18n/locales/hi/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "समानांतर फ़ाइल संपादन सक्षम करें",
 			"description": "जब सक्षम किया जाता है, तो Roo एक ही अनुरोध में कई फ़ाइलों को संपादित कर सकता है। जब अक्षम किया जाता है, तो Roo को एक समय में एक फ़ाइल संपादित करनी होगी। इसे अक्षम करना तब मदद कर सकता है जब आप कम सक्षम मॉडल के साथ काम कर रहे हों या जब आप फ़ाइल संशोधनों पर अधिक नियंत्रण चाहते हों।"
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "सभी संपादन टूल के लिए डिफ विज़ुअलाइज़ेशन अक्षम करें",
-			"description": "सक्षम होने पर, फ़ाइलें सभी संपादन टूल (write_to_file, apply_diff, insert_content, search_and_replace) के लिए डिफ व्यू दिखाने के बजाय सीधे संपादक में खुलेंगी। यह बहुत बड़ी फ़ाइलों के साथ एलएसपी क्रैश को रोकने में मदद करता है। परिवर्तन अभी भी चैट विंडो में दिखाई दे रहे हैं।"
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/id/settings.json b/webview-ui/src/i18n/locales/id/settings.json
@@ -537,10 +537,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "Aktifkan edit file bersamaan",
 			"description": "Ketika diaktifkan, Roo dapat mengedit beberapa file dalam satu permintaan. Ketika dinonaktifkan, Roo harus mengedit file satu per satu. Menonaktifkan ini dapat membantu saat bekerja dengan model yang kurang mampu atau ketika kamu ingin kontrol lebih terhadap modifikasi file."
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "Nonaktifkan visualisasi perbedaan untuk semua alat edit",
-			"description": "Saat diaktifkan, file akan terbuka langsung di editor alih-alih menampilkan tampilan perbedaan untuk semua alat edit (write_to_file, apply_diff, insert_content, search_and_replace). Ini membantu mencegah mogok LSP pada file yang sangat besar. Perubahan masih terlihat di jendela obrolan."
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/it/settings.json b/webview-ui/src/i18n/locales/it/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "Abilita modifiche di file concorrenti",
 			"description": "Quando abilitato, Roo può modificare più file in una singola richiesta. Quando disabilitato, Roo deve modificare i file uno alla volta. Disabilitare questa opzione può aiutare quando lavori con modelli meno capaci o quando vuoi più controllo sulle modifiche dei file."
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "Disabilita la visualizzazione delle differenze per tutti gli strumenti di modifica",
-			"description": "Quando abilitato, i file si apriranno direttamente nell'editor invece di mostrare una vista delle differenze per tutti gli strumenti di modifica (write_to_file, apply_diff, insert_content, search_and_replace). Ciò aiuta a prevenire arresti anomali del LSP con file di grandi dimensioni. Le modifiche sono ancora visibili nella finestra della chat."
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/ja/settings.json b/webview-ui/src/i18n/locales/ja/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "同時ファイル編集を有効にする",
 			"description": "有効にすると、Rooは単一のリクエストで複数のファイルを編集できます。無効にすると、Rooはファイルを一つずつ編集する必要があります。これを無効にすることで、能力の低いモデルで作業する場合や、ファイル変更をより細かく制御したい場合に役立ちます。"
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "すべての編集ツールの差分視覚化を無効にする",
-			"description": "有効にすると、すべての編集ツール（write_to_file、apply_diff、insert_content、search_and_replace）で差分ビューを表示する代わりに、ファイルがエディターで直接開きます。これにより、非常に大きなファイルでのLSPクラッシュを防ぐことができます。変更はチャットウィンドウで引き続き表示されます。"
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/ko/settings.json b/webview-ui/src/i18n/locales/ko/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "동시 파일 편집 활성화",
 			"description": "활성화하면 Roo가 단일 요청으로 여러 파일을 편집할 수 있습니다. 비활성화하면 Roo는 파일을 하나씩 편집해야 합니다. 이 기능을 비활성화하면 덜 강력한 모델로 작업하거나 파일 수정에 대한 더 많은 제어가 필요할 때 도움이 됩니다."
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "모든 편집 도구에 대한 diff 시각화 비활성화",
-			"description": "활성화하면 모든 편집 도구(write_to_file, apply_diff, insert_content, search_and_replace)에 대한 diff 보기를 표시하는 대신 편집기에서 파일이 직접 열립니다. 이렇게 하면 매우 큰 파일에서 LSP 충돌을 방지하는 데 도움이 됩니다. 변경 사항은 채팅 창에 계속 표시됩니다."
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/nl/settings.json b/webview-ui/src/i18n/locales/nl/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "Gelijktijdige bestandsbewerkingen inschakelen",
 			"description": "Wanneer ingeschakeld, kan Roo meerdere bestanden in één verzoek bewerken. Wanneer uitgeschakeld, moet Roo bestanden één voor één bewerken. Het uitschakelen hiervan kan helpen wanneer je werkt met minder capabele modellen of wanneer je meer controle wilt over bestandswijzigingen."
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "Diff-visualisatie uitschakelen voor alle bewerkingstools",
-			"description": "Indien ingeschakeld, worden bestanden rechtstreeks in de editor geopend in plaats van een diff-weergave voor alle bewerkingstools (write_to_file, apply_diff, insert_content, search_and_replace). Dit helpt LSP-crashes met zeer grote bestanden te voorkomen. Wijzigingen zijn nog steeds zichtbaar in het chatvenster."
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/pl/settings.json b/webview-ui/src/i18n/locales/pl/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "Włącz równoczesne edycje plików",
 			"description": "Gdy włączone, Roo może edytować wiele plików w jednym żądaniu. Gdy wyłączone, Roo musi edytować pliki jeden po drugim. Wyłączenie tego może pomóc podczas pracy z mniej zdolnymi modelami lub gdy chcesz mieć większą kontrolę nad modyfikacjami plików."
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "Wyłącz wizualizację różnic dla wszystkich narzędzi do edycji",
-			"description": "Po włączeniu pliki będą otwierane bezpośrednio w edytorze, zamiast pokazywać widok różnic dla wszystkich narzędzi do edycji (write_to_file, apply_diff, insert_content, search_and_replace). Pomaga to zapobiegać awariom LSP w przypadku bardzo dużych plików. Zmiany są nadal widoczne w oknie czatu."
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/pt-BR/settings.json b/webview-ui/src/i18n/locales/pt-BR/settings.json
@@ -508,10 +508,6 @@
 		"MULTI_FILE_APPLY_DIFF": {
 			"name": "Habilitar edições de arquivos concorrentes",
 			"description": "Quando habilitado, o Roo pode editar múltiplos arquivos em uma única solicitação. Quando desabilitado, o Roo deve editar arquivos um de cada vez. Desabilitar isso pode ajudar ao trabalhar com modelos menos capazes ou quando você quer mais controle sobre modificações de arquivos."
-		},
-		"DISABLE_DIFF_VISUALIZATION": {
-			"name": "Desativar a visualização de diferenças para todas as ferramentas de edição",
-			"description": "Quando ativado, os arquivos serão abertos diretamente no editor em vez de mostrar uma visualização de diferenças para todas as ferramentas de edição (write_to_file, apply_diff, insert_content, search_and_replace). Isso ajuda a evitar travamentos do LSP com arquivos muito grandes. As alterações ainda são visíveis na janela de bate-papo."
 		}
 	},
 	"promptCaching": {
diff --git a/webview-ui/src/i18n/locales/ru/settings.json b/webview-ui/src/i18n/locales/ru/settings.json
diff --git a/webview-ui/src/i18n/locales/tr/settings.json b/webview-ui/src/i18n/locales/tr/settings.json
diff --git a/webview-ui/src/i18n/locales/vi/settings.json b/webview-ui/src/i18n/locales/vi/settings.json
diff --git a/webview-ui/src/i18n/locales/zh-CN/settings.json b/webview-ui/src/i18n/locales/zh-CN/settings.json
diff --git a/webview-ui/src/i18n/locales/zh-TW/settings.json b/webview-ui/src/i18n/locales/zh-TW/settings.json
