fix: address critical PR review feedback

- Fix error classification to include 'required' keyword for configuration errors
- Add localization for error type headings in CodeIndexSettings
- Update all language files with appropriate translations for error types

Author: hannesrudolph

src/services/code-index/manager.ts

@@ -264,7 +264,11 @@ export class CodeIndexManager {
 			let errorMessage = error instanceof Error ? error.message : String(error)
 			let suggestion: string | undefined
 
-			if (errorMessage.includes("configuration missing") || errorMessage.includes("missing for")) {
+			if (
+				errorMessage.includes("configuration missing") ||
+				errorMessage.includes("missing for") ||
+				errorMessage.includes("required")
+			) {
 				errorType = "configuration"
 				suggestion = "Please check your embedder configuration in the settings."
 			} else if (errorMessage.includes("authentication") || errorMessage.includes("API key")) {

webview-ui/src/components/settings/CodeIndexSettings.tsx

@@ -272,12 +272,16 @@ export const CodeIndexSettings: React.FC<CodeIndexSettingsProps> = ({
 								<span className="codicon codicon-error text-vscode-inputValidation-errorForeground flex-shrink-0 mt-0.5"></span>
 								<div className="flex-1">
 									<div className="text-sm font-medium text-vscode-inputValidation-errorForeground mb-1">
-										{indexingStatus.errorDetails.type === "configuration" && "Configuration Error"}
+										{indexingStatus.errorDetails.type === "configuration" &&
+											t("settings:codeIndex.configurationError")}
 										{indexingStatus.errorDetails.type === "authentication" &&
-											"Authentication Error"}
-										{indexingStatus.errorDetails.type === "network" && "Network Error"}
-										{indexingStatus.errorDetails.type === "validation" && "Validation Error"}
-										{indexingStatus.errorDetails.type === "unknown" && "Unknown Error"}
+											t("settings:codeIndex.authenticationError")}
+										{indexingStatus.errorDetails.type === "network" &&
+											t("settings:codeIndex.networkError")}
+										{indexingStatus.errorDetails.type === "validation" &&
+											t("settings:codeIndex.validationError")}
+										{indexingStatus.errorDetails.type === "unknown" &&
+											t("settings:codeIndex.unknownError")}
 									</div>
 									<div className="text-sm text-vscode-foreground mb-2">
 										{indexingStatus.errorDetails.message}

webview-ui/src/i18n/locales/ca/settings.json

@@ -73,7 +73,12 @@
 			"confirmButton": "Esborrar dades"
 		},
 		"testConfigButton": "Prova la configuració",
-		"testingButton": "Provant..."
+		"testingButton": "Provant...",
+		"configurationError": "Error de configuració",
+		"authenticationError": "Error d'autenticació",
+		"networkError": "Error de xarxa",
+		"validationError": "Error de validació",
+		"unknownError": "Error desconegut"
 	},
 	"autoApprove": {
 		"description": "Permet que Roo realitzi operacions automàticament sense requerir aprovació. Activeu aquesta configuració només si confieu plenament en la IA i enteneu els riscos de seguretat associats.",

webview-ui/src/i18n/locales/de/settings.json

@@ -73,7 +73,12 @@
 			"confirmButton": "Daten löschen"
 		},
 		"testConfigButton": "Konfiguration testen",
-		"testingButton": "Testen..."
+		"testingButton": "Testen...",
+		"configurationError": "Konfigurationsfehler",
+		"authenticationError": "Authentifizierungsfehler",
+		"networkError": "Netzwerkfehler",
+		"validationError": "Validierungsfehler",
+		"unknownError": "Unbekannter Fehler"
 	},
 	"autoApprove": {
 		"description": "Erlaubt Roo, Operationen automatisch ohne Genehmigung durchzuführen. Aktiviere diese Einstellungen nur, wenn du der KI vollständig vertraust und die damit verbundenen Sicherheitsrisiken verstehst.",

webview-ui/src/i18n/locales/en/settings.json

@@ -73,7 +73,12 @@
 			"description": "This action cannot be undone. This will permanently delete your codebase index data.",
 			"cancelButton": "Cancel",
 			"confirmButton": "Clear Data"
-		}
+		},
+		"configurationError": "Configuration Error",
+		"authenticationError": "Authentication Error",
+		"networkError": "Network Error",
+		"validationError": "Validation Error",
+		"unknownError": "Unknown Error"
 	},
 	"autoApprove": {
 		"description": "Allow Roo to automatically perform operations without requiring approval. Enable these settings only if you fully trust the AI and understand the associated security risks.",

webview-ui/src/i18n/locales/es/settings.json

@@ -73,7 +73,12 @@
 			"confirmButton": "Borrar datos"
 		},
 		"testConfigButton": "Probar configuración",
-		"testingButton": "Probando..."
+		"testingButton": "Probando...",
+		"configurationError": "Error de configuración",
+		"authenticationError": "Error de autenticación",
+		"networkError": "Error de red",
+		"validationError": "Error de validación",
+		"unknownError": "Error desconocido"
 	},
 	"autoApprove": {
 		"description": "Permitir que Roo realice operaciones automáticamente sin requerir aprobación. Habilite esta configuración solo si confía plenamente en la IA y comprende los riesgos de seguridad asociados.",

webview-ui/src/i18n/locales/fr/settings.json

@@ -73,7 +73,12 @@
 			"confirmButton": "Effacer les données"
 		},
 		"testConfigButton": "Tester la configuration",
-		"testingButton": "Test en cours..."
+		"testingButton": "Test en cours...",
+		"configurationError": "Erreur de configuration",
+		"authenticationError": "Erreur d'authentification",
+		"networkError": "Erreur réseau",
+		"validationError": "Erreur de validation",
+		"unknownError": "Erreur inconnue"
 	},
 	"autoApprove": {
 		"description": "Permettre à Roo d'effectuer automatiquement des opérations sans requérir d'approbation. Activez ces paramètres uniquement si vous faites entièrement confiance à l'IA et que vous comprenez les risques de sécurité associés.",

webview-ui/src/i18n/locales/hi/settings.json

@@ -73,7 +73,12 @@
 			"confirmButton": "डेटा साफ़ करें"
 		},
 		"testConfigButton": "कॉन्फ़िगरेशन का परीक्षण करें",
-		"testingButton": "परीक्षण हो रहा है..."
+		"testingButton": "परीक्षण हो रहा है...",
+		"configurationError": "कॉन्फ़िगरेशन त्रुटि",
+		"authenticationError": "प्रमाणीकरण त्रुटि",
+		"networkError": "नेटवर्क त्रुटि",
+		"validationError": "सत्यापन त्रुटि",
+		"unknownError": "अज्ञात त्रुटि"
 	},
 	"autoApprove": {
 		"description": "Roo को अनुमोदन की आवश्यकता के बिना स्वचालित रूप से ऑपरेशन करने की अनुमति दें। इन सेटिंग्स को केवल तभी सक्षम करें जब आप AI पर पूरी तरह से भरोसा करते हों और संबंधित सुरक्षा जोखिमों को समझते हों।",

webview-ui/src/i18n/locales/id/settings.json

@@ -73,7 +73,12 @@
 			"confirmButton": "Hapus Data"
 		},
 		"testConfigButton": "Uji Konfigurasi",
-		"testingButton": "Menguji..."
+		"testingButton": "Menguji...",
+		"configurationError": "Kesalahan Konfigurasi",
+		"authenticationError": "Kesalahan Otentikasi",
+		"networkError": "Kesalahan Jaringan",
+		"validationError": "Kesalahan Validasi",
+		"unknownError": "Kesalahan Tidak Dikenal"
 	},
 	"autoApprove": {
 		"description": "Izinkan Roo untuk secara otomatis melakukan operasi tanpa memerlukan persetujuan. Aktifkan pengaturan ini hanya jika kamu sepenuhnya mempercayai AI dan memahami risiko keamanan yang terkait.",

webview-ui/src/i18n/locales/it/settings.json

@@ -73,7 +73,12 @@
 			"confirmButton": "Cancella dati"
 		},
 		"testConfigButton": "Testa configurazione",
-		"testingButton": "Test in corso..."
+		"testingButton": "Test in corso...",
+		"configurationError": "Errore di configurazione",
+		"authenticationError": "Errore di autenticazione",
+		"networkError": "Errore di rete",
+		"validationError": "Errore di validazione",
+		"unknownError": "Errore sconosciuto"
 	},
 	"autoApprove": {
 		"description": "Permetti a Roo di eseguire automaticamente operazioni senza richiedere approvazione. Abilita queste impostazioni solo se ti fidi completamente dell'IA e comprendi i rischi di sicurezza associati.",