Fix #5294: Prevent Architect mode from providing time estimates (#5295)

roomote · mrubens · web-flow · commit 951f2d0fad6d · 2025-07-01T09:42:46.000-04:00
* Fixes #5294: Add instruction to Architect mode to avoid time estimates - Updated Architect mode custom instructions to explicitly prohibit providing time estimates - Added clear guidance to focus on actionable plans without speculating about implementation timeframes - Updated test snapshot to reflect the new instruction - All tests passing * More tweaks to prompt --------- Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com>
diff --git a/src/core/prompts/__tests__/__snapshots__/add-custom-instructions/architect-mode-prompt.snap b/src/core/prompts/__tests__/__snapshots__/add-custom-instructions/architect-mode-prompt.snap
@@ -483,9 +483,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/core/prompts/__tests__/__snapshots__/add-custom-instructions/mcp-server-creation-disabled.snap b/src/core/prompts/__tests__/__snapshots__/add-custom-instructions/mcp-server-creation-disabled.snap
@@ -545,9 +545,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/core/prompts/__tests__/__snapshots__/add-custom-instructions/mcp-server-creation-enabled.snap b/src/core/prompts/__tests__/__snapshots__/add-custom-instructions/mcp-server-creation-enabled.snap
@@ -551,9 +551,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/core/prompts/__tests__/__snapshots__/add-custom-instructions/partial-reads-enabled.snap b/src/core/prompts/__tests__/__snapshots__/add-custom-instructions/partial-reads-enabled.snap
@@ -488,9 +488,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/core/prompts/__tests__/__snapshots__/system-prompt/consistent-system-prompt.snap b/src/core/prompts/__tests__/__snapshots__/system-prompt/consistent-system-prompt.snap
@@ -483,9 +483,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/core/prompts/__tests__/__snapshots__/system-prompt/with-computer-use-support.snap b/src/core/prompts/__tests__/__snapshots__/system-prompt/with-computer-use-support.snap
@@ -539,9 +539,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/core/prompts/__tests__/__snapshots__/system-prompt/with-diff-enabled-false.snap b/src/core/prompts/__tests__/__snapshots__/system-prompt/with-diff-enabled-false.snap
@@ -483,9 +483,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/core/prompts/__tests__/__snapshots__/system-prompt/with-diff-enabled-true.snap b/src/core/prompts/__tests__/__snapshots__/system-prompt/with-diff-enabled-true.snap
@@ -571,9 +571,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/core/prompts/__tests__/__snapshots__/system-prompt/with-diff-enabled-undefined.snap b/src/core/prompts/__tests__/__snapshots__/system-prompt/with-diff-enabled-undefined.snap
@@ -483,9 +483,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/core/prompts/__tests__/__snapshots__/system-prompt/with-different-viewport-size.snap b/src/core/prompts/__tests__/__snapshots__/system-prompt/with-different-viewport-size.snap
@@ -539,9 +539,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/core/prompts/__tests__/__snapshots__/system-prompt/with-mcp-hub-provided.snap b/src/core/prompts/__tests__/__snapshots__/system-prompt/with-mcp-hub-provided.snap
@@ -551,9 +551,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/core/prompts/__tests__/__snapshots__/system-prompt/with-undefined-mcp-hub.snap b/src/core/prompts/__tests__/__snapshots__/system-prompt/with-undefined-mcp-hub.snap
@@ -483,9 +483,9 @@ Mode-specific Instructions:
 
 4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.
 
-5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.
+5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
 
-6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.
+**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**
 
 Rules:
 # Rules from .clinerules-architect:
diff --git a/src/shared/modes.ts b/src/shared/modes.ts
@@ -72,7 +72,7 @@ export const modes: readonly ModeConfig[] = [
 		description: "Plan and design before implementation",
 		groups: ["read", ["edit", { fileRegex: "\\.md$", description: "Markdown files only" }], "browser", "mcp"],
 		customInstructions:
-			"1. Do some information gathering (for example using read_file or search_files) to get more context about the task.\n\n2. You should also ask the user clarifying questions to get a better understanding of the task.\n\n3. Once you've gained more context about the user's request, you should create a detailed plan for how to accomplish the task. Include Mermaid diagrams if they help make your plan clearer.\n\n4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.\n\n5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.\n\n6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.",
+			"1. Do some information gathering (for example using read_file or search_files) to get more context about the task.\n\n2. You should also ask the user clarifying questions to get a better understanding of the task.\n\n3. Once you've gained more context about the user's request, you should create a detailed plan for how to accomplish the task. Include Mermaid diagrams if they help make your plan clearer.\n\n4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.\n\n5. Use the switch_mode tool to request that the user switch to another mode to implement the solution.\n\n**IMPORTANT: Do not provide time estimates for how long tasks will take to complete. Focus on creating clear, actionable plans without speculating about implementation timeframes.**",
 	},
 	{
 		slug: "code",
