fix: address PR feedback for minimal reasoning support

- OpenRouter now returns undefined for "minimal" reasoning effort
- Removed duplicate ReasoningEffort type, using ReasoningEffortWithMinimal consistently
- Fixed test expectations to match new behavior
- Extracted UI logic into shouldShowMinimalOption helper function
- Translation key for "minimal" already exists in settings.json

Author: roomote

src/api/transform/__tests__/reasoning.spec.ts

@@ -165,7 +165,6 @@ describe("reasoning.ts", () => {
 				const modelWithEffort: ModelInfo = {
 					...baseModel,
 					supportsReasoningEffort: true,
-					reasoningEffort: effort === "minimal" ? undefined : effort,
 				}
 
 				const settingsWithEffort: ProviderSettings = {
@@ -179,7 +178,12 @@ describe("reasoning.ts", () => {
 					reasoningEffort: effort,
 				}
 				const result = getOpenRouterReasoning(options)
-				expect(result).toEqual({ effort })
+				// "minimal" should return undefined for OpenRouter
+				if (effort === "minimal") {
+					expect(result).toBeUndefined()
+				} else {
+					expect(result).toEqual({ effort })
+				}
 			})
 		})
 
@@ -202,7 +206,8 @@ describe("reasoning.ts", () => {
 
 			const result = getOpenRouterReasoning(options)
 
-			expect(result).toEqual({ effort: "minimal" })
+			// "minimal" should return undefined for OpenRouter
+			expect(result).toBeUndefined()
 		})
 
 		it("should handle minimal reasoning effort from settings", () => {
@@ -224,7 +229,8 @@ describe("reasoning.ts", () => {
 
 			const result = getOpenRouterReasoning(options)
 
-			expect(result).toEqual({ effort: "minimal" })
+			// "minimal" should return undefined for OpenRouter
+			expect(result).toBeUndefined()
 		})
 
 		it("should handle zero reasoningBudget", () => {

src/api/transform/reasoning.ts

@@ -6,10 +6,8 @@ import type { ModelInfo, ProviderSettings, ReasoningEffortWithMinimal } from "@r
 
 import { shouldUseReasoningBudget, shouldUseReasoningEffort } from "../../shared/api"
 
-type ReasoningEffort = "minimal" | "low" | "medium" | "high"
-
 export type OpenRouterReasoningParams = {
-	effort?: ReasoningEffort
+	effort?: ReasoningEffortWithMinimal
 	max_tokens?: number
 	exclude?: boolean
 }
@@ -36,7 +34,7 @@ export const getOpenRouterReasoning = ({
 	shouldUseReasoningBudget({ model, settings })
 		? { max_tokens: reasoningBudget }
 		: shouldUseReasoningEffort({ model, settings })
-			? reasoningEffort
+			? reasoningEffort && reasoningEffort !== "minimal"
 				? { effort: reasoningEffort }
 				: undefined
 			: undefined

webview-ui/src/components/settings/ThinkingBudget.tsx

@@ -24,6 +24,17 @@ interface ThinkingBudgetProps {
 	modelInfo?: ModelInfo
 }
 
+// Helper function to determine if minimal option should be shown
+const shouldShowMinimalOption = (
+	provider: string | undefined,
+	modelId: string | undefined,
+	supportsEffort: boolean | undefined,
+): boolean => {
+	const isGpt5Model = provider === "openai-native" && modelId?.startsWith("gpt-5")
+	const isOpenRouterWithEffort = provider === "openrouter" && supportsEffort === true
+	return !!(isGpt5Model || isOpenRouterWithEffort)
+}
+
 export const ThinkingBudget = ({ apiConfiguration, setApiConfigurationField, modelInfo }: ThinkingBudgetProps) => {
 	const { t } = useAppTranslation()
 	const { id: selectedModelId } = useSelectedModel(apiConfiguration)
@@ -37,14 +48,15 @@ export const ThinkingBudget = ({ apiConfiguration, setApiConfigurationField, mod
 	const isReasoningBudgetRequired = !!modelInfo && modelInfo.requiredReasoningBudget
 	const isReasoningEffortSupported = !!modelInfo && modelInfo.supportsReasoningEffort
 
-	// Check if this is a GPT-5 model or OpenRouter to show "minimal" option
-	const isOpenAiNativeProvider = apiConfiguration.apiProvider === "openai-native"
-	const isOpenRouterProvider = apiConfiguration.apiProvider === "openrouter"
-	const isGpt5Model = isOpenAiNativeProvider && selectedModelId && selectedModelId.startsWith("gpt-5")
-	// Add "minimal" option for GPT-5 models and OpenRouter models that support reasoning effort
-	// Spread to convert readonly tuple into a mutable array, then expose as readonly for safety
+	// Determine if minimal option should be shown
+	const showMinimalOption = shouldShowMinimalOption(
+		apiConfiguration.apiProvider,
+		selectedModelId,
+		isReasoningEffortSupported,
+	)
+
+	// Build available reasoning efforts list
 	const baseEfforts = [...reasoningEfforts] as ReasoningEffortWithMinimal[]
-	const showMinimalOption = isGpt5Model || (isOpenRouterProvider && isReasoningEffortSupported)
 	const availableReasoningEfforts: ReadonlyArray<ReasoningEffortWithMinimal> = showMinimalOption
 		? (["minimal", ...baseEfforts] as ReasoningEffortWithMinimal[])
 		: baseEfforts