PR feedback

Author: mrubens

src/activate/__tests__/registerCommands.test.ts

@@ -0,0 +1,54 @@
+jest.mock("vscode", () => ({
+	CodeActionKind: {
+		QuickFix: { value: "quickfix" },
+		RefactorRewrite: { value: "refactor.rewrite" },
+	},
+	window: {
+		createTextEditorDecorationType: jest.fn().mockReturnValue({ dispose: jest.fn() }),
+	},
+}))
+
+import * as vscode from "vscode"
+import { ClineProvider } from "../../core/webview/ClineProvider"
+
+// Import the helper function from the actual file
+import { getVisibleProviderOrLog } from "../registerCommands"
+
+jest.mock("../../core/webview/ClineProvider")
+
+describe("getVisibleProviderOrLog", () => {
+	let mockOutputChannel: vscode.OutputChannel
+
+	beforeEach(() => {
+		mockOutputChannel = {
+			appendLine: jest.fn(),
+			append: jest.fn(),
+			clear: jest.fn(),
+			hide: jest.fn(),
+			name: "mock",
+			replace: jest.fn(),
+			show: jest.fn(),
+			dispose: jest.fn(),
+		}
+		jest.clearAllMocks()
+	})
+
+	it("returns the visible provider if found", () => {
+		const mockProvider = {} as ClineProvider
+		;(ClineProvider.getVisibleInstance as jest.Mock).mockReturnValue(mockProvider)
+
+		const result = getVisibleProviderOrLog(mockOutputChannel)
+
+		expect(result).toBe(mockProvider)
+		expect(mockOutputChannel.appendLine).not.toHaveBeenCalled()
+	})
+
+	it("logs and returns undefined if no provider found", () => {
+		;(ClineProvider.getVisibleInstance as jest.Mock).mockReturnValue(undefined)
+
+		const result = getVisibleProviderOrLog(mockOutputChannel)
+
+		expect(result).toBeUndefined()
+		expect(mockOutputChannel.appendLine).toHaveBeenCalledWith("Cannot find any visible Cline instances.")
+	})
+})

src/activate/registerCommands.ts

@@ -3,6 +3,18 @@ import delay from "delay"
 
 import { ClineProvider } from "../core/webview/ClineProvider"
 
+/**
+ * Helper to get the visible ClineProvider instance or log if not found.
+ */
+export function getVisibleProviderOrLog(outputChannel: vscode.OutputChannel): ClineProvider | undefined {
+	const visibleProvider = ClineProvider.getVisibleInstance()
+	if (!visibleProvider) {
+		outputChannel.appendLine("Cannot find any visible Cline instances.")
+		return undefined
+	}
+	return visibleProvider
+}
+
 import { registerHumanRelayCallback, unregisterHumanRelayCallback, handleHumanRelayResponse } from "./humanRelay"
 import { handleNewTask } from "./handleTask"
 
@@ -52,47 +64,32 @@ const getCommandsMap = ({ context, outputChannel, provider }: RegisterCommandOpt
 	return {
 		"roo-cline.activationCompleted": () => {},
 		"roo-cline.plusButtonClicked": async () => {
-			const visibleProvider = ClineProvider.getVisibleInstance()
-			if (!visibleProvider) {
-				outputChannel.appendLine("Cannot find any visible Cline instances.")
-				return
-			}
+			const visibleProvider = getVisibleProviderOrLog(outputChannel)
+			if (!visibleProvider) return
 			await visibleProvider.removeClineFromStack()
 			await visibleProvider.postStateToWebview()
 			await visibleProvider.postMessageToWebview({ type: "action", action: "chatButtonClicked" })
 		},
 		"roo-cline.mcpButtonClicked": () => {
-			const visibleProvider = ClineProvider.getVisibleInstance()
-			if (!visibleProvider) {
-				outputChannel.appendLine("Cannot find any visible Cline instances.")
-				return
-			}
+			const visibleProvider = getVisibleProviderOrLog(outputChannel)
+			if (!visibleProvider) return
 			visibleProvider.postMessageToWebview({ type: "action", action: "mcpButtonClicked" })
 		},
 		"roo-cline.promptsButtonClicked": () => {
-			const visibleProvider = ClineProvider.getVisibleInstance()
-			if (!visibleProvider) {
-				outputChannel.appendLine("Cannot find any visible Cline instances.")
-				return
-			}
+			const visibleProvider = getVisibleProviderOrLog(outputChannel)
+			if (!visibleProvider) return
 			visibleProvider.postMessageToWebview({ type: "action", action: "promptsButtonClicked" })
 		},
 		"roo-cline.popoutButtonClicked": () => openClineInNewTab({ context, outputChannel }),
 		"roo-cline.openInNewTab": () => openClineInNewTab({ context, outputChannel }),
 		"roo-cline.settingsButtonClicked": () => {
-			const visibleProvider = ClineProvider.getVisibleInstance()
-			if (!visibleProvider) {
-				outputChannel.appendLine("Cannot find any visible Cline instances.")
-				return
-			}
+			const visibleProvider = getVisibleProviderOrLog(outputChannel)
+			if (!visibleProvider) return
 			visibleProvider.postMessageToWebview({ type: "action", action: "settingsButtonClicked" })
 		},
 		"roo-cline.historyButtonClicked": () => {
-			const visibleProvider = ClineProvider.getVisibleInstance()
-			if (!visibleProvider) {
-				outputChannel.appendLine("Cannot find any visible Cline instances.")
-				return
-			}
+			const visibleProvider = getVisibleProviderOrLog(outputChannel)
+			if (!visibleProvider) return
 			visibleProvider.postMessageToWebview({ type: "action", action: "historyButtonClicked" })
 		},
 		"roo-cline.helpButtonClicked": () => {