fix(browser): address review feedback — avoid panel auto-open race; include size on launch; send scaled coordinates in say; guard ResizeObserver cleanup

Author: hannesrudolph

src/core/task/Task.ts

@@ -380,17 +380,29 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 			// Broadcast to browser panel
 			this.broadcastBrowserSessionUpdate()
 
-			// When a browser session becomes active, automatically open/reveal the Browser Session tab
+			// When a browser session becomes active, automatically open/reveal the Browser Session tab.
+			// Defer to the microtask queue and re-check active state to avoid race conditions
+			// where the session could be closed before the panel opens.
 			if (isActive) {
 				try {
-					// Lazy-load to avoid circular imports at module load time
-					const { BrowserSessionPanelManager } = require("../webview/BrowserSessionPanelManager")
 					const providerRef = this.providerRef.deref()
-					if (providerRef) {
-						BrowserSessionPanelManager.getInstance(providerRef)
-							.show()
-							.catch(() => {})
-					}
+					if (!providerRef) return
+
+					Promise.resolve().then(async () => {
+						try {
+							// Ensure the session is still active before opening the panel
+							if (!(this.browserSession?.isSessionActive() ?? false)) return
+
+							// Lazy-load to avoid circular imports at module load time
+							const { BrowserSessionPanelManager } = require("../webview/BrowserSessionPanelManager")
+							const mgr = BrowserSessionPanelManager.getInstance(providerRef)
+							// New session: allow auto-open again
+							mgr.resetManualCloseFlag()
+							await mgr.show()
+						} catch {
+							// swallow
+						}
+					})
 				} catch (err) {
 					console.error("[Task] Failed to auto-open Browser Session panel:", err)
 				}

src/core/tools/browserActionTool.ts

@@ -115,11 +115,15 @@ export async function browserActionTool(
 				await cline.browserSession.launchBrowser()
 
 				// Create browser_action say message AFTER launching so status appears first
+				// Include size to keep message shape consistent with other actions
+				const vs = cline.browserSession.getViewportSize()
+				const launchSize = `${vs.width ?? 900}x${vs.height ?? 600}`
 				await cline.say(
 					"browser_action",
 					JSON.stringify({
 						action: "launch" as BrowserAction,
 						text: url,
+						size: launchSize,
 					} satisfies ClineSayBrowserAction),
 					undefined,
 					false,
@@ -187,7 +191,7 @@ export async function browserActionTool(
 					"browser_action",
 					JSON.stringify({
 						action: action as BrowserAction,
-						coordinate,
+						coordinate: processedCoordinate,
 						text,
 						size,
 					} satisfies ClineSayBrowserAction),

webview-ui/src/components/chat/BrowserSessionRow.tsx

@@ -196,7 +196,9 @@ const BrowserSessionRow = memo((props: BrowserSessionRowProps) => {
 	useEffect(() => {
 		const el = screenshotRef.current
 		if (!el) return
+		let mounted = true
 		const update = () => {
+			if (!mounted) return
 			const r = el.getBoundingClientRect()
 			setSW(r.width)
 			setSH(r.height)
@@ -206,6 +208,7 @@ const BrowserSessionRow = memo((props: BrowserSessionRowProps) => {
 			typeof window !== "undefined" && "ResizeObserver" in window ? new ResizeObserver(() => update()) : null
 		if (ro) ro.observe(el)
 		return () => {
+			mounted = false
 			if (ro) ro.disconnect()
 		}
 	}, [])