bug: space in folder and file name

Author: kunwarVivek

src/core/mentions/__tests__/index.test.ts

@@ -144,6 +144,46 @@ Detailed commit message with multiple lines
 			expect(result).toContain(`<git_commit hash="${commitHash}">`)
 			expect(result).toContain(`Error fetching commit info: ${errorMessage}`)
 		})
+
+		it("should parse file paths with spaces", async () => {
+			// Mock the file content fetching
+			const fileContent = "This is the content of the file with spaces in its name"
+
+			// Mock the getFileOrFolderContent function (which is called internally by parseMentions)
+			// This is done by mocking the fs.readFile that would be called inside getFileOrFolderContent
+			const fs = require("fs/promises")
+			jest.spyOn(fs, "readFile").mockResolvedValue(fileContent)
+			jest.spyOn(fs, "stat").mockResolvedValue({ isFile: () => true, isDirectory: () => false } as any)
+
+			const filePath = "/path/with spaces/my file.txt"
+			const result = await parseMentions(`Check out this file @${filePath}`, mockCwd, mockUrlContentFetcher)
+
+			// Verify the file path with spaces was correctly parsed
+			expect(result).toContain(`'path/with spaces/my file.txt' (see below for file content)`)
+			expect(result).toContain(`<file_content path="path/with spaces/my file.txt">`)
+		})
+
+		it("should parse folder paths with spaces", async () => {
+			// Mock the folder content fetching
+			const folderContent = "├── file1.txt\n├── file2.txt\n└── subfolder/"
+
+			// Mock the getFileOrFolderContent function (which is called internally by parseMentions)
+			// This is done by mocking the fs.readdir and fs.stat that would be called inside getFileOrFolderContent
+			const fs = require("fs/promises")
+			jest.spyOn(fs, "readdir").mockResolvedValue([
+				{ name: "file1.txt", isFile: () => true, isDirectory: () => false },
+				{ name: "file2.txt", isFile: () => true, isDirectory: () => false },
+				{ name: "subfolder", isFile: () => false, isDirectory: () => true }
+			])
+			jest.spyOn(fs, "stat").mockResolvedValue({ isFile: () => false, isDirectory: () => true } as any)
+
+			const folderPath = "/folder with spaces/"
+			const result = await parseMentions(`Check out this folder @${folderPath}`, mockCwd, mockUrlContentFetcher)
+
+			// Verify the folder path with spaces was correctly parsed
+			expect(result).toContain(`'folder with spaces/' (see below for folder content)`)
+			expect(result).toContain(`<folder_content path="folder with spaces/">`)
+		})
 	})
 
 	describe("openMention", () => {

src/shared/context-mentions.ts

@@ -1,28 +1,29 @@
 /*
 Mention regex:
-- **Purpose**: 
-  - To identify and highlight specific mentions in text that start with '@'. 
+- **Purpose**:
+  - To identify and highlight specific mentions in text that start with '@'.
   - These mentions can be file paths, URLs, or the exact word 'problems'.
   - Ensures that trailing punctuation marks (like commas, periods, etc.) are not included in the match, allowing punctuation to follow the mention without being part of it.
 
 - **Regex Breakdown**:
-  - `/@`: 
+  - `/@`:
 	- **@**: The mention must start with the '@' symbol.
-  
-  - `((?:\/|\w+:\/\/)[^\s]+?|problems\b|git-changes\b)`:
+
+  - `((?:\/|\w+:\/\/)(?:[^\s]|\s(?=[^\s]))+?|problems\b|git-changes\b)`:
 	- **Capturing Group (`(...)`)**: Captures the part of the string that matches one of the specified patterns.
-	- `(?:\/|\w+:\/\/)`: 
+	- `(?:\/|\w+:\/\/)`:
 	  - **Non-Capturing Group (`(?:...)`)**: Groups the alternatives without capturing them for back-referencing.
-	  - `\/`: 
+	  - `\/`:
 		- **Slash (`/`)**: Indicates that the mention is a file or folder path starting with a '/'.
 	  - `|`: Logical OR.
-	  - `\w+:\/\/`: 
+	  - `\w+:\/\/`:
 		- **Protocol (`\w+://`)**: Matches URLs that start with a word character sequence followed by '://', such as 'http://', 'https://', 'ftp://', etc.
-	- `[^\s]+?`: 
-	  - **Non-Whitespace Characters (`[^\s]+`)**: Matches one or more characters that are not whitespace.
+	- `(?:[^\s]|\s(?=[^\s]))+?`:
+	  - **Character Pattern**: Matches either a non-whitespace character OR a whitespace character that is followed by a non-whitespace character.
+	  - **This allows spaces within file paths while preventing trailing spaces**.
 	  - **Non-Greedy (`+?`)**: Ensures the smallest possible match, preventing the inclusion of trailing punctuation.
 	- `|`: Logical OR.
-	- `problems\b`: 
+	- `problems\b`:
 	  - **Exact Word ('problems')**: Matches the exact word 'problems'.
 	  - **Word Boundary (`\b`)**: Ensures that 'problems' is matched as a whole word and not as part of another word (e.g., 'problematic').
 		- `|`: Logical OR.
@@ -31,14 +32,14 @@ Mention regex:
       - **Word Boundary (`\b`)**: Ensures that 'terminal' is matched as a whole word and not as part of another word (e.g., 'terminals').
   - `(?=[.,;:!?]?(?=[\s\r\n]|$))`:
 	- **Positive Lookahead (`(?=...)`)**: Ensures that the match is followed by specific patterns without including them in the match.
-	- `[.,;:!?]?`: 
+	- `[.,;:!?]?`:
 	  - **Optional Punctuation (`[.,;:!?]?`)**: Matches zero or one of the specified punctuation marks.
-	- `(?=[\s\r\n]|$)`: 
+	- `(?=[\s\r\n]|$)`:
 	  - **Nested Positive Lookahead (`(?=[\s\r\n]|$)`)**: Ensures that the punctuation (if present) is followed by a whitespace character, a line break, or the end of the string.
-  
+
 - **Summary**:
   - The regex effectively matches:
-	- Mentions that are file or folder paths starting with '/' and containing any non-whitespace characters (including periods within the path).
+	- Mentions that are file or folder paths starting with '/' and can contain spaces within the path (e.g., 'my folder/my file.txt').
 	- URLs that start with a protocol (like 'http://') followed by any non-whitespace characters (including query parameters).
 	- The exact word 'problems'.
 	- The exact word 'git-changes'.
@@ -50,7 +51,7 @@ Mention regex:
 
 */
 export const mentionRegex =
-	/@((?:\/|\w+:\/\/)[^\s]+?|[a-f0-9]{7,40}\b|problems\b|git-changes\b|terminal\b)(?=[.,;:!?]?(?=[\s\r\n]|$))/
+	/@((?:\/|\w+:\/\/)(?:[^\s]|\s(?=[^\s]))+?|[a-f0-9]{7,40}\b|problems\b|git-changes\b|terminal\b)(?=[.,;:!?]?(?=[\s\r\n]|$))/
 export const mentionRegexGlobal = new RegExp(mentionRegex.source, "g")
 
 export interface MentionSuggestion {

webview-ui/src/utils/__tests__/context-mentions.test.ts

@@ -372,4 +372,14 @@ describe("shouldShowContextMenu", () => {
 		// Position cursor at the end to test the full word
 		expect(shouldShowContextMenu("@problems", 9)).toBe(true)
 	})
+
+	it("should return true for file paths with spaces", () => {
+		// Test with a file path containing spaces
+		expect(shouldShowContextMenu("@/path/to/my file.txt", 20)).toBe(true)
+	})
+
+	it("should return true for folder paths with spaces", () => {
+		// Test with a folder path containing spaces
+		expect(shouldShowContextMenu("@/path/to/my folder/", 20)).toBe(true)
+	})
 })