fix spelling problem

Author: aheizi

src/services/mcp/config/ConfigManager.ts

@@ -9,7 +9,7 @@ import { GlobalFileNames } from "../../../shared/globalFileNames"
 import { fileExistsAtPath } from "../../../utils/fs"
 import { ServerConfig, McpServer, ConfigSource } from "../types"
 import { ConfigChangeEvent, ConfigChangeListener } from "./types"
-import { safeParseSeverConfig } from "./validation"
+import { safeParseServerConfig } from "./validation"
 
 /**
  * Configuration Manager
@@ -92,7 +92,6 @@ export class ConfigManager {
 	 * @param error Error object
 	 */
 	private showErrorMessage(message: string, error: unknown): never {
-		const errorMessage = error instanceof Error ? error.message : `${error}`
 		console.error(`${message}:`, error)
 		if (vscode.window && typeof vscode.window.showErrorMessage === "function") {
 			vscode.window.showErrorMessage(message)
@@ -122,7 +121,7 @@ export class ConfigManager {
 	public validateServerConfig(config: unknown, serverName?: string): ServerConfig {
 		try {
 			const configCopy = { ...(config as Record<string, unknown>) }
-			const result = safeParseSeverConfig(configCopy)
+			const result = safeParseServerConfig(configCopy)
 			if (!result.success) {
 				const errors = result.error.errors.map((err) => `${err.path.join(".")}: ${err.message}`).join(", ")
 				throw new Error(t("common:errors.invalid_mcp_settings_validation", { errorMessages: errors }))

src/services/mcp/config/validation.ts

@@ -64,6 +64,6 @@ export const validateServerConfig = (config: unknown): ServerConfig => {
  * @param config The configuration object to validate
  * @returns The validation result
  */
-export const safeParseSeverConfig = (config: unknown): z.SafeParseReturnType<unknown, ServerConfig> => {
+export const safeParseServerConfig = (config: unknown): z.SafeParseReturnType<unknown, ServerConfig> => {
 	return createServerConfigSchema().safeParse(config)
 }

src/services/mcp/connection/ConnectionFactory.ts

@@ -1,7 +1,7 @@
 import { ServerConfig, McpConnection, McpServer, ConfigSource } from "../types"
 import { ConnectionHandler } from "./ConnectionHandler"
 import { FileWatcher } from "./FileWatcher"
-import { ConfigManager } from "../config/ConfigManager"
+import { ConfigManager } from "../config"
 
 /**
  * Connection factory class
@@ -70,14 +70,25 @@ export class ConnectionFactory {
 		}
 
 		// Prefer parameter callback, otherwise use the callback from factory constructor
-		const statusChangeCb = onStatusChange
-			? (server: McpServer) => {
-					onStatusChange(server)
-					if (this.onStatusChange) this.onStatusChange(server)
+		let statusChangeCb: ((server: McpServer) => void) | undefined
+
+		if (onStatusChange) {
+			// If parameter callback is provided, call both it and the factory callback if present
+			statusChangeCb = (server: McpServer) => {
+				onStatusChange(server)
+				if (this.onStatusChange) {
+					this.onStatusChange(server)
 				}
-			: this.onStatusChange
-				? (server: McpServer) => this.onStatusChange && this.onStatusChange(server)
-				: undefined
+			}
+		} else if (this.onStatusChange) {
+			// If only factory callback is present, use that
+			statusChangeCb = (server: McpServer) => {
+				this.onStatusChange!(server)
+			}
+		} else {
+			// No callbacks provided
+			statusChangeCb = undefined
+		}
 
 		// Use handler to create connection
 		const connection = await handler.createConnection(name, patchedConfig, source, statusChangeCb)