Treat HistoryView item clicks as (de)select in selection mode

Author: jr

webview-ui/src/components/history/HistoryView.tsx

@@ -83,6 +83,7 @@ const HistoryView = ({ onDone }: HistoryViewProps) => {
 						<Button
 							variant={isSelectionMode ? "default" : "secondary"}
 							onClick={toggleSelectionMode}
+							data-testid="toggle-selection-mode-button"
 							title={
 								isSelectionMode
 									? `${t("history:exitSelectionMode")}`
@@ -217,8 +218,10 @@ const HistoryView = ({ onDone }: HistoryViewProps) => {
 								"bg-vscode-list-activeSelectionBackground":
 									isSelectionMode && selectedTaskIds.includes(item.id),
 							})}
-							onClick={(e) => {
-								if (!isSelectionMode || !(e.target as HTMLElement).closest(".task-checkbox")) {
+							onClick={() => {
+								if (isSelectionMode) {
+									toggleTaskSelection(item.id, !selectedTaskIds.includes(item.id))
+								} else {
 									vscode.postMessage({ type: "showTaskWithId", text: item.id })
 								}
 							}}>

webview-ui/src/components/history/__tests__/HistoryView.test.tsx

@@ -148,6 +148,23 @@ describe("HistoryView", () => {
 		})
 	})
 
+	it("handles selection mode clicks", async () => {
+		const onDone = jest.fn()
+		render(<HistoryView onDone={onDone} />)
+
+		// Go to selection mode
+		fireEvent.click(screen.getByTestId("toggle-selection-mode-button"))
+
+		const taskContainer = screen.getByTestId("task-item-1")
+
+		// Click anywhere in the task item
+		fireEvent.click(taskContainer)
+
+		// Check the box instead of sending a message to open the task
+		expect(within(taskContainer).getByRole("checkbox")).toBeChecked()
+		expect(vscode.postMessage).not.toHaveBeenCalled()
+	})
+
 	describe("task deletion", () => {
 		it("shows confirmation dialog on regular click", () => {
 			const onDone = jest.fn()