code review

Author: liwilliam2021

src/core/tools/contextValidator.ts

@@ -1,4 +1,3 @@
-import { promises as fs } from "fs"
 import { Task } from "../task/Task"
 import { readLines } from "../../integrations/misc/read-lines"
 import { getModelMaxOutputTokens } from "../../shared/api"

src/core/tools/readFileTool.ts

@@ -488,7 +488,7 @@ export async function readFileTool(
 					try {
 						const defResult = await parseSourceCodeDefinitionsForFile(fullPath, cline.rooIgnoreController)
 						if (defResult) {
-							let xmlInfo = `<notice>Showing only ${effectiveMaxReadFileLine} of ${totalLines} total lines. Use line_range if you need to read more lines</notice>\n`
+							let xmlInfo = `<notice>${t("tools.readFile.showingOnlyLines", { shown: effectiveMaxReadFileLine, total: totalLines })}</notice>\n`
 							updateFileResult(relPath, {
 								xmlContent: `<file><path>${relPath}</path>\n<list_code_definition_names>${defResult}</list_code_definition_names>\n${xmlInfo}</file>`,
 							})
@@ -520,9 +520,10 @@ export async function readFileTool(
 						// Add appropriate notice based on whether this was a preemptive limit or user setting
 						if (validationNotice) {
 							// When shouldLimit is true, always provide inline instructions
-							xmlInfo += `<notice>${validationNotice}\n\nTo read specific sections of this file, use the following format:\n<read_file>\n<args>\n  <file>\n    <path>${relPath}</path>\n    <line_range>start-end</line_range>\n  </file>\n</args>\n</read_file>\n\nFor example, to read lines 2001-3000:\n<read_file>\n<args>\n  <file>\n    <path>${relPath}</path>\n    <line_range>2001-3000</line_range>\n  </file>\n</args>\n</read_file></notice>\n`
+							const instructions = t("tools.readFile.contextLimitInstructions", { path: relPath })
+							xmlInfo += `<notice>${validationNotice}\n\n${instructions}</notice>\n`
 						} else {
-							xmlInfo += `<notice>Showing only ${effectiveMaxReadFileLine} of ${totalLines} total lines. Use line_range if you need to read more lines</notice>\n`
+							xmlInfo += `<notice>${t("tools.readFile.showingOnlyLines", { shown: effectiveMaxReadFileLine, total: totalLines })}</notice>\n`
 						}
 
 						updateFileResult(relPath, {

src/i18n/locales/ca/tools.json

@@ -2,7 +2,9 @@
 	"readFile": {
 		"linesRange": " (lines {{start}}-{{end}})",
 		"definitionsOnly": " (definitions only)",
-		"maxLines": " (max {{max}} lines)"
+		"maxLines": " (max {{max}} lines)",
+		"showingOnlyLines": "Showing only {{shown}} of {{total}} total lines. Use line_range if you need to read more lines",
+		"contextLimitInstructions": "To read specific sections of this file, use the following format:\n<read_file>\n<args>\n  <file>\n    <path>{{path}}</path>\n    <line_range>start-end</line_range>\n  </file>\n</args>\n</read_file>\n\nFor example, to read lines 2001-3000:\n<read_file>\n<args>\n  <file>\n    <path>{{path}}</path>\n    <line_range>2001-3000</line_range>\n  </file>\n</args>\n</read_file>"
 	},
 	"toolRepetitionLimitReached": "Roo appears to be stuck in a loop, attempting the same action ({{toolName}}) repeatedly. This might indicate a problem with its current strategy. Consider rephrasing the task, providing more specific instructions, or guiding it towards a different approach.",
 	"codebaseSearch": {