fix: Update global import to preserve rules file structure

- Modified importModeWithRules to treat global imports same as project-level
- Rules files now created in global .roo/rules-{slug}/ folder
- Updated all translation files to reflect new behavior
- Fixes issue where rules were being squashed into custom instructions

Author: hannesrudolph

src/core/config/CustomModesManager.ts

@@ -9,6 +9,7 @@ import { type ModeConfig, customModesSettingsSchema, modeConfigSchema } from "@r
 
 import { fileExistsAtPath } from "../../utils/fs"
 import { getWorkspacePath } from "../../utils/path"
+import { getGlobalRooDirectory } from "../../services/roo-config"
 import { logger } from "../../utils/logging"
 import { GlobalFileNames } from "../../shared/globalFileNames"
 import { ensureSettingsDirectoryExists } from "../../utils/globalContext"
@@ -834,29 +835,50 @@ export class CustomModesManager {
 						}
 					}
 				} else if (source === "global" && rulesFiles && Array.isArray(rulesFiles)) {
-					// For global imports, we need to merge the rules content into the mode's customInstructions
-					let mergedInstructions = modeConfig.customInstructions || ""
+					// For global imports, preserve the rules files structure in the global .roo directory
+					const globalRooDir = getGlobalRooDirectory()
 
-					// Add a separator if there are existing instructions
-					if (mergedInstructions) {
-						mergedInstructions += "\n\n"
+					// Always remove the existing rules folder for this mode if it exists
+					// This ensures that if the imported mode has no rules, the folder is cleaned up
+					const rulesFolderPath = path.join(globalRooDir, `rules-${importMode.slug}`)
+					try {
+						await fs.rm(rulesFolderPath, { recursive: true, force: true })
+						logger.info(`Removed existing global rules folder for mode ${importMode.slug}`)
+					} catch (error) {
+						// It's okay if the folder doesn't exist
+						logger.debug(`No existing global rules folder to remove for mode ${importMode.slug}`)
 					}
 
-					// Add the rules content
-					mergedInstructions += "# Imported Rules\n\n"
-
+					// Import the new rules files with path validation
 					for (const ruleFile of rulesFiles) {
-						if (ruleFile.content) {
-							mergedInstructions += `# Rules from ${ruleFile.relativePath}:\n${ruleFile.content}\n\n`
+						if (ruleFile.relativePath && ruleFile.content) {
+							// Validate the relative path to prevent path traversal attacks
+							const normalizedRelativePath = path.normalize(ruleFile.relativePath)
+
+							// Ensure the path doesn't contain traversal sequences
+							if (normalizedRelativePath.includes("..") || path.isAbsolute(normalizedRelativePath)) {
+								logger.error(`Invalid file path detected: ${ruleFile.relativePath}`)
+								continue // Skip this file but continue with others
+							}
+
+							const targetPath = path.join(globalRooDir, normalizedRelativePath)
+							const normalizedTargetPath = path.normalize(targetPath)
+							const expectedBasePath = path.normalize(globalRooDir)
+
+							// Ensure the resolved path stays within the global .roo directory
+							if (!normalizedTargetPath.startsWith(expectedBasePath)) {
+								logger.error(`Path traversal attempt detected: ${ruleFile.relativePath}`)
+								continue // Skip this file but continue with others
+							}
+
+							// Ensure directory exists
+							const targetDir = path.dirname(targetPath)
+							await fs.mkdir(targetDir, { recursive: true })
+
+							// Write the file
+							await fs.writeFile(targetPath, ruleFile.content, "utf-8")
 						}
 					}
-
-					// Update the mode with merged instructions
-					await this.updateCustomMode(importMode.slug, {
-						...modeConfig,
-						source: source,
-						customInstructions: mergedInstructions.trim(),
-					})
 				}
 			}
 

webview-ui/src/i18n/locales/de/prompts.json

@@ -64,7 +64,7 @@
 		"importing": "Importiere...",
 		"global": {
 			"label": "Globale Ebene",
-			"description": "Verfügbar in allen Projekten. Regeln werden in benutzerdefinierte Anweisungen zusammengeführt."
+			"description": "Verfügbar in allen Projekten. Wenn der exportierte Modus Regeldateien enthielt, werden diese im globalen Ordner .roo/rules-{slug}/ neu erstellt."
 		},
 		"project": {
 			"label": "Projektebene",

webview-ui/src/i18n/locales/en/prompts.json

@@ -63,7 +63,7 @@
 		"importing": "Importing...",
 		"global": {
 			"label": "Global Level",
-			"description": "Available across all projects. Rules will be merged into custom instructions."
+			"description": "Available across all projects. If the exported mode contained rules files, they will be recreated in the global .roo/rules-{slug}/ folder."
 		},
 		"project": {
 			"label": "Project Level",

webview-ui/src/i18n/locales/es/prompts.json

@@ -64,7 +64,7 @@
 		"importing": "Importando...",
 		"global": {
 			"label": "Nivel global",
-			"description": "Disponible en todos los proyectos. Las reglas se fusionarán con las instrucciones personalizadas."
+			"description": "Disponible en todos los proyectos. Si el modo exportado contenía archivos de reglas, se volverán a crear en la carpeta global .roo/rules-{slug}/."
 		},
 		"project": {
 			"label": "Nivel de proyecto",

webview-ui/src/i18n/locales/fr/prompts.json

@@ -64,7 +64,7 @@
 		"importing": "Importation...",
 		"global": {
 			"label": "Niveau global",
-			"description": "Disponible dans tous les projets. Les règles seront fusionnées dans les instructions personnalisées."
+			"description": "Disponible dans tous les projets. Si le mode exporté contenait des fichiers de règles, ils seront recréés dans le dossier global .roo/rules-{slug}/."
 		},
 		"project": {
 			"label": "Niveau projet",

webview-ui/src/i18n/locales/zh-CN/prompts.json

@@ -64,7 +64,7 @@
 		"importing": "导入中...",
 		"global": {
 			"label": "全局",
-			"description": "适用于所有项目。规则将合并到自定义指令中。"
+			"description": "适用于所有项目。如果导出的模式包含规则文件，则将在全局 .roo/rules-{slug}/ 文件夹中重新创建这些文件。"
 		},
 		"project": {
 			"label": "项目级",